fix(test): assert real shipped behaviour for signed-out /products #9

2026-05-19T15:05:42Z

sharang commented

2026-05-19 15:05:42 +00:00

The original /products gate test branched on whether the user was signed in. In practice the page always renders NotAuthorized (403) for signed-out sessions, so the test's signed-out branch never matched.

Tighten the assertion to match shipped behaviour. Widen again when M10.1 adds a shared sign-in redirect for protected routes.

Refs: M5.3

The original `/products` gate test branched on whether the user was signed in. In practice the page always renders NotAuthorized (403) for signed-out sessions, so the test's signed-out branch never matched. Tighten the assertion to match shipped behaviour. Widen again when M10.1 adds a shared sign-in redirect for protected routes. Refs: M5.3

sharang added 1 commit 2026-05-19 15:05:43 +00:00

fix(test): assert real shipped behaviour for signed-out /products

ci / test (pull_request) Successful in 33s

Details

ci / shared (pull_request) Successful in 6s

Details

ci / e2e (pull_request) Has been skipped

Details

ci / image (pull_request) Has been skipped

Details

d3a2b5e2ab

The original /products gate test expected either a Products heading
(signed-in) or a Sign-in button (signed-out). In practice the page
renders NotAuthorized (403) for any session without the right
org_role, so the second branch never matched and the test failed.

The Sign-in surface is dashboard-only today. Once M10.1 wires a
shared sign-in redirect for protected routes, widen this test.

Refs: M5.3

sharang merged commit 3310a942f2 into main

2026-05-19 15:09:02 +00:00

sharang deleted branch fix/e2e-products

2026-05-19 15:09:02 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: platform/portal#9