fix(orchestrator): run semantic control mapping on PLC findings #229

Merged

sharang merged 1 commits from fix/plc-control-mapping into main 2026-07-22 13:16:53 +00:00

Conversation 0 Commits 1 Files Changed 1

+15 -1

sharang commented 2026-07-22 13:09:49 +00:00

Owner

Copy Link

Copy Source

run_plc_scan is a separate path from run_pipeline and never called the control-mapping passes — so IEC 61131-3 PLC findings (pump_station.st etc.) were persisted with empty control_refs even when mapping is enabled. They carry file_path/line/cwe, so the semantic pass now runs per source and stamps master-control refs. (LUT + grounded passes are code-pattern/CRA-specific and don't apply to control logic.)

Green locally (clippy -D warnings, fmt, full suite).

🤖 Generated with Claude Code

`run_plc_scan` is a separate path from `run_pipeline` and never called the control-mapping passes — so IEC 61131-3 PLC findings (`pump_station.st` etc.) were persisted with **empty control_refs** even when mapping is enabled. They carry `file_path`/`line`/`cwe`, so the semantic pass now runs per source and stamps master-control refs. (LUT + grounded passes are code-pattern/CRA-specific and don't apply to control logic.) Green locally (clippy -D warnings, fmt, full suite). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

sharang added 1 commit 2026-07-22 13:09:50 +00:00

fix(orchestrator): run semantic control mapping on PLC findings ... 6ae5d9a07f

run_plc_scan is a separate path from run_pipeline and never called the
control-mapping passes, so IEC 61131-3 (pump_station.st etc.) findings were
persisted with empty control_refs even with mapping enabled. PLC findings carry
file_path/line/cwe, so the semantic pass now runs per source (its region is read
under that source's working path) and stamps master-control refs. LUT + grounded
passes are code-pattern/CRA-specific and don't apply to control logic, so only the
semantic pass runs on the PLC path.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

sharang merged commit 51bab61f77 into main 2026-07-22 13:16:53 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

P0-demo

CERTifAI P0 demo build tickets (CS-*)

bug

critical

enhancement

epic

Tracking issue spanning multiple sub-issues

high

infrastructure

onboarding

Multi-target onboarding wizard redesign

performance

security

v0.3.0

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

Benjamin_Boenisch sharang (Sharang Parnerkar)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sharang/compliance-scanner-agent#229