sharang/compliance-scanner-agent
1
0
Fork 0
Code Issues 79 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

fix(orchestrator): refresh control_refs on existing findings during re-scan #228

Merged
sharang merged 1 commits from fix/refresh-control-refs into main 2026-07-22 12:24:37 +00:00
Conversation 0 Commits 1 Files Changed 1
+20 -1
sharang commented 2026-07-22 12:18:06 +00:00
Owner
Copy Link
Copy Source

The dedup loop only inserted first-seen findings; re-scans skipped existing fingerprints, so control_refs recomputed by the mapping passes were discarded. A finding first seen before control mapping was enabled/tuned never gained its mappings without a delete + re-add.

Fix: existing findings whose re-scan produced non-empty control_refs are now updated in place ($set control_refs). Guarded on non-empty so a run where mapping didn't happen (breakpilot unreachable) can't wipe existing refs. New-finding insert path unchanged.

Green locally (clippy -D warnings, fmt, full suite).

🤖 Generated with Claude Code

The dedup loop only **inserted** first-seen findings; re-scans skipped existing fingerprints, so `control_refs` recomputed by the mapping passes were discarded. A finding first seen *before* control mapping was enabled/tuned never gained its mappings without a delete + re-add. Fix: existing findings whose re-scan produced **non-empty** `control_refs` are now updated in place (`$set control_refs`). Guarded on non-empty so a run where mapping didn't happen (breakpilot unreachable) can't wipe existing refs. New-finding insert path unchanged. Green locally (clippy -D warnings, fmt, full suite). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
sharang added 1 commit 2026-07-22 12:18:06 +00:00
fix(orchestrator): refresh control_refs on existing findings during re-scan
CI / Check (pull_request) Successful in 5m40s
Details
CI / Detect Changes (pull_request) Skipped
Details
CI / Deploy Agent (pull_request) Skipped
Details
CI / Deploy Dashboard (pull_request) Skipped
Details
CI / Deploy Docs (pull_request) Skipped
Details
CI / Deploy MCP (pull_request) Skipped
Details
CI / Check (push) Skipped
6af84c5216 
The dedup loop only inserted first-seen findings; re-scans skipped existing
fingerprints entirely, so control_refs (re)computed by the mapping passes were
discarded. A finding first seen before control mapping was enabled/tuned would
therefore never gain its control mappings without being deleted + re-added.

Now: existing findings whose re-scan produced non-empty control_refs get updated
in place ($set control_refs). Guarded on non-empty so a run where mapping didn't
run (breakpilot unreachable) can't wipe existing refs. New findings unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sharang merged commit 5bdc35ee92 into main 2026-07-22 12:24:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-demo
CERTifAI P0 demo build tickets (CS-*)
 bug
critical
enhancement
epic
Tracking issue spanning multiple sub-issues
 high
infrastructure
onboarding
Multi-target onboarding wizard redesign
 performance
security
v0.3.0
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Benjamin_Boenisch sharang (Sharang Parnerkar)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sharang/compliance-scanner-agent#228