feat(onboarding): enable opt-in scans from the wizard success step #181

Merged

sharang merged 2 commits from feat/enable-optin-scans into main 2026-07-16 20:52:51 +00:00

Conversation 0 Commits 2 Files Changed 2

+103 -3

sharang commented 2026-07-16 20:33:48 +00:00

Owner

Copy Link

Copy Source

Adds a checkbox per applicable-but-default-off scan (e.g. the ICS probe) on the onboarding success step, plus an enable_target_scans server fn that PATCHes scan_config.enabled_scans. Run scan persists the ticked scans before triggering, so the first run includes them. Unblocks Demo C (ICS probe against plc-sim).

Adds a checkbox per applicable-but-default-off scan (e.g. the ICS probe) on the onboarding success step, plus an `enable_target_scans` server fn that PATCHes `scan_config.enabled_scans`. Run scan persists the ticked scans before triggering, so the first run includes them. Unblocks Demo C (ICS probe against plc-sim).

sharang added 1 commit 2026-07-16 20:33:49 +00:00

feat(onboarding): enable opt-in scans from the wizard success step ... 74ced0d740

The ICS probe (ScanType::IcsProbe) and other default-off scans are
applicable to a target but excluded from a run unless the target's
scan_config.enabled_scans lists them — build_scan_plan only includes a
scan when default_on || enabled_scans.contains(scan). Until now the
wizard had no way to enable them, so they could never be triggered.

Add a checkbox per applicable-but-default-off scan on the success step,
and a new enable_target_scans server fn that PATCHes
/api/v1/targets/{id} with { scan_config: { enabled_scans } }. Run scan
now persists the ticked scans (serde names, e.g. "icsprobe") before
triggering, so the first run includes them.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

sharang added 1 commit 2026-07-16 20:36:36 +00:00

feat(onboarding): accept modbus:// and opc.tcp:// live-URL refs ... 37dac862e8

The ICS probe targets a device's OT ports (Modbus 502, OPC UA 4840,
EtherNet/IP 44818) via the target's LiveUrl artifact. The wizard's
client-side validation only accepted http(s):// refs, so a PLC endpoint
like modbus://plc:502 was rejected and the probe could never be
onboarded. parse_endpoint already understands the modbus:// scheme;
this just lets the ref through the wizard.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

sharang merged commit cd65fa345c into main 2026-07-16 20:52:51 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

P0-demo

CERTifAI P0 demo build tickets (CS-*)

bug

critical

enhancement

epic

Tracking issue spanning multiple sub-issues

high

infrastructure

onboarding

Multi-target onboarding wizard redesign

performance

security

v0.3.0

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

Benjamin_Boenisch sharang (Sharang Parnerkar)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sharang/compliance-scanner-agent#181