sharang/compliance-scanner-agent
1
0
Fork 0
Code Issues 79 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

feat(ics): dynamic Modbus/TCP probe for PLC/SPS devices [#148] #172

Merged
sharang merged 2 commits from feat/ics-modbus-probe into main 2026-07-16 16:25:05 +00:00
Conversation 0 Commits 2 Files Changed 8
+426 -1
2 Commits
Author SHA1 Message Date
Sharang ParnerkarandClaude Opus 4.8 e59c8add18 fix(ics): drop test-only imports already provided by use super::*
CI / Check (pull_request) Successful in 5m21s
Details
CI / Detect Changes (pull_request) Has been skipped
Details
CI / Deploy Docs (pull_request) Has been skipped
Details
CI / Deploy MCP (pull_request) Has been skipped
Details
CI / Deploy Agent (pull_request) Has been skipped
Details
CI / Deploy Dashboard (pull_request) Has been skipped
Details 
CI compiles the test build with RUSTFLAGS=-D warnings; the two explicit
tokio::io trait imports in the modbus test module were redundant with
`use super::*` and failed the "Main Tests" step as unused imports.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-07-16 18:19:18 +02:00
Sharang ParnerkarandClaude Opus 4.8 5e8250f7e9 feat(ics): dynamic Modbus/TCP probe for PLC/SPS devices (#148)
CI / Deploy MCP (pull_request) Has been skipped
Details
CI / Check (pull_request) Failing after 4m3s
Details
CI / Detect Changes (pull_request) Has been skipped
Details
CI / Deploy Agent (pull_request) Has been skipped
Details
CI / Deploy Dashboard (pull_request) Has been skipped
Details
CI / Deploy Docs (pull_request) Has been skipped
Details 
Adds the first dynamic dimension to PLC/SPS targets: probe the running device
over industrial protocols, complementing the static control-logic rules.

- New ScanType::IcsProbe (+ phase), offered for PlcSps with a reachable endpoint
  (opt-in / default-off).
- pipeline::ics::modbus — a minimal, read-only Modbus/TCP client: issues Read
  Holding Registers + Read Device Identification, never writes to the live
  process. Detects an endpoint that answers unauthenticated Modbus and reads its
  device identity (vendor/product/revision).
- pipeline::ics::probe_target — emits findings: `ics-modbus-exposed` (Critical,
  CWE-306 — Modbus/TCP has no auth/encryption by protocol design) and
  `ics-device-disclosure` (Low, CWE-200). Targets the Modbus port (502) of the
  target's Live URL, independent of any WebVisu HTTP port.
- orchestrator: a PLC/SPS target runs the ICS probe when planned (alongside the
  control-logic scan and DAST).

Unit-tested against an in-process mock Modbus server + endpoint-parsing and
device-id parsing tests. Docs: new "Dynamic testing — ICS protocol probe" section.

First increment of #148 (soft-PLC + industrial-protocol probing); OPC UA /
EtherNet-IP and the OpenPLC soft-PLC harness (orca-infra) follow. Tracker #167.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-07-16 18:05:34 +02:00