Wires the built-but-unused classification and DAST paths into the unified scan (run_target, behind UNIFIED_PIPELINE), so onboarded targets are actually detected and dynamically scanned.
classify_and_store — ingests the target's artifacts and runs classify_target (tramiton-core in-process for firmware/RTOS/Yocto + MCU/board; heuristics otherwise), storing the Classification on the target. Best-effort. This makes firmware detection real during a scan (previously the classifier was built + unit-tested but never invoked with real cloned paths).
ensure_dast_target — when DAST is planned and the target has a LiveUrl artifact, provisions a DastTarget (repo_id = target id) so the existing DAST trigger fires for wizard-created targets, not just migrated ones. Idempotent.
Both run before the code pipeline. Passes fmt + clippy -D warnings.
Known follow-up: classification ingest clones the git repo separately from the scan pipeline's clone (double-clone) — a perf optimization, not a correctness issue.
Wires the built-but-unused **classification** and **DAST** paths into the unified scan (`run_target`, behind `UNIFIED_PIPELINE`), so onboarded targets are actually detected and dynamically scanned.
- **`classify_and_store`** — ingests the target's artifacts and runs `classify_target` (**tramiton-core in-process** for firmware/RTOS/Yocto + MCU/board; heuristics otherwise), storing the `Classification` on the target. Best-effort. **This makes firmware detection real during a scan** (previously the classifier was built + unit-tested but never invoked with real cloned paths).
- **`ensure_dast_target`** — when DAST is planned and the target has a `LiveUrl` artifact, provisions a `DastTarget` (`repo_id` = target id) so the existing DAST trigger fires for **wizard-created** targets, not just migrated ones. Idempotent.
Both run before the code pipeline. Passes fmt + clippy `-D warnings`.
**Known follow-up:** classification ingest clones the git repo separately from the scan pipeline's clone (double-clone) — a perf optimization, not a correctness issue.
Refs #133, #135, #118.
sharang
added this to the Onboarding v1 milestone 2026-07-12 21:35:56 +00:00
Wire the built-but-unused classification + DAST paths into the unified scan so
onboarded targets are actually detected and dynamically scanned:
- classify_and_store: ingests the target's artifacts and runs classify_target
(tramiton-core in-process for firmware/RTOS/Yocto + MCU/board; heuristics for
the rest), storing the Classification on the target. Best-effort — never fails
a scan. This is what makes firmware detection real during a scan.
- ensure_dast_target: when DAST is planned and the target has a LiveUrl artifact,
provisions a DastTarget (repo_id = target id) so the existing DAST trigger
fires for wizard-created targets, not just migrated ones. Idempotent.
Both run inside run_target (behind UNIFIED_PIPELINE), before the code pipeline.
Note: classification ingest currently clones the git repo separately from the
scan pipeline's clone (double-clone) — a perf follow-up, not a correctness issue.
Refs #133, #135, #118.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sharang
merged commit 0e57c2d7a7 into main2026-07-12 21:49:23 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Wires the built-but-unused classification and DAST paths into the unified scan (
run_target, behindUNIFIED_PIPELINE), so onboarded targets are actually detected and dynamically scanned.classify_and_store— ingests the target's artifacts and runsclassify_target(tramiton-core in-process for firmware/RTOS/Yocto + MCU/board; heuristics otherwise), storing theClassificationon the target. Best-effort. This makes firmware detection real during a scan (previously the classifier was built + unit-tested but never invoked with real cloned paths).ensure_dast_target— when DAST is planned and the target has aLiveUrlartifact, provisions aDastTarget(repo_id= target id) so the existing DAST trigger fires for wizard-created targets, not just migrated ones. Idempotent.Both run before the code pipeline. Passes fmt + clippy
-D warnings.Known follow-up: classification ingest clones the git repo separately from the scan pipeline's clone (double-clone) — a perf optimization, not a correctness issue.
Refs #133, #135, #118.