refactor: remove dead code, hollow stubs, and orphaned modules #2

Merged

sharang merged 2 commits from feat/dead-code-cleanup into main 2026-04-20 05:51:02 +00:00

Conversation 0 Commits 2 Files Changed 13 +11 -4063

sharang commented 2026-04-20 05:36:17 +00:00

Owner

Copy Link

Summary

• Backend: Delete 6 orphaned schema sub-modules (ai_system, bsi, dashboard, isms_governance, report, service_module) — never imported by any route or service (confirmed via grep)
• Frontend: Delete 2 hollow stub pages (sdk/agents/sessions, sdk/agents/statistics) that only render a "future implementation" placeholder with no wired API
• Frontend: Delete 2 orphaned demo API routes (/api/sdk/v1/demo/seed, /api/sdk/v1/demo/clear) — never called; real seeding uses apiClient.saveState()
• Frontend: Remove unimplemented PDF export button and alert() stub from the retention page (sdk/einwilligungen/retention)

Test plan

• ruff check backend-compliance/ passes
• pytest compliance/tests/ -x passes
• npx tsc --noEmit passes in admin-compliance/
• npm run build passes in admin-compliance/

Notes

models.py LOC violation (1643 lines, cap 500) is not fixed here — EvidenceConfidenceEnum and EvidenceTruthStatusEnum are defined inline and referenced across routes, repos, and tests. Migrating them is a separate, higher-risk PR.

## Summary - **Backend**: Delete 6 orphaned schema sub-modules (`ai_system`, `bsi`, `dashboard`, `isms_governance`, `report`, `service_module`) — never imported by any route or service (confirmed via grep) - **Frontend**: Delete 2 hollow stub pages (`sdk/agents/sessions`, `sdk/agents/statistics`) that only render a "future implementation" placeholder with no wired API - **Frontend**: Delete 2 orphaned demo API routes (`/api/sdk/v1/demo/seed`, `/api/sdk/v1/demo/clear`) — never called; real seeding uses `apiClient.saveState()` - **Frontend**: Remove unimplemented PDF export button and `alert()` stub from the retention page (`sdk/einwilligungen/retention`) ## Test plan - [ ] `ruff check backend-compliance/` passes - [ ] `pytest compliance/tests/ -x` passes - [ ] `npx tsc --noEmit` passes in `admin-compliance/` - [ ] `npm run build` passes in `admin-compliance/` ## Notes `models.py` LOC violation (1643 lines, cap 500) is **not** fixed here — `EvidenceConfidenceEnum` and `EvidenceTruthStatusEnum` are defined inline and referenced across routes, repos, and tests. Migrating them is a separate, higher-risk PR.

sharang added 1 commit 2026-04-20 05:36:20 +00:00

refactor: remove dead code, hollow stubs, and orphaned modules ... 78e47c96bd

Backend — delete 6 orphaned schema sub-modules never imported by any route:
  compliance/schemas/{ai_system,bsi,dashboard,isms_governance,report,service_module}.py
  All symbols were only accessible through the monolithic schemas.py barrel;
  the split files were never wired up and created misleading import paths.

Frontend — delete 2 hollow "future implementation" stub pages:
  app/sdk/agents/sessions/page.tsx
  app/sdk/agents/statistics/page.tsx
  Both showed a static placeholder with no API calls or real functionality.

Frontend — delete dead demo seed/clear API routes:
  app/api/sdk/v1/demo/{seed,clear}/route.ts
  Used a global in-memory store never connected to PostgreSQL.
  The actual demo seeding (lib/sdk/demo-data/) goes through the real
  state API (apiClient.saveState/deleteState), not these routes.

Frontend — remove unimplemented PDF export alert from retention page:
  app/sdk/einwilligungen/retention/page.tsx
  Removed the PDF button and alert('PDF-Export wird noch implementiert.')
  stub. CSV and JSON export remain fully functional.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

sharang added 1 commit 2026-04-20 05:50:43 +00:00

fix: strip duplicate inline class definitions from db shim files ... 3702f70754

models.py and repository.py are backwards-compat re-export shims from
Phase 1. Both files still contained the original 1466/1547 line class
definitions below the re-export block. These inline definitions shadowed
the correctly-imported sub-module versions and failed at import time
because Column, AuditResultEnum, etc. were no longer in scope.

Fix:
- models.py: remove all duplicate Base-subclass definitions (lines 209-
  1581). Retain EvidenceConfidenceEnum and EvidenceTruthStatusEnum (unique
  to this shim, not yet extracted to a sub-module) and the two models that
  have no sub-module yet: LLMGenerationAuditDB and AssertionDB. Add back
  the SQLAlchemy column-type imports those two models need.
- repository.py: remove all duplicate Repository class definitions (lines
  40-1692). All classes are now fully provided by the sub-repositories.

Result: 172 pytest tests pass, import OK.

sharang merged commit 5231490ccc into main 2026-04-20 05:51:02 +00:00

sharang referenced this issue from a commit 2026-04-20 05:51:04 +00:00

refactor: remove dead code, hollow stubs, and orphaned modules (#2)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

config

Env vars, secrets management, startup validation

data-integrity

Transactions, indexes, pagination

frontend

Next.js, client-side concerns

observability

Logging, audit trails, health checks

reliability

Error handling, retries, circuit breakers

security

Auth, secrets, injection, tenant isolation

severity: critical

System-level risk, data breach or full outage

severity: high

Significant risk, must fix before go-live

severity: medium

Important but not blocking go-live

testing

Test coverage, integration tests

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

sharang Benjamin_Boenisch

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Benjamin_Boenisch/breakpilot-compliance#2