Benjamin_Boenisch/breakpilot-compliance
1
0
Fork 0
Code Issues 24 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(iace): rename 58 duplicate HP-IDs in extended.go/extended2.go

Browse Source 
Background: hazard_patterns_extended.go (HP045-074) and _extended2.go
(HP074-102) shared their entire ID range with the semantically-different
patterns in hazard_patterns_cobot.go, hazard_patterns_press.go,
hazard_patterns_operational.go and hazard_patterns_extended_dguv.go.
The collision had lived unnoticed because TestGetBuiltinHazardPatterns_-
UniqueIDs only checks the 44 builtin patterns (HP001-HP044).

Examples of the collision:
- HP059 = "Kollision Mensch-Roboter" (cobot.go) vs "Kupplung — mechanisch" (extended.go)
- HP060 = "Quetschen durch Werkzeug am Cobot" (cobot.go) vs "Diagnosemodul — Software" (extended.go)
- HP073 = "Wartung ohne LOTO" (operational.go) vs "Hydraulikventil — hydraulisch" (extended.go)

At runtime collectAllPatterns() returned both patterns under the same ID
which made downstream lookups (e.g. hazardPatternMeasures map keyed by
pattern_id) non-deterministic — last-loaded wins, dropping the other
pattern's mitigation set silently.

Rename strategy (no deletes — both patterns are real and earn their
SuggestedMeasureIDs after the category-filter work):
  extended.go  HP045..HP073 -> HP1800..HP1828 (29 IDs)
  extended2.go HP074..HP102 -> HP1830..HP1858 (29 IDs)

cobot/press/operational/extended_dguv keep their original IDs because:
- compliance_triggers.go references HP059/HP060 with the cobot meaning
- pattern_engine_test.go references HP073 with the LOTO/maintenance meaning
- phase3_4_test.go references HP073 the same way

New regression test:
- TestAllPatterns_UniqueIDs runs over collectAllPatterns() and fails if
  ANY pattern in the runtime set duplicates an ID. The old
  TestGetBuiltinHazardPatterns_UniqueIDs stays for the builtin subset.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Benjamin Admin
2026-05-16 22:00:06 +02:00
parent 6a3e96d54c
commit 80d62a0c5f
3 changed files with 92 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ai-compliance-sdk/internal/iace/hazard_patterns_extended.go
+29 -29
View File
@@ -12,7 +12,7 @@ func GetExtendedHazardPatterns() []HazardPattern {
func getExtendedHazardPatternsA() []HazardPattern { func getExtendedHazardPatternsA() []HazardPattern {
return []HazardPattern{ return []HazardPattern{
{ {
ID: "HP045", NameDE: "Aktor — elektrisch", NameEN: "Actuator — electrical", ID: "HP1800", NameDE: "Aktor — elektrisch", NameEN: "Actuator — electrical",
RequiredComponentTags: []string{"actuator_part"}, RequiredComponentTags: []string{"actuator_part"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"maintenance"}, RequiredLifecycles: []string{"maintenance"},
@@ -23,7 +23,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R341 // Source: R341
}, },
{ {
ID: "HP046", NameDE: "Aktor — mechanisch", NameEN: "Actuator — mechanical", ID: "HP1801", NameDE: "Aktor — mechanisch", NameEN: "Actuator — mechanical",
RequiredComponentTags: []string{"actuator_part"}, RequiredComponentTags: []string{"actuator_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -34,7 +34,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R340 // Source: R340
}, },
{ {
ID: "HP047", NameDE: "KI-Steuerung — Software", NameEN: "Ai Controller — software", ID: "HP1802", NameDE: "KI-Steuerung — Software", NameEN: "Ai Controller — software",
RequiredComponentTags: []string{"has_ai", "has_software", "programmable"}, RequiredComponentTags: []string{"has_ai", "has_software", "programmable"},
RequiredEnergyTags: []string{}, RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -45,7 +45,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R590, R1090 // Source: R590, R1090
}, },
{ {
ID: "HP048", NameDE: "Kabelbaum — elektrisch", NameEN: "Cable Harness — electrical", ID: "HP1803", NameDE: "Kabelbaum — elektrisch", NameEN: "Cable Harness — electrical",
RequiredComponentTags: []string{"electrical_part"}, RequiredComponentTags: []string{"electrical_part"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"installation", "operation"}, RequiredLifecycles: []string{"installation", "operation"},
@@ -56,7 +56,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R065, R570, R1070 // Source: R065, R570, R1070
}, },
{ {
ID: "HP049", NameDE: "Kabelsystem — elektrisch", NameEN: "Cable System — electrical", ID: "HP1804", NameDE: "Kabelsystem — elektrisch", NameEN: "Cable System — electrical",
RequiredComponentTags: []string{"electrical_part"}, RequiredComponentTags: []string{"electrical_part"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"installation", "operation"}, RequiredLifecycles: []string{"installation", "operation"},
@@ -67,7 +67,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R317, R318 // Source: R317, R318
}, },
{ {
ID: "HP050", NameDE: "Kamerasystem — elektrisch", NameEN: "Camera System — electrical", ID: "HP1805", NameDE: "Kamerasystem — elektrisch", NameEN: "Camera System — electrical",
RequiredComponentTags: []string{"sensor_part"}, RequiredComponentTags: []string{"sensor_part"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -78,7 +78,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R074, R328 // Source: R074, R328
}, },
{ {
ID: "HP051", NameDE: "Druckluftleitung — pneumatisch", NameEN: "Compressed Air Line — pneumatic", ID: "HP1806", NameDE: "Druckluftleitung — pneumatisch", NameEN: "Compressed Air Line — pneumatic",
RequiredComponentTags: []string{"pneumatic_part"}, RequiredComponentTags: []string{"pneumatic_part"},
RequiredEnergyTags: []string{"pneumatic_pressure"}, RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"maintenance"}, RequiredLifecycles: []string{"maintenance"},
@@ -89,7 +89,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R070 // Source: R070
}, },
{ {
ID: "HP052", NameDE: "Kompressor — pneumatisch", NameEN: "Compressor — pneumatic", ID: "HP1807", NameDE: "Kompressor — pneumatisch", NameEN: "Compressor — pneumatic",
RequiredComponentTags: []string{"high_pressure", "noise_source", "pneumatic_part"}, RequiredComponentTags: []string{"high_pressure", "noise_source", "pneumatic_part"},
RequiredEnergyTags: []string{"pneumatic_pressure"}, RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -100,7 +100,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R578, R1078 // Source: R578, R1078
}, },
{ {
ID: "HP053", NameDE: "Schaltschrank — elektrisch", NameEN: "Control Cabinet — electrical", ID: "HP1808", NameDE: "Schaltschrank — elektrisch", NameEN: "Control Cabinet — electrical",
RequiredComponentTags: []string{"electrical_part", "high_voltage"}, RequiredComponentTags: []string{"electrical_part", "high_voltage"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"maintenance", "operation"}, RequiredLifecycles: []string{"maintenance", "operation"},
@@ -111,7 +111,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R061, R062, R315, R316, R566, R567, R1066, R1067 // Source: R061, R062, R315, R316, R566, R567, R1066, R1067
}, },
{ {
ID: "HP054", NameDE: "Steuerungsschnittstelle — Software", NameEN: "Control Interface — software", ID: "HP1809", NameDE: "Steuerungsschnittstelle — Software", NameEN: "Control Interface — software",
RequiredComponentTags: []string{"has_software", "user_interface"}, RequiredComponentTags: []string{"has_software", "user_interface"},
RequiredEnergyTags: []string{}, RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -122,7 +122,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R080, R334 // Source: R080, R334
}, },
{ {
ID: "HP055", NameDE: "Steuerung — elektrisch", NameEN: "Controller — electrical", ID: "HP1810", NameDE: "Steuerung — elektrisch", NameEN: "Controller — electrical",
RequiredComponentTags: []string{"has_software", "programmable"}, RequiredComponentTags: []string{"has_software", "programmable"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"restart"}, RequiredLifecycles: []string{"restart"},
@@ -133,7 +133,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R339, R598, R1098 // Source: R339, R598, R1098
}, },
{ {
ID: "HP056", NameDE: "Foerderband — mechanisch", NameEN: "Conveyor Belt — mechanical", ID: "HP1811", NameDE: "Foerderband — mechanisch", NameEN: "Conveyor Belt — mechanical",
RequiredComponentTags: []string{"entanglement_risk", "moving_part", "rotating_part"}, RequiredComponentTags: []string{"entanglement_risk", "moving_part", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "cleaning", "operation"}, RequiredLifecycles: []string{"automatic_operation", "cleaning", "operation"},
@@ -144,7 +144,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R053, R054, R556, R557, R1056, R1057 // Source: R053, R054, R556, R557, R1056, R1057
}, },
{ {
ID: "HP057", NameDE: "Foerdersystem — mechanisch", NameEN: "Conveyor System — mechanical", ID: "HP1812", NameDE: "Foerdersystem — mechanisch", NameEN: "Conveyor System — mechanical",
RequiredComponentTags: []string{"entanglement_risk", "moving_part", "rotating_part"}, RequiredComponentTags: []string{"entanglement_risk", "moving_part", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"cleaning", "operation"}, RequiredLifecycles: []string{"cleaning", "operation"},
@@ -155,7 +155,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R305, R306 // Source: R305, R306
}, },
{ {
ID: "HP058", NameDE: "Kuehlgeraet — thermisch", NameEN: "Cooling Unit — thermal", ID: "HP1813", NameDE: "Kuehlgeraet — thermisch", NameEN: "Cooling Unit — thermal",
RequiredComponentTags: []string{"high_temperature"}, RequiredComponentTags: []string{"high_temperature"},
RequiredEnergyTags: []string{"thermal"}, RequiredEnergyTags: []string{"thermal"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -166,7 +166,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R581, R1081 // Source: R581, R1081
}, },
{ {
ID: "HP059", NameDE: "Kupplung — mechanisch", NameEN: "Coupling — mechanical", ID: "HP1814", NameDE: "Kupplung — mechanisch", NameEN: "Coupling — mechanical",
RequiredComponentTags: []string{"rotating_part"}, RequiredComponentTags: []string{"rotating_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -177,7 +177,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R056, R564, R1064 // Source: R056, R564, R1064
}, },
{ {
ID: "HP060", NameDE: "Diagnosemodul — Software", NameEN: "Diagnostic Module — software", ID: "HP1815", NameDE: "Diagnosemodul — Software", NameEN: "Diagnostic Module — software",
RequiredComponentTags: []string{"has_software", "safety_device"}, RequiredComponentTags: []string{"has_software", "safety_device"},
RequiredEnergyTags: []string{}, RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -188,7 +188,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R596, R1096 // Source: R596, R1096
}, },
{ {
ID: "HP061", NameDE: "Firewall — Software", NameEN: "Firewall — software", ID: "HP1816", NameDE: "Firewall — Software", NameEN: "Firewall — software",
RequiredComponentTags: []string{"networked", "security_device"}, RequiredComponentTags: []string{"networked", "security_device"},
RequiredEnergyTags: []string{}, RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -199,7 +199,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R587, R1087 // Source: R587, R1087
}, },
{ {
ID: "HP062", NameDE: "Firmware — Software", NameEN: "Firmware — software", ID: "HP1817", NameDE: "Firmware — Software", NameEN: "Firmware — software",
RequiredComponentTags: []string{"has_software", "programmable"}, RequiredComponentTags: []string{"has_software", "programmable"},
RequiredEnergyTags: []string{}, RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"software_update"}, RequiredLifecycles: []string{"software_update"},
@@ -210,7 +210,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R338, R597, R1097 // Source: R338, R597, R1097
}, },
{ {
ID: "HP063", NameDE: "Ofen — thermisch", NameEN: "Furnace — thermal", ID: "HP1818", NameDE: "Ofen — thermisch", NameEN: "Furnace — thermal",
RequiredComponentTags: []string{"high_temperature"}, RequiredComponentTags: []string{"high_temperature"},
RequiredEnergyTags: []string{"thermal"}, RequiredEnergyTags: []string{"thermal"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -221,7 +221,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R326, R580, R1080 // Source: R326, R580, R1080
}, },
{ {
ID: "HP064", NameDE: "Ofenkammer — thermisch", NameEN: "Furnace Chamber — thermal", ID: "HP1819", NameDE: "Ofenkammer — thermisch", NameEN: "Furnace Chamber — thermal",
RequiredComponentTags: []string{"high_temperature"}, RequiredComponentTags: []string{"high_temperature"},
RequiredEnergyTags: []string{"thermal"}, RequiredEnergyTags: []string{"thermal"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -232,7 +232,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R072 // Source: R072
}, },
{ {
ID: "HP065", NameDE: "Getriebe — mechanisch", NameEN: "Gearbox — mechanical", ID: "HP1820", NameDE: "Getriebe — mechanisch", NameEN: "Gearbox — mechanical",
RequiredComponentTags: []string{"pinch_point", "rotating_part"}, RequiredComponentTags: []string{"pinch_point", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -243,7 +243,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R055, R563, R1063 // Source: R055, R563, R1063
}, },
{ {
ID: "HP066", NameDE: "Heizelement — thermisch", NameEN: "Heating Element — thermal", ID: "HP1821", NameDE: "Heizelement — thermisch", NameEN: "Heating Element — thermal",
RequiredComponentTags: []string{"high_temperature"}, RequiredComponentTags: []string{"high_temperature"},
RequiredEnergyTags: []string{"thermal"}, RequiredEnergyTags: []string{"thermal"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -254,7 +254,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R071, R325, R579, R1079 // Source: R071, R325, R579, R1079
}, },
{ {
ID: "HP067", NameDE: "HMI-Bedienterminal — elektrisch", NameEN: "Hmi — electrical", ID: "HP1822", NameDE: "HMI-Bedienterminal — elektrisch", NameEN: "Hmi — electrical",
RequiredComponentTags: []string{"has_software", "user_interface"}, RequiredComponentTags: []string{"has_software", "user_interface"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -265,7 +265,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R333 // Source: R333
}, },
{ {
ID: "HP068", NameDE: "HMI-Panel — elektrisch", NameEN: "Hmi Panel — electrical", ID: "HP1823", NameDE: "HMI-Panel — elektrisch", NameEN: "Hmi Panel — electrical",
RequiredComponentTags: []string{"has_software", "user_interface"}, RequiredComponentTags: []string{"has_software", "user_interface"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -276,7 +276,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R079, R591, R1091 // Source: R079, R591, R1091
}, },
{ {
ID: "HP069", NameDE: "Hydraulikzylinder — hydraulisch", NameEN: "Hydraulic Cylinder — hydraulic", ID: "HP1824", NameDE: "Hydraulikzylinder — hydraulisch", NameEN: "Hydraulic Cylinder — hydraulic",
RequiredComponentTags: []string{"high_force", "high_pressure", "hydraulic_part", "moving_part"}, RequiredComponentTags: []string{"high_force", "high_pressure", "hydraulic_part", "moving_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"}, RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"maintenance", "operation"}, RequiredLifecycles: []string{"maintenance", "operation"},
@@ -287,7 +287,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R066, R319, R320, R572, R1072 // Source: R066, R319, R320, R572, R1072
}, },
{ {
ID: "HP070", NameDE: "Hydraulikschlauch — hydraulisch", NameEN: "Hydraulic Hose — hydraulic", ID: "HP1825", NameDE: "Hydraulikschlauch — hydraulisch", NameEN: "Hydraulic Hose — hydraulic",
RequiredComponentTags: []string{"high_pressure", "hydraulic_part"}, RequiredComponentTags: []string{"high_pressure", "hydraulic_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"}, RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -298,7 +298,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R067, R321, R573, R1073 // Source: R067, R321, R573, R1073
}, },
{ {
ID: "HP071", NameDE: "Hydraulikpumpe — hydraulisch", NameEN: "Hydraulic Pump — hydraulic", ID: "HP1826", NameDE: "Hydraulikpumpe — hydraulisch", NameEN: "Hydraulic Pump — hydraulic",
RequiredComponentTags: []string{"high_pressure", "hydraulic_part"}, RequiredComponentTags: []string{"high_pressure", "hydraulic_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"}, RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -309,7 +309,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R068, R322, R571, R1071 // Source: R068, R322, R571, R1071
}, },
{ {
ID: "HP072", NameDE: "Hydrauliksystem — hydraulisch", NameEN: "Hydraulic System — hydraulic", ID: "HP1827", NameDE: "Hydrauliksystem — hydraulisch", NameEN: "Hydraulic System — hydraulic",
RequiredComponentTags: []string{"high_pressure", "hydraulic_part"}, RequiredComponentTags: []string{"high_pressure", "hydraulic_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"}, RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"maintenance"}, RequiredLifecycles: []string{"maintenance"},
@@ -320,7 +320,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R575, R1075 // Source: R575, R1075
}, },
{ {
ID: "HP073", NameDE: "Hydraulikventil — hydraulisch", NameEN: "Hydraulic Valve — hydraulic", ID: "HP1828", NameDE: "Hydraulikventil — hydraulisch", NameEN: "Hydraulic Valve — hydraulic",
RequiredComponentTags: []string{"high_pressure", "hydraulic_part"}, RequiredComponentTags: []string{"high_pressure", "hydraulic_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"}, RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
ai-compliance-sdk/internal/iace/hazard_patterns_extended2.go
+29 -29
View File
@@ -5,7 +5,7 @@ package iace
func getExtendedHazardPatternsB() []HazardPattern { func getExtendedHazardPatternsB() []HazardPattern {
return []HazardPattern{ return []HazardPattern{
{ {
ID: "HP074", NameDE: "Industrie-Switch — elektrisch", NameEN: "Industrial Switch — electrical", ID: "HP1830", NameDE: "Industrie-Switch — elektrisch", NameEN: "Industrial Switch — electrical",
RequiredComponentTags: []string{"networked", "security_device"}, RequiredComponentTags: []string{"networked", "security_device"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -16,7 +16,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R075, R329, R585, R1085 // Source: R075, R329, R585, R1085
}, },
{ {
ID: "HP075", NameDE: "Laserscanner — elektrisch", NameEN: "Laser Scanner — electrical", ID: "HP1831", NameDE: "Laserscanner — elektrisch", NameEN: "Laser Scanner — electrical",
RequiredComponentTags: []string{"sensor_part"}, RequiredComponentTags: []string{"sensor_part"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -27,7 +27,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R583, R1083 // Source: R583, R1083
}, },
{ {
ID: "HP076", NameDE: "Hubwerk — mechanisch", NameEN: "Lifting Device — mechanical", ID: "HP1832", NameDE: "Hubwerk — mechanisch", NameEN: "Lifting Device — mechanical",
RequiredComponentTags: []string{"gravity_risk", "high_force", "moving_part"}, RequiredComponentTags: []string{"gravity_risk", "high_force", "moving_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation", "transport"}, RequiredLifecycles: []string{"operation", "transport"},
@@ -38,7 +38,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R307, R308 // Source: R307, R308
}, },
{ {
ID: "HP077", NameDE: "Hubtisch — hydraulisch", NameEN: "Lifting Table — hydraulic", ID: "HP1833", NameDE: "Hubtisch — hydraulisch", NameEN: "Lifting Table — hydraulic",
RequiredComponentTags: []string{"gravity_risk", "moving_part"}, RequiredComponentTags: []string{"gravity_risk", "moving_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"}, RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -49,7 +49,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R560, R1060 // Source: R560, R1060
}, },
{ {
ID: "HP078", NameDE: "Linearachse — mechanisch", NameEN: "Linear Axis — mechanical", ID: "HP1834", NameDE: "Linearachse — mechanisch", NameEN: "Linear Axis — mechanical",
RequiredComponentTags: []string{"crush_point", "moving_part"}, RequiredComponentTags: []string{"crush_point", "moving_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "maintenance", "setup"}, RequiredLifecycles: []string{"automatic_operation", "maintenance", "setup"},
@@ -60,7 +60,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R051, R052, R301, R302 // Source: R051, R052, R301, R302
}, },
{ {
ID: "HP079", NameDE: "Maschinenrahmen — mechanisch", NameEN: "Machine Frame — mechanical", ID: "HP1835", NameDE: "Maschinenrahmen — mechanisch", NameEN: "Machine Frame — mechanical",
RequiredComponentTags: []string{"structural_part"}, RequiredComponentTags: []string{"structural_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -71,7 +71,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R335, R593, R1093 // Source: R335, R593, R1093
}, },
{ {
ID: "HP080", NameDE: "ML-Modell — Software", NameEN: "Ml Model — software", ID: "HP1836", NameDE: "ML-Modell — Software", NameEN: "Ml Model — software",
RequiredComponentTags: []string{"has_ai", "has_software"}, RequiredComponentTags: []string{"has_ai", "has_software"},
RequiredEnergyTags: []string{}, RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -82,7 +82,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R078, R332, R589, R1089 // Source: R078, R332, R589, R1089
}, },
{ {
ID: "HP081", NameDE: "Ueberwachungssystem — elektrisch", NameEN: "Monitoring System — electrical", ID: "HP1837", NameDE: "Ueberwachungssystem — elektrisch", NameEN: "Monitoring System — electrical",
RequiredComponentTags: []string{"has_software", "safety_device"}, RequiredComponentTags: []string{"has_software", "safety_device"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -93,7 +93,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R337, R595, R1095 // Source: R337, R595, R1095
}, },
{ {
ID: "HP082", NameDE: "Palettierer — mechanisch", NameEN: "Palletizer — mechanical", ID: "HP1838", NameDE: "Palettierer — mechanisch", NameEN: "Palletizer — mechanical",
RequiredComponentTags: []string{"high_force", "moving_part"}, RequiredComponentTags: []string{"high_force", "moving_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation"}, RequiredLifecycles: []string{"automatic_operation"},
@@ -104,7 +104,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R559, R1059 // Source: R559, R1059
}, },
{ {
ID: "HP083", NameDE: "Plattform — mechanisch", NameEN: "Platform — mechanical", ID: "HP1839", NameDE: "Plattform — mechanisch", NameEN: "Platform — mechanical",
RequiredComponentTags: []string{"gravity_risk", "structural_part"}, RequiredComponentTags: []string{"gravity_risk", "structural_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -115,7 +115,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R336, R594, R1094 // Source: R336, R594, R1094
}, },
{ {
ID: "HP084", NameDE: "Pneumatikzylinder — pneumatisch", NameEN: "Pneumatic Cylinder — pneumatic", ID: "HP1840", NameDE: "Pneumatikzylinder — pneumatisch", NameEN: "Pneumatic Cylinder — pneumatic",
RequiredComponentTags: []string{"moving_part", "pneumatic_part", "stored_energy"}, RequiredComponentTags: []string{"moving_part", "pneumatic_part", "stored_energy"},
RequiredEnergyTags: []string{"pneumatic_pressure"}, RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -126,7 +126,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R069, R323, R576, R1076 // Source: R069, R323, R576, R1076
}, },
{ {
ID: "HP085", NameDE: "Pneumatikleitung — pneumatisch", NameEN: "Pneumatic Line — pneumatic", ID: "HP1841", NameDE: "Pneumatikleitung — pneumatisch", NameEN: "Pneumatic Line — pneumatic",
RequiredComponentTags: []string{"pneumatic_part"}, RequiredComponentTags: []string{"pneumatic_part"},
RequiredEnergyTags: []string{"pneumatic_pressure"}, RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"maintenance"}, RequiredLifecycles: []string{"maintenance"},
@@ -137,7 +137,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R324, R577, R1077 // Source: R324, R577, R1077
}, },
{ {
ID: "HP086", NameDE: "Stromversorgung — elektrisch", NameEN: "Power Supply — electrical", ID: "HP1842", NameDE: "Stromversorgung — elektrisch", NameEN: "Power Supply — electrical",
RequiredComponentTags: []string{"electrical_part", "high_voltage"}, RequiredComponentTags: []string{"electrical_part", "high_voltage"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"maintenance", "operation"}, RequiredLifecycles: []string{"maintenance", "operation"},
@@ -148,7 +148,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R063, R311, R312, R568, R1068 // Source: R063, R311, R312, R568, R1068
}, },
{ {
ID: "HP087", NameDE: "Naeherungssensor — elektrisch", NameEN: "Proximity Sensor — electrical", ID: "HP1843", NameDE: "Naeherungssensor — elektrisch", NameEN: "Proximity Sensor — electrical",
RequiredComponentTags: []string{"sensor_part"}, RequiredComponentTags: []string{"sensor_part"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -159,7 +159,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R073, R327, R582, R1082 // Source: R073, R327, R582, R1082
}, },
{ {
ID: "HP088", NameDE: "Roboterarm — mechanisch", NameEN: "Robot Arm — mechanical", ID: "HP1844", NameDE: "Roboterarm — mechanisch", NameEN: "Robot Arm — mechanical",
RequiredComponentTags: []string{"high_force", "moving_part", "rotating_part"}, RequiredComponentTags: []string{"high_force", "moving_part", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "maintenance", "teach"}, RequiredLifecycles: []string{"automatic_operation", "maintenance", "teach"},
@@ -170,7 +170,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R303, R304, R551, R552, R1051, R1052 // Source: R303, R304, R551, R552, R1051, R1052
}, },
{ {
ID: "HP089", NameDE: "Robotersteuerung — elektrisch", NameEN: "Robot Controller — electrical", ID: "HP1845", NameDE: "Robotersteuerung — elektrisch", NameEN: "Robot Controller — electrical",
RequiredComponentTags: []string{"has_software", "programmable"}, RequiredComponentTags: []string{"has_software", "programmable"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -181,7 +181,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R553, R1053 // Source: R553, R1053
}, },
{ {
ID: "HP090", NameDE: "Greifer — mechanisch", NameEN: "Robot Gripper — mechanical", ID: "HP1846", NameDE: "Greifer — mechanisch", NameEN: "Robot Gripper — mechanical",
RequiredComponentTags: []string{"clamping_part", "moving_part", "pinch_point"}, RequiredComponentTags: []string{"clamping_part", "moving_part", "pinch_point"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "operation", "setup"}, RequiredLifecycles: []string{"automatic_operation", "operation", "setup"},
@@ -192,7 +192,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R057, R058, R554 // Source: R057, R058, R554
}, },
{ {
ID: "HP091", NameDE: "Greifer — pneumatisch", NameEN: "Robot Gripper — pneumatic", ID: "HP1847", NameDE: "Greifer — pneumatisch", NameEN: "Robot Gripper — pneumatic",
RequiredComponentTags: []string{"clamping_part", "moving_part", "pinch_point"}, RequiredComponentTags: []string{"clamping_part", "moving_part", "pinch_point"},
RequiredEnergyTags: []string{"pneumatic_pressure"}, RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"maintenance", "operation"}, RequiredLifecycles: []string{"maintenance", "operation"},
@@ -203,7 +203,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R555, R1054, R1055 // Source: R555, R1054, R1055
}, },
{ {
ID: "HP092", NameDE: "Rollenfoerderer — mechanisch", NameEN: "Roller Conveyor — mechanical", ID: "HP1848", NameDE: "Rollenfoerderer — mechanisch", NameEN: "Roller Conveyor — mechanical",
RequiredComponentTags: []string{"entanglement_risk", "moving_part", "rotating_part"}, RequiredComponentTags: []string{"entanglement_risk", "moving_part", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -214,7 +214,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R558, R1058 // Source: R558, R1058
}, },
{ {
ID: "HP093", NameDE: "Drehtisch — mechanisch", NameEN: "Rotary Table — mechanical", ID: "HP1849", NameDE: "Drehtisch — mechanisch", NameEN: "Rotary Table — mechanical",
RequiredComponentTags: []string{"high_force", "rotating_part"}, RequiredComponentTags: []string{"high_force", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "maintenance"}, RequiredLifecycles: []string{"automatic_operation", "maintenance"},
@@ -225,7 +225,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R309, R310 // Source: R309, R310
}, },
{ {
ID: "HP094", NameDE: "Drehscheibe — mechanisch", NameEN: "Rotating Disc — mechanical", ID: "HP1850", NameDE: "Drehscheibe — mechanisch", NameEN: "Rotating Disc — mechanical",
RequiredComponentTags: []string{"high_speed", "rotating_part"}, RequiredComponentTags: []string{"high_speed", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -236,7 +236,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R565, R1065 // Source: R565, R1065
}, },
{ {
ID: "HP095", NameDE: "Spindel — mechanisch", NameEN: "Rotating Spindle — mechanical", ID: "HP1851", NameDE: "Spindel — mechanisch", NameEN: "Rotating Spindle — mechanical",
RequiredComponentTags: []string{"cutting_part", "high_speed", "rotating_part"}, RequiredComponentTags: []string{"cutting_part", "high_speed", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"maintenance", "operation"}, RequiredLifecycles: []string{"maintenance", "operation"},
@@ -247,7 +247,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R561, R562, R1061, R1062 // Source: R561, R562, R1061, R1062
}, },
{ {
ID: "HP096", NameDE: "Router — elektrisch", NameEN: "Router — electrical", ID: "HP1852", NameDE: "Router — elektrisch", NameEN: "Router — electrical",
RequiredComponentTags: []string{"networked", "security_device"}, RequiredComponentTags: []string{"networked", "security_device"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -258,7 +258,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R076, R330, R586, R1086 // Source: R076, R330, R586, R1086
}, },
{ {
ID: "HP097", NameDE: "Gesamtsystem — gemischt", NameEN: "System — mixed", ID: "HP1853", NameDE: "Gesamtsystem — gemischt", NameEN: "System — mixed",
RequiredComponentTags: []string{"has_software"}, RequiredComponentTags: []string{"has_software"},
RequiredEnergyTags: []string{}, RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation", "safety_validation"}, RequiredLifecycles: []string{"operation", "safety_validation"},
@@ -269,7 +269,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R599, R600, R1099, R1100 // Source: R599, R600, R1099, R1100
}, },
{ {
ID: "HP098", NameDE: "Werkzeugwechsler — mechanisch", NameEN: "Tool Changer — mechanical", ID: "HP1854", NameDE: "Werkzeugwechsler — mechanisch", NameEN: "Tool Changer — mechanical",
RequiredComponentTags: []string{"moving_part", "pinch_point"}, RequiredComponentTags: []string{"moving_part", "pinch_point"},
RequiredEnergyTags: []string{"kinetic"}, RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"maintenance", "operation"}, RequiredLifecycles: []string{"maintenance", "operation"},
@@ -280,7 +280,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R059, R060 // Source: R059, R060
}, },
{ {
ID: "HP099", NameDE: "Touch-Bedienfeld — Software", NameEN: "Touch Interface — software", ID: "HP1855", NameDE: "Touch-Bedienfeld — Software", NameEN: "Touch Interface — software",
RequiredComponentTags: []string{"has_software", "user_interface"}, RequiredComponentTags: []string{"has_software", "user_interface"},
RequiredEnergyTags: []string{}, RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -291,7 +291,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R592, R1092 // Source: R592, R1092
}, },
{ {
ID: "HP100", NameDE: "Transformator — elektrisch", NameEN: "Transformer — electrical", ID: "HP1856", NameDE: "Transformator — elektrisch", NameEN: "Transformer — electrical",
RequiredComponentTags: []string{"electrical_part", "high_voltage"}, RequiredComponentTags: []string{"electrical_part", "high_voltage"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"inspection", "operation"}, RequiredLifecycles: []string{"inspection", "operation"},
@@ -302,7 +302,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R064, R313, R314, R569, R1069 // Source: R064, R313, R314, R569, R1069
}, },
{ {
ID: "HP101", NameDE: "KI-Bilderkennung — Software", NameEN: "Vision Ai — software", ID: "HP1857", NameDE: "KI-Bilderkennung — Software", NameEN: "Vision Ai — software",
RequiredComponentTags: []string{"has_ai", "sensor_part"}, RequiredComponentTags: []string{"has_ai", "sensor_part"},
RequiredEnergyTags: []string{}, RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
@@ -313,7 +313,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R077, R331, R588, R1088 // Source: R077, R331, R588, R1088
}, },
{ {
ID: "HP102", NameDE: "Vision-Kamera — elektrisch", NameEN: "Vision Camera — electrical", ID: "HP1858", NameDE: "Vision-Kamera — elektrisch", NameEN: "Vision Camera — electrical",
RequiredComponentTags: []string{"sensor_part"}, RequiredComponentTags: []string{"sensor_part"},
RequiredEnergyTags: []string{"electrical_energy"}, RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"}, RequiredLifecycles: []string{"operation"},
ai-compliance-sdk/internal/iace/pattern_coverage_test.go
+34
View File
@@ -113,6 +113,40 @@ func TestEveryPattern_HasCategoryCompatibleMeasure(t *testing.T) {
} }
} }
// TestAllPatterns_UniqueIDs pins that collectAllPatterns() — i.e. every
// pattern that the engine actually sees at runtime — has globally unique
// HP-IDs. The older TestGetBuiltinHazardPatterns_UniqueIDs only checks the
// 44 builtin ones and missed 58 duplicates between extended.go/extended2.go
// and cobot/press/operational/extended_dguv.go that lived undetected for
// months (a hazard with the same HP-ID but different scenario would silently
// shadow its sibling in the persistence layer).
func TestAllPatterns_UniqueIDs(t *testing.T) {
seen := map[string]string{} // HP-ID -> first NameDE
dups := []string{}
for _, p := range collectAllPatterns() {
if p.ID == "" {
t.Errorf("pattern with empty ID: %s", p.NameDE)
continue
}
if prev, ok := seen[p.ID]; ok {
dups = append(dups, p.ID+" ("+prev+" vs "+p.NameDE+")")
continue
}
seen[p.ID] = p.NameDE
}
if len(dups) > 0 {
t.Errorf("%d duplicate HP-IDs across all pattern sources:", len(dups))
const maxList = 20
for i, d := range dups {
if i >= maxList {
t.Errorf(" ... and %d more", len(dups)-maxList)
break
}
t.Errorf(" - %s", d)
}
}
}
func joinCats(cats []string) string { func joinCats(cats []string) string {
out := "" out := ""
for i, c := range cats { for i, c := range cats {