Benjamin_Boenisch/breakpilot-compliance
1
0
Fork 0
Code Issues 24 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(iace): rename 58 duplicate HP-IDs in extended.go/extended2.go

Browse Source 
Background: hazard_patterns_extended.go (HP045-074) and _extended2.go
(HP074-102) shared their entire ID range with the semantically-different
patterns in hazard_patterns_cobot.go, hazard_patterns_press.go,
hazard_patterns_operational.go and hazard_patterns_extended_dguv.go.
The collision had lived unnoticed because TestGetBuiltinHazardPatterns_-
UniqueIDs only checks the 44 builtin patterns (HP001-HP044).

Examples of the collision:
- HP059 = "Kollision Mensch-Roboter" (cobot.go) vs "Kupplung — mechanisch" (extended.go)
- HP060 = "Quetschen durch Werkzeug am Cobot" (cobot.go) vs "Diagnosemodul — Software" (extended.go)
- HP073 = "Wartung ohne LOTO" (operational.go) vs "Hydraulikventil — hydraulisch" (extended.go)

At runtime collectAllPatterns() returned both patterns under the same ID
which made downstream lookups (e.g. hazardPatternMeasures map keyed by
pattern_id) non-deterministic — last-loaded wins, dropping the other
pattern's mitigation set silently.

Rename strategy (no deletes — both patterns are real and earn their
SuggestedMeasureIDs after the category-filter work):
  extended.go  HP045..HP073 -> HP1800..HP1828 (29 IDs)
  extended2.go HP074..HP102 -> HP1830..HP1858 (29 IDs)

cobot/press/operational/extended_dguv keep their original IDs because:
- compliance_triggers.go references HP059/HP060 with the cobot meaning
- pattern_engine_test.go references HP073 with the LOTO/maintenance meaning
- phase3_4_test.go references HP073 the same way

New regression test:
- TestAllPatterns_UniqueIDs runs over collectAllPatterns() and fails if
  ANY pattern in the runtime set duplicates an ID. The old
  TestGetBuiltinHazardPatterns_UniqueIDs stays for the builtin subset.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Benjamin Admin
2026-05-16 22:00:06 +02:00
parent 6a3e96d54c
commit 80d62a0c5f
3 changed files with 92 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ai-compliance-sdk/internal/iace/hazard_patterns_extended2.go
+29 -29
View File
@@ -5,7 +5,7 @@ package iace
func getExtendedHazardPatternsB() []HazardPattern {
return []HazardPattern{
{
ID: "HP074", NameDE: "Industrie-Switch — elektrisch", NameEN: "Industrial Switch — electrical",
ID: "HP1830", NameDE: "Industrie-Switch — elektrisch", NameEN: "Industrial Switch — electrical",
RequiredComponentTags: []string{"networked", "security_device"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
@@ -16,7 +16,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R075, R329, R585, R1085
},
{
ID: "HP075", NameDE: "Laserscanner — elektrisch", NameEN: "Laser Scanner — electrical",
ID: "HP1831", NameDE: "Laserscanner — elektrisch", NameEN: "Laser Scanner — electrical",
RequiredComponentTags: []string{"sensor_part"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
@@ -27,7 +27,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R583, R1083
},
{
ID: "HP076", NameDE: "Hubwerk — mechanisch", NameEN: "Lifting Device — mechanical",
ID: "HP1832", NameDE: "Hubwerk — mechanisch", NameEN: "Lifting Device — mechanical",
RequiredComponentTags: []string{"gravity_risk", "high_force", "moving_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation", "transport"},
@@ -38,7 +38,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R307, R308
},
{
ID: "HP077", NameDE: "Hubtisch — hydraulisch", NameEN: "Lifting Table — hydraulic",
ID: "HP1833", NameDE: "Hubtisch — hydraulisch", NameEN: "Lifting Table — hydraulic",
RequiredComponentTags: []string{"gravity_risk", "moving_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"operation"},
@@ -49,7 +49,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R560, R1060
},
{
ID: "HP078", NameDE: "Linearachse — mechanisch", NameEN: "Linear Axis — mechanical",
ID: "HP1834", NameDE: "Linearachse — mechanisch", NameEN: "Linear Axis — mechanical",
RequiredComponentTags: []string{"crush_point", "moving_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "maintenance", "setup"},
@@ -60,7 +60,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R051, R052, R301, R302
},
{
ID: "HP079", NameDE: "Maschinenrahmen — mechanisch", NameEN: "Machine Frame — mechanical",
ID: "HP1835", NameDE: "Maschinenrahmen — mechanisch", NameEN: "Machine Frame — mechanical",
RequiredComponentTags: []string{"structural_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
@@ -71,7 +71,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R335, R593, R1093
},
{
ID: "HP080", NameDE: "ML-Modell — Software", NameEN: "Ml Model — software",
ID: "HP1836", NameDE: "ML-Modell — Software", NameEN: "Ml Model — software",
RequiredComponentTags: []string{"has_ai", "has_software"},
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"},
@@ -82,7 +82,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R078, R332, R589, R1089
},
{
ID: "HP081", NameDE: "Ueberwachungssystem — elektrisch", NameEN: "Monitoring System — electrical",
ID: "HP1837", NameDE: "Ueberwachungssystem — elektrisch", NameEN: "Monitoring System — electrical",
RequiredComponentTags: []string{"has_software", "safety_device"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
@@ -93,7 +93,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R337, R595, R1095
},
{
ID: "HP082", NameDE: "Palettierer — mechanisch", NameEN: "Palletizer — mechanical",
ID: "HP1838", NameDE: "Palettierer — mechanisch", NameEN: "Palletizer — mechanical",
RequiredComponentTags: []string{"high_force", "moving_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation"},
@@ -104,7 +104,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R559, R1059
},
{
ID: "HP083", NameDE: "Plattform — mechanisch", NameEN: "Platform — mechanical",
ID: "HP1839", NameDE: "Plattform — mechanisch", NameEN: "Platform — mechanical",
RequiredComponentTags: []string{"gravity_risk", "structural_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
@@ -115,7 +115,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R336, R594, R1094
},
{
ID: "HP084", NameDE: "Pneumatikzylinder — pneumatisch", NameEN: "Pneumatic Cylinder — pneumatic",
ID: "HP1840", NameDE: "Pneumatikzylinder — pneumatisch", NameEN: "Pneumatic Cylinder — pneumatic",
RequiredComponentTags: []string{"moving_part", "pneumatic_part", "stored_energy"},
RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"operation"},
@@ -126,7 +126,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R069, R323, R576, R1076
},
{
ID: "HP085", NameDE: "Pneumatikleitung — pneumatisch", NameEN: "Pneumatic Line — pneumatic",
ID: "HP1841", NameDE: "Pneumatikleitung — pneumatisch", NameEN: "Pneumatic Line — pneumatic",
RequiredComponentTags: []string{"pneumatic_part"},
RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"maintenance"},
@@ -137,7 +137,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R324, R577, R1077
},
{
ID: "HP086", NameDE: "Stromversorgung — elektrisch", NameEN: "Power Supply — electrical",
ID: "HP1842", NameDE: "Stromversorgung — elektrisch", NameEN: "Power Supply — electrical",
RequiredComponentTags: []string{"electrical_part", "high_voltage"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"maintenance", "operation"},
@@ -148,7 +148,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R063, R311, R312, R568, R1068
},
{
ID: "HP087", NameDE: "Naeherungssensor — elektrisch", NameEN: "Proximity Sensor — electrical",
ID: "HP1843", NameDE: "Naeherungssensor — elektrisch", NameEN: "Proximity Sensor — electrical",
RequiredComponentTags: []string{"sensor_part"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
@@ -159,7 +159,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R073, R327, R582, R1082
},
{
ID: "HP088", NameDE: "Roboterarm — mechanisch", NameEN: "Robot Arm — mechanical",
ID: "HP1844", NameDE: "Roboterarm — mechanisch", NameEN: "Robot Arm — mechanical",
RequiredComponentTags: []string{"high_force", "moving_part", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "maintenance", "teach"},
@@ -170,7 +170,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R303, R304, R551, R552, R1051, R1052
},
{
ID: "HP089", NameDE: "Robotersteuerung — elektrisch", NameEN: "Robot Controller — electrical",
ID: "HP1845", NameDE: "Robotersteuerung — elektrisch", NameEN: "Robot Controller — electrical",
RequiredComponentTags: []string{"has_software", "programmable"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
@@ -181,7 +181,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R553, R1053
},
{
ID: "HP090", NameDE: "Greifer — mechanisch", NameEN: "Robot Gripper — mechanical",
ID: "HP1846", NameDE: "Greifer — mechanisch", NameEN: "Robot Gripper — mechanical",
RequiredComponentTags: []string{"clamping_part", "moving_part", "pinch_point"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "operation", "setup"},
@@ -192,7 +192,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R057, R058, R554
},
{
ID: "HP091", NameDE: "Greifer — pneumatisch", NameEN: "Robot Gripper — pneumatic",
ID: "HP1847", NameDE: "Greifer — pneumatisch", NameEN: "Robot Gripper — pneumatic",
RequiredComponentTags: []string{"clamping_part", "moving_part", "pinch_point"},
RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"maintenance", "operation"},
@@ -203,7 +203,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R555, R1054, R1055
},
{
ID: "HP092", NameDE: "Rollenfoerderer — mechanisch", NameEN: "Roller Conveyor — mechanical",
ID: "HP1848", NameDE: "Rollenfoerderer — mechanisch", NameEN: "Roller Conveyor — mechanical",
RequiredComponentTags: []string{"entanglement_risk", "moving_part", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
@@ -214,7 +214,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R558, R1058
},
{
ID: "HP093", NameDE: "Drehtisch — mechanisch", NameEN: "Rotary Table — mechanical",
ID: "HP1849", NameDE: "Drehtisch — mechanisch", NameEN: "Rotary Table — mechanical",
RequiredComponentTags: []string{"high_force", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "maintenance"},
@@ -225,7 +225,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R309, R310
},
{
ID: "HP094", NameDE: "Drehscheibe — mechanisch", NameEN: "Rotating Disc — mechanical",
ID: "HP1850", NameDE: "Drehscheibe — mechanisch", NameEN: "Rotating Disc — mechanical",
RequiredComponentTags: []string{"high_speed", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
@@ -236,7 +236,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R565, R1065
},
{
ID: "HP095", NameDE: "Spindel — mechanisch", NameEN: "Rotating Spindle — mechanical",
ID: "HP1851", NameDE: "Spindel — mechanisch", NameEN: "Rotating Spindle — mechanical",
RequiredComponentTags: []string{"cutting_part", "high_speed", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"maintenance", "operation"},
@@ -247,7 +247,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R561, R562, R1061, R1062
},
{
ID: "HP096", NameDE: "Router — elektrisch", NameEN: "Router — electrical",
ID: "HP1852", NameDE: "Router — elektrisch", NameEN: "Router — electrical",
RequiredComponentTags: []string{"networked", "security_device"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
@@ -258,7 +258,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R076, R330, R586, R1086
},
{
ID: "HP097", NameDE: "Gesamtsystem — gemischt", NameEN: "System — mixed",
ID: "HP1853", NameDE: "Gesamtsystem — gemischt", NameEN: "System — mixed",
RequiredComponentTags: []string{"has_software"},
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation", "safety_validation"},
@@ -269,7 +269,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R599, R600, R1099, R1100
},
{
ID: "HP098", NameDE: "Werkzeugwechsler — mechanisch", NameEN: "Tool Changer — mechanical",
ID: "HP1854", NameDE: "Werkzeugwechsler — mechanisch", NameEN: "Tool Changer — mechanical",
RequiredComponentTags: []string{"moving_part", "pinch_point"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"maintenance", "operation"},
@@ -280,7 +280,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R059, R060
},
{
ID: "HP099", NameDE: "Touch-Bedienfeld — Software", NameEN: "Touch Interface — software",
ID: "HP1855", NameDE: "Touch-Bedienfeld — Software", NameEN: "Touch Interface — software",
RequiredComponentTags: []string{"has_software", "user_interface"},
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"},
@@ -291,7 +291,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R592, R1092
},
{
ID: "HP100", NameDE: "Transformator — elektrisch", NameEN: "Transformer — electrical",
ID: "HP1856", NameDE: "Transformator — elektrisch", NameEN: "Transformer — electrical",
RequiredComponentTags: []string{"electrical_part", "high_voltage"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"inspection", "operation"},
@@ -302,7 +302,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R064, R313, R314, R569, R1069
},
{
ID: "HP101", NameDE: "KI-Bilderkennung — Software", NameEN: "Vision Ai — software",
ID: "HP1857", NameDE: "KI-Bilderkennung — Software", NameEN: "Vision Ai — software",
RequiredComponentTags: []string{"has_ai", "sensor_part"},
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"},
@@ -313,7 +313,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
// Source: R077, R331, R588, R1088
},
{
ID: "HP102", NameDE: "Vision-Kamera — elektrisch", NameEN: "Vision Camera — electrical",
ID: "HP1858", NameDE: "Vision-Kamera — elektrisch", NameEN: "Vision Camera — electrical",
RequiredComponentTags: []string{"sensor_part"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},