Benjamin_Boenisch/breakpilot-compliance
1
0
Fork 0
Code Issues 24 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(iace): rename 58 duplicate HP-IDs in extended.go/extended2.go

Browse Source 
Background: hazard_patterns_extended.go (HP045-074) and _extended2.go
(HP074-102) shared their entire ID range with the semantically-different
patterns in hazard_patterns_cobot.go, hazard_patterns_press.go,
hazard_patterns_operational.go and hazard_patterns_extended_dguv.go.
The collision had lived unnoticed because TestGetBuiltinHazardPatterns_-
UniqueIDs only checks the 44 builtin patterns (HP001-HP044).

Examples of the collision:
- HP059 = "Kollision Mensch-Roboter" (cobot.go) vs "Kupplung — mechanisch" (extended.go)
- HP060 = "Quetschen durch Werkzeug am Cobot" (cobot.go) vs "Diagnosemodul — Software" (extended.go)
- HP073 = "Wartung ohne LOTO" (operational.go) vs "Hydraulikventil — hydraulisch" (extended.go)

At runtime collectAllPatterns() returned both patterns under the same ID
which made downstream lookups (e.g. hazardPatternMeasures map keyed by
pattern_id) non-deterministic — last-loaded wins, dropping the other
pattern's mitigation set silently.

Rename strategy (no deletes — both patterns are real and earn their
SuggestedMeasureIDs after the category-filter work):
  extended.go  HP045..HP073 -> HP1800..HP1828 (29 IDs)
  extended2.go HP074..HP102 -> HP1830..HP1858 (29 IDs)

cobot/press/operational/extended_dguv keep their original IDs because:
- compliance_triggers.go references HP059/HP060 with the cobot meaning
- pattern_engine_test.go references HP073 with the LOTO/maintenance meaning
- phase3_4_test.go references HP073 the same way

New regression test:
- TestAllPatterns_UniqueIDs runs over collectAllPatterns() and fails if
  ANY pattern in the runtime set duplicates an ID. The old
  TestGetBuiltinHazardPatterns_UniqueIDs stays for the builtin subset.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Benjamin Admin
2026-05-16 22:00:06 +02:00
parent 6a3e96d54c
commit 80d62a0c5f
3 changed files with 92 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ai-compliance-sdk/internal/iace/hazard_patterns_extended.go
+29 -29
View File
@@ -12,7 +12,7 @@ func GetExtendedHazardPatterns() []HazardPattern {
func getExtendedHazardPatternsA() []HazardPattern {
return []HazardPattern{
{
ID: "HP045", NameDE: "Aktor — elektrisch", NameEN: "Actuator — electrical",
ID: "HP1800", NameDE: "Aktor — elektrisch", NameEN: "Actuator — electrical",
RequiredComponentTags: []string{"actuator_part"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"maintenance"},
@@ -23,7 +23,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R341
},
{
ID: "HP046", NameDE: "Aktor — mechanisch", NameEN: "Actuator — mechanical",
ID: "HP1801", NameDE: "Aktor — mechanisch", NameEN: "Actuator — mechanical",
RequiredComponentTags: []string{"actuator_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
@@ -34,7 +34,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R340
},
{
ID: "HP047", NameDE: "KI-Steuerung — Software", NameEN: "Ai Controller — software",
ID: "HP1802", NameDE: "KI-Steuerung — Software", NameEN: "Ai Controller — software",
RequiredComponentTags: []string{"has_ai", "has_software", "programmable"},
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"},
@@ -45,7 +45,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R590, R1090
},
{
ID: "HP048", NameDE: "Kabelbaum — elektrisch", NameEN: "Cable Harness — electrical",
ID: "HP1803", NameDE: "Kabelbaum — elektrisch", NameEN: "Cable Harness — electrical",
RequiredComponentTags: []string{"electrical_part"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"installation", "operation"},
@@ -56,7 +56,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R065, R570, R1070
},
{
ID: "HP049", NameDE: "Kabelsystem — elektrisch", NameEN: "Cable System — electrical",
ID: "HP1804", NameDE: "Kabelsystem — elektrisch", NameEN: "Cable System — electrical",
RequiredComponentTags: []string{"electrical_part"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"installation", "operation"},
@@ -67,7 +67,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R317, R318
},
{
ID: "HP050", NameDE: "Kamerasystem — elektrisch", NameEN: "Camera System — electrical",
ID: "HP1805", NameDE: "Kamerasystem — elektrisch", NameEN: "Camera System — electrical",
RequiredComponentTags: []string{"sensor_part"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
@@ -78,7 +78,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R074, R328
},
{
ID: "HP051", NameDE: "Druckluftleitung — pneumatisch", NameEN: "Compressed Air Line — pneumatic",
ID: "HP1806", NameDE: "Druckluftleitung — pneumatisch", NameEN: "Compressed Air Line — pneumatic",
RequiredComponentTags: []string{"pneumatic_part"},
RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"maintenance"},
@@ -89,7 +89,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R070
},
{
ID: "HP052", NameDE: "Kompressor — pneumatisch", NameEN: "Compressor — pneumatic",
ID: "HP1807", NameDE: "Kompressor — pneumatisch", NameEN: "Compressor — pneumatic",
RequiredComponentTags: []string{"high_pressure", "noise_source", "pneumatic_part"},
RequiredEnergyTags: []string{"pneumatic_pressure"},
RequiredLifecycles: []string{"operation"},
@@ -100,7 +100,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R578, R1078
},
{
ID: "HP053", NameDE: "Schaltschrank — elektrisch", NameEN: "Control Cabinet — electrical",
ID: "HP1808", NameDE: "Schaltschrank — elektrisch", NameEN: "Control Cabinet — electrical",
RequiredComponentTags: []string{"electrical_part", "high_voltage"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"maintenance", "operation"},
@@ -111,7 +111,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R061, R062, R315, R316, R566, R567, R1066, R1067
},
{
ID: "HP054", NameDE: "Steuerungsschnittstelle — Software", NameEN: "Control Interface — software",
ID: "HP1809", NameDE: "Steuerungsschnittstelle — Software", NameEN: "Control Interface — software",
RequiredComponentTags: []string{"has_software", "user_interface"},
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"},
@@ -122,7 +122,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R080, R334
},
{
ID: "HP055", NameDE: "Steuerung — elektrisch", NameEN: "Controller — electrical",
ID: "HP1810", NameDE: "Steuerung — elektrisch", NameEN: "Controller — electrical",
RequiredComponentTags: []string{"has_software", "programmable"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"restart"},
@@ -133,7 +133,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R339, R598, R1098
},
{
ID: "HP056", NameDE: "Foerderband — mechanisch", NameEN: "Conveyor Belt — mechanical",
ID: "HP1811", NameDE: "Foerderband — mechanisch", NameEN: "Conveyor Belt — mechanical",
RequiredComponentTags: []string{"entanglement_risk", "moving_part", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"automatic_operation", "cleaning", "operation"},
@@ -144,7 +144,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R053, R054, R556, R557, R1056, R1057
},
{
ID: "HP057", NameDE: "Foerdersystem — mechanisch", NameEN: "Conveyor System — mechanical",
ID: "HP1812", NameDE: "Foerdersystem — mechanisch", NameEN: "Conveyor System — mechanical",
RequiredComponentTags: []string{"entanglement_risk", "moving_part", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"cleaning", "operation"},
@@ -155,7 +155,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R305, R306
},
{
ID: "HP058", NameDE: "Kuehlgeraet — thermisch", NameEN: "Cooling Unit — thermal",
ID: "HP1813", NameDE: "Kuehlgeraet — thermisch", NameEN: "Cooling Unit — thermal",
RequiredComponentTags: []string{"high_temperature"},
RequiredEnergyTags: []string{"thermal"},
RequiredLifecycles: []string{"operation"},
@@ -166,7 +166,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R581, R1081
},
{
ID: "HP059", NameDE: "Kupplung — mechanisch", NameEN: "Coupling — mechanical",
ID: "HP1814", NameDE: "Kupplung — mechanisch", NameEN: "Coupling — mechanical",
RequiredComponentTags: []string{"rotating_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
@@ -177,7 +177,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R056, R564, R1064
},
{
ID: "HP060", NameDE: "Diagnosemodul — Software", NameEN: "Diagnostic Module — software",
ID: "HP1815", NameDE: "Diagnosemodul — Software", NameEN: "Diagnostic Module — software",
RequiredComponentTags: []string{"has_software", "safety_device"},
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"},
@@ -188,7 +188,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R596, R1096
},
{
ID: "HP061", NameDE: "Firewall — Software", NameEN: "Firewall — software",
ID: "HP1816", NameDE: "Firewall — Software", NameEN: "Firewall — software",
RequiredComponentTags: []string{"networked", "security_device"},
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"},
@@ -199,7 +199,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R587, R1087
},
{
ID: "HP062", NameDE: "Firmware — Software", NameEN: "Firmware — software",
ID: "HP1817", NameDE: "Firmware — Software", NameEN: "Firmware — software",
RequiredComponentTags: []string{"has_software", "programmable"},
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"software_update"},
@@ -210,7 +210,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R338, R597, R1097
},
{
ID: "HP063", NameDE: "Ofen — thermisch", NameEN: "Furnace — thermal",
ID: "HP1818", NameDE: "Ofen — thermisch", NameEN: "Furnace — thermal",
RequiredComponentTags: []string{"high_temperature"},
RequiredEnergyTags: []string{"thermal"},
RequiredLifecycles: []string{"operation"},
@@ -221,7 +221,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R326, R580, R1080
},
{
ID: "HP064", NameDE: "Ofenkammer — thermisch", NameEN: "Furnace Chamber — thermal",
ID: "HP1819", NameDE: "Ofenkammer — thermisch", NameEN: "Furnace Chamber — thermal",
RequiredComponentTags: []string{"high_temperature"},
RequiredEnergyTags: []string{"thermal"},
RequiredLifecycles: []string{"operation"},
@@ -232,7 +232,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R072
},
{
ID: "HP065", NameDE: "Getriebe — mechanisch", NameEN: "Gearbox — mechanical",
ID: "HP1820", NameDE: "Getriebe — mechanisch", NameEN: "Gearbox — mechanical",
RequiredComponentTags: []string{"pinch_point", "rotating_part"},
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
@@ -243,7 +243,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R055, R563, R1063
},
{
ID: "HP066", NameDE: "Heizelement — thermisch", NameEN: "Heating Element — thermal",
ID: "HP1821", NameDE: "Heizelement — thermisch", NameEN: "Heating Element — thermal",
RequiredComponentTags: []string{"high_temperature"},
RequiredEnergyTags: []string{"thermal"},
RequiredLifecycles: []string{"operation"},
@@ -254,7 +254,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R071, R325, R579, R1079
},
{
ID: "HP067", NameDE: "HMI-Bedienterminal — elektrisch", NameEN: "Hmi — electrical",
ID: "HP1822", NameDE: "HMI-Bedienterminal — elektrisch", NameEN: "Hmi — electrical",
RequiredComponentTags: []string{"has_software", "user_interface"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
@@ -265,7 +265,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R333
},
{
ID: "HP068", NameDE: "HMI-Panel — elektrisch", NameEN: "Hmi Panel — electrical",
ID: "HP1823", NameDE: "HMI-Panel — elektrisch", NameEN: "Hmi Panel — electrical",
RequiredComponentTags: []string{"has_software", "user_interface"},
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
@@ -276,7 +276,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R079, R591, R1091
},
{
ID: "HP069", NameDE: "Hydraulikzylinder — hydraulisch", NameEN: "Hydraulic Cylinder — hydraulic",
ID: "HP1824", NameDE: "Hydraulikzylinder — hydraulisch", NameEN: "Hydraulic Cylinder — hydraulic",
RequiredComponentTags: []string{"high_force", "high_pressure", "hydraulic_part", "moving_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"maintenance", "operation"},
@@ -287,7 +287,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R066, R319, R320, R572, R1072
},
{
ID: "HP070", NameDE: "Hydraulikschlauch — hydraulisch", NameEN: "Hydraulic Hose — hydraulic",
ID: "HP1825", NameDE: "Hydraulikschlauch — hydraulisch", NameEN: "Hydraulic Hose — hydraulic",
RequiredComponentTags: []string{"high_pressure", "hydraulic_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"operation"},
@@ -298,7 +298,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R067, R321, R573, R1073
},
{
ID: "HP071", NameDE: "Hydraulikpumpe — hydraulisch", NameEN: "Hydraulic Pump — hydraulic",
ID: "HP1826", NameDE: "Hydraulikpumpe — hydraulisch", NameEN: "Hydraulic Pump — hydraulic",
RequiredComponentTags: []string{"high_pressure", "hydraulic_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"operation"},
@@ -309,7 +309,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R068, R322, R571, R1071
},
{
ID: "HP072", NameDE: "Hydrauliksystem — hydraulisch", NameEN: "Hydraulic System — hydraulic",
ID: "HP1827", NameDE: "Hydrauliksystem — hydraulisch", NameEN: "Hydraulic System — hydraulic",
RequiredComponentTags: []string{"high_pressure", "hydraulic_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"maintenance"},
@@ -320,7 +320,7 @@ func getExtendedHazardPatternsA() []HazardPattern {
// Source: R575, R1075
},
{
ID: "HP073", NameDE: "Hydraulikventil — hydraulisch", NameEN: "Hydraulic Valve — hydraulic",
ID: "HP1828", NameDE: "Hydraulikventil — hydraulisch", NameEN: "Hydraulic Valve — hydraulic",
RequiredComponentTags: []string{"high_pressure", "hydraulic_part"},
RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"operation"},