Benjamin_Boenisch/breakpilot-compliance
1
0
Fork 0
Code Issues 24 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(iace): set-based measure-category filter + 235 pattern-author fixes

Browse Source 
Two-part nachhaltiger fix replacing the previous "fill to 5 mitigations
no matter what" behavior that the GT-Bremse benchmark proved
unfaithful (e.g. HP1625 "scharfe Kanten" returning M005 "Rotations-
bewegung vermeiden" via category fallback; HP1651 "Wiederanlauf
Roboter" returning M054 "Sichere thermische Auslegung" via
mismatched pattern reference).

PART A — Set-based category filter (handlers package):
- acceptableMeasureCategories: replaces 1:1 patternCatToMeasureCat
  with a curated set per pattern category, so e.g.
  safety_function_failure now accepts software_control measures
  (watchdogs, plausibility checks) and emc_hazard accepts both
  electrical and software_control measures
- isCategoryCompatible: gate every measure id against the accepted
  set before creating a mitigation; mismatches log MEASURE-SKIP
- The old category fallback is REMOVED. A hazard whose pattern has
  no category-compatible measure is now created with zero mitigations
  and logged as COVERAGE-GAP — the operator must consult an expert.
  No more silent invention of generic defaults.

PART B — 235 pattern author-error fixes across 26 files:
- HP040-HP044 (AI): M101/M102/M103 (Auffangwanne/Absauganlage) ->
  M133 Anomalieerkennung + M214 Plausibilitaet + M213 Sensor-Redundanz
  + M044 Zweikanalige Steuerung + others
- HP011-HP015, HP104-HP109, HP1085-HP1095, HP1281-HP1334 (electrical):
  M001-M005/M054/M061 placeholders -> M481/M482 Isolation +
  M511-M522 PE/Schutzleiter/RCD/Hauptschalter
- HP110-HP1331 (material_environmental): M101-M103 -> M384-M395
  Brandschutz/Laserschutz + M533/M408 SDB/PSA
- HP800-HP858, HP1178-HP1264 (software/sensor/hmi):
  M101/M104 -> M105/M106/M107/M214 SPS/Watchdog/Plausibilitaet
- HP026, HP611-HP1690 (ergonomic): M001/M082 -> M353-M360 +
  M530-M532 Hebehilfe/ergonomische Hoehe
- HP201-HP1697 (mechanical): M054/M051 -> M002/M008/M061/M141 +
  M487/M488 Tueroeffnung-Stillsetzung/Wiederanlauf
- Plus EMF/Strahlung/Brand/Lärm/Vibration/Kommunikation/Cyber

Coverage shift (Pattern-Author-Fehler bei aktiviertem Set-Filter):
   start:         237 patterns with zero category-compatible measures
   after Stufe 1A:   5 (AI)
   after Stufe 1B:  20 (mechanical Bestand)
   after Stufe 1C:  35 (electrical Bestand)
   after Stufe 1D:  29 (material_environmental)
   after Stufe 1E:  29 (software/sensor/hmi)
   after Stufe 1F:  20 (ergonomic)
   after Stufe 1G:  80 (thermal/comm/radiation/fire/safety)
   final:           0  (28 extended.go/extended2.go duplicates fixed)

New regression tests:
- TestEveryPattern_HasCategoryCompatibleMeasure: every pattern in
  collectAllPatterns() must reference at least one category-compatible
  measure; gaps must be explicitly listed in AllowlistKnownGaps
  (currently empty). Fails CI for any new pattern that drifts.
- TestAcceptableMeasureCategories: pins the set-mapping for the
  7 most-bug-prone pattern categories.
- TestIsCategoryCompatible_EmptyMeasureCat: protects legacy entries.

A separate task #11 tracks 58 HP-ID duplicates between
extended.go/extended2.go and cobot.go/press.go/operational.go —
patterns are semantically different and TestGetBuiltinHazardPatterns_-
UniqueIDs misses them because it only checks HP001-HP044.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Benjamin Admin
2026-05-16 21:11:02 +02:00
parent 938f9a6c51
commit 6a3e96d54c
36 changed files with 549 additions and 273 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ai-compliance-sdk/internal/iace/hazard_patterns_extended2.go
+13 -13
View File
@@ -10,7 +10,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"communication_failure"},
SuggestedMeasureIDs: []string{"M116"},
SuggestedMeasureIDs: []string{"M113", "M106", "M141"},
SuggestedEvidenceIDs: []string{"E08"},
Priority: 70,
// Source: R075, R329, R585, R1085
@@ -43,7 +43,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"hydraulic_pressure"},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"mechanical_hazard"},
SuggestedMeasureIDs: []string{"M021"},
SuggestedMeasureIDs: []string{"M482", "M481", "M522", "M141"},
SuggestedEvidenceIDs: []string{"E11"},
Priority: 80,
// Source: R560, R1060
@@ -76,7 +76,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"model_drift"},
SuggestedMeasureIDs: []string{"M103"},
SuggestedMeasureIDs: []string{"M133", "M227", "M141"},
SuggestedEvidenceIDs: []string{"E15"},
Priority: 75,
// Source: R078, R332, R589, R1089
@@ -109,7 +109,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"mechanical_hazard"},
SuggestedMeasureIDs: []string{"M052"},
SuggestedMeasureIDs: []string{"M061", "M002", "M141"},
SuggestedEvidenceIDs: []string{"E20"},
Priority: 80,
// Source: R336, R594, R1094
@@ -142,7 +142,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"maintenance", "operation"},
GeneratedHazardCats: []string{"electrical_hazard"},
SuggestedMeasureIDs: []string{"M061", "M121"},
SuggestedMeasureIDs: []string{"M481", "M482", "M141"},
SuggestedEvidenceIDs: []string{"E14", "E20"},
Priority: 80,
// Source: R063, R311, R312, R568, R1068
@@ -153,7 +153,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"sensor_fault"},
SuggestedMeasureIDs: []string{"M082"},
SuggestedMeasureIDs: []string{"M214", "M119", "M141"},
SuggestedEvidenceIDs: []string{"E08"},
Priority: 70,
// Source: R073, R327, R582, R1082
@@ -175,7 +175,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"software_fault"},
SuggestedMeasureIDs: []string{"M103"},
SuggestedMeasureIDs: []string{"M533", "M141"},
SuggestedEvidenceIDs: []string{"E14"},
Priority: 70,
// Source: R553, R1053
@@ -208,7 +208,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"mechanical_hazard"},
SuggestedMeasureIDs: []string{"M051"},
SuggestedMeasureIDs: []string{"M061", "M002", "M141"},
SuggestedEvidenceIDs: []string{"E20"},
Priority: 80,
// Source: R558, R1058
@@ -230,7 +230,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"mechanical_hazard"},
SuggestedMeasureIDs: []string{"M051"},
SuggestedMeasureIDs: []string{"M061", "M002", "M141"},
SuggestedEvidenceIDs: []string{"E20"},
Priority: 80,
// Source: R565, R1065
@@ -274,7 +274,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"kinetic"},
RequiredLifecycles: []string{"maintenance", "operation"},
GeneratedHazardCats: []string{"mechanical_hazard"},
SuggestedMeasureIDs: []string{"M051"},
SuggestedMeasureIDs: []string{"M061", "M002", "M141"},
SuggestedEvidenceIDs: []string{"E14", "E20"},
Priority: 80,
// Source: R059, R060
@@ -296,7 +296,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"inspection", "operation"},
GeneratedHazardCats: []string{"electrical_hazard", "thermal_hazard"},
SuggestedMeasureIDs: []string{"M014", "M062"},
SuggestedMeasureIDs: []string{"M481", "M477", "M141"},
SuggestedEvidenceIDs: []string{"E10"},
Priority: 80,
// Source: R064, R313, R314, R569, R1069
@@ -307,7 +307,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"sensor_fault"},
SuggestedMeasureIDs: []string{"M103"},
SuggestedMeasureIDs: []string{"M214", "M119", "M141"},
SuggestedEvidenceIDs: []string{"E15"},
Priority: 70,
// Source: R077, R331, R588, R1088
@@ -318,7 +318,7 @@ func getExtendedHazardPatternsB() []HazardPattern {
RequiredEnergyTags: []string{"electrical_energy"},
RequiredLifecycles: []string{"operation"},
GeneratedHazardCats: []string{"ai_misclassification"},
SuggestedMeasureIDs: []string{"M082"},
SuggestedMeasureIDs: []string{"M133", "M227", "M141"},
SuggestedEvidenceIDs: []string{"E20"},
Priority: 75,
// Source: R584, R1084