sharang/compliance-scanner-agent
1
0
Fork 0
Code Issues 51 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

feat: add E2E test suite with nightly CI, fix dashboard Dockerfile #52

Merged
sharang merged 3 commits from feat/e2e-tests into main 2026-03-30 10:04:07 +00:00
Conversation 3 Commits 3 Files Changed 18 +1 -1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d418f8386f - Show all commits

2
.gitea/workflows/ci.yml
View File

@@ -70,7 +70,7 @@ jobs:
# Tests (reuses compilation artifacts from clippy)
- name: Tests (core + agent)
run: cargo test -p compliance-core -p compliance-agent
run: cargo test -p compliance-core -p compliance-agent --lib
sharang commented 2026-03-30 09:53:24 +00:00
Review
Copy Link

[medium] Inconsistent test command in CI workflow

The test command for core and agent packages was changed from cargo test -p compliance-core -p compliance-agent to cargo test -p compliance-core -p compliance-agent --lib. This change may exclude integration tests from being run, potentially hiding failures in the agent's integration behavior.

Suggested fix: Revert to the previous command or explicitly include integration tests in the test suite.

*Scanner: code-review/convention | *

**[medium] Inconsistent test command in CI workflow** The test command for core and agent packages was changed from `cargo test -p compliance-core -p compliance-agent` to `cargo test -p compliance-core -p compliance-agent --lib`. This change may exclude integration tests from being run, potentially hiding failures in the agent's integration behavior. Suggested fix: Revert to the previous command or explicitly include integration tests in the test suite. *Scanner: code-review/convention | * <!-- compliance-fp:0318699a9f87360b01475eb9fc5c879e57a3d39cc3c95a39b027f587a481c7cd -->
sharang commented 2026-03-30 09:53:24 +00:00
Review
Copy Link

[low] Complex boolean expression in CI workflow

The test command in the CI workflow uses a complex boolean expression with multiple package specifications and feature flags that could be simplified for better readability and maintainability.

Suggested fix: Consider breaking down the cargo test command into separate steps or using a more structured approach to specify test targets and features.

*Scanner: code-review/complexity | *

**[low] Complex boolean expression in CI workflow** The test command in the CI workflow uses a complex boolean expression with multiple package specifications and feature flags that could be simplified for better readability and maintainability. Suggested fix: Consider breaking down the cargo test command into separate steps or using a more structured approach to specify test targets and features. *Scanner: code-review/complexity | * <!-- compliance-fp:7c6667a7ba5d7d102c83c987e9e0130f4537c7325d05f0f869a4296f75e3b05e -->
- name: Tests (dashboard server)
run: cargo test -p compliance-dashboard --features server --no-default-features
- name: Tests (dashboard web)