sharang/compliance-scanner-agent
1
0
Fork 0
Code Issues 79 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

fix(plc): scan every PLC-source artifact, not just the first #178

Merged
sharang merged 1 commits from feat/plc-scan-all-artifacts into main 2026-07-16 19:59:59 +00:00
Conversation 0 Commits 1 Files Changed 1
+44 -33
sharang commented 2026-07-16 19:54:06 +00:00
Owner
Copy Link
Copy Source

Found live during the demo: a target with two PLC artifacts (pump_station.st + pump_fbd.xml) only produced findings for the first, because run_plc_scan used first_of(PlcProject). Now it iterates every PlcProject / git / source-archive artifact, merges control-logic findings, and unions the control-app SBOM (deduped by name+version). Tracker #167.

🤖 Generated with Claude Code

Found live during the demo: a target with **two** PLC artifacts (`pump_station.st` + `pump_fbd.xml`) only produced findings for the first, because `run_plc_scan` used `first_of(PlcProject)`. Now it iterates **every** PlcProject / git / source-archive artifact, merges control-logic findings, and unions the control-app SBOM (deduped by name+version). Tracker #167. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
sharang added 1 commit 2026-07-16 19:54:07 +00:00
fix(plc): scan every PLC-source artifact, not just the first
CI / Check (pull_request) Successful in 5m22s
Details
CI / Detect Changes (pull_request) Has been skipped
Details
CI / Deploy Agent (pull_request) Has been skipped
Details
CI / Deploy Dashboard (pull_request) Has been skipped
Details
CI / Deploy Docs (pull_request) Has been skipped
Details
CI / Deploy MCP (pull_request) Has been skipped
Details
34d6569d78 
run_plc_scan analyzed only the first PlcProject (or single code artifact), so a
target with several PLC artifacts (e.g. one PLCopen XML export per POU) had the
rest silently ignored. Found live: a target with pump_station.st + pump_fbd.xml
only produced findings for the first.

Iterate over every PlcProject / git repo / source-archive artifact on the target,
merge the control-logic findings, and union the control-app SBOM (deduped by
name+version) across all of them.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sharang merged commit 4f9e2c2828 into main 2026-07-16 19:59:59 +00:00
sharang deleted branch feat/plc-scan-all-artifacts 2026-07-16 19:59:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-demo
CERTifAI P0 demo build tickets (CS-*)
 bug
critical
enhancement
epic
Tracking issue spanning multiple sub-issues
 high
infrastructure
onboarding
Multi-target onboarding wizard redesign
 performance
security
v0.3.0
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Benjamin_Boenisch sharang (Sharang Parnerkar)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sharang/compliance-scanner-agent#178