Files
breakpilot-lehrer/school-service/internal/notifications/dispatcher.go
T
Benjamin Admin 8311b33fb3
CI / go-lint (push) Has been skipped
CI / python-lint (push) Has been skipped
CI / nodejs-lint (push) Has been skipped
CI / test-go-school (push) Successful in 1m10s
CI / test-go-edu-search (push) Successful in 43s
CI / test-python-klausur (push) Failing after 4m4s
CI / test-python-agent-core (push) Successful in 44s
CI / test-nodejs-website (push) Successful in 51s
Phase 9d: Notification cron + multilingual templates + status badges
Backend (school-service):
  - notification_log table with UNIQUE(event_id, lead_days, audience,
    channel) for idempotent re-runs. Status enum sent/failed/skipped.
  - internal/notifications/templates.go: per-event-type × audience ×
    lead-day-bucket × language templates in 8 languages (de/en/tr/ar/
    uk/ru/pl/fr). Fallback chain (lang→de, eventType→andere) so we
    never miss a render.
  - service.go scans cal_school_event for events whose
    (start_date - runDate) appears in notification_lead_days. For each
    due (audience, channel) tuple it dispatches via POST to the
    Matrix/Email upstreams owned by the colleague's services.
    Empty URL → status='skipped', logged for visibility.
  - dispatcher.go handles the POST, parent-recipient lookup (joins
    parent_account + parent_child + cal_school_event.affected_class_ids),
    and writeLog with the unique constraint dropping duplicate runs.
  - main.go runs a 1-hour ticker; when time.Hour()==6 it invokes the
    scanner for today. Idempotent so transient restarts don't double-
    send.
  - POST /calendar/notifications/run-now for manual trigger + backfill
    (?date=YYYY-MM-DD).
  - GET /calendar/events/:id/notifications returns notification_log
    rows scoped to the owning teacher.
  - MATRIX_SERVICE_URL + EMAIL_SERVICE_URL env vars added (default
    empty = stub mode).

Frontend (studio-v2):
  - NotificationStatus component fetches /events/:id/notifications and
    renders coloured badges per (lead, audience, channel, status).
  - DayDetail mounts NotificationStatus inside each event card when
    notify_parents or notify_students is set.

Tests:
  - 6 new Go unit tests for bucketFor + Render (de/tr/fallback paths)
    + substitute(class_suffix). 89 subtests gesamt.
  - 2 new Playwright tests: badge render with mocked log, hidden when
    notifications are off.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-22 18:12:39 +02:00

152 lines
4.9 KiB
Go

package notifications
import (
"bytes"
"context"
"encoding/json"
"fmt"
"log"
"net/http"
"time"
)
// dispatchOne builds the payload for one (event, audience, channel) tuple,
// posts it to the upstream Matrix/Email service, and writes a
// notification_log row. Returns one of "sent", "failed", "skipped",
// "already" so the caller can tally counters.
//
// "skipped" means the upstream URL is empty (dev/test mode) — we still log
// so the UI can render "will-send-when-configured". "already" means the
// (event, lead, audience, channel) combo is already logged from an earlier
// run today; we don't re-send.
func (s *Service) dispatchOne(ctx context.Context, e dueEvent, audience, channel string, runDate time.Time) (status string, err error) {
// Idempotency check.
var existing int
if err := s.db.QueryRow(ctx, `
SELECT COUNT(*) FROM notification_log
WHERE event_id = $1 AND lead_days = $2 AND audience = $3 AND channel = $4
`, e.ID, e.LeadDays, audience, channel).Scan(&existing); err != nil {
return "failed", err
}
if existing > 0 {
return "already", nil
}
recipients, lang, err := s.recipientsFor(ctx, e, audience)
if err != nil {
return "failed", err
}
url := s.urlFor(channel)
if url == "" {
// Stub mode: write a 'skipped' log row but report success so the cron
// counter isn't alarming when running locally without the upstream.
_ = s.writeLog(ctx, e, audience, channel, "skipped", "no upstream URL configured", runDate)
return "skipped", nil
}
subject, body := Render(e.EventType, audience, e.LeadDays, lang, Vars{
Title: e.Title, Date: e.StartDate.Format("2006-01-02"),
DatePretty: e.StartDate.Format("02.01.2006"), ClassName: e.ClassName,
})
for _, recipient := range recipients {
payload := DispatchPayload{
Channel: channel, Recipient: recipient, Language: lang,
Subject: subject, Body: body, EventID: e.ID, LeadDays: e.LeadDays,
}
if err := s.postUpstream(ctx, url, payload); err != nil {
_ = s.writeLog(ctx, e, audience, channel, "failed", err.Error(), runDate)
return "failed", err
}
}
if err := s.writeLog(ctx, e, audience, channel, "sent", "", runDate); err != nil {
log.Printf("notification_log insert failed (already counted as sent): %v", err)
}
return "sent", nil
}
// recipientsFor returns the list of email addresses (parents) or Matrix
// handles (students — derived from … unimplemented for now; we just return
// the parent emails and let the bridge fan out).
//
// Per memory the Matrix/Email upstream services are owned by the colleague;
// our job here is to hand them a recipient identifier they can resolve.
// For parents that's the email; for students we have no contact identifier
// yet, so we fall back to the parent emails too (broadcast).
func (s *Service) recipientsFor(ctx context.Context, e dueEvent, audience string) ([]string, string, error) {
// Find the class IDs from the event row. If empty → all classes owned by
// the teacher.
rows, err := s.db.Query(ctx, `
SELECT DISTINCT pa.email, pa.preferred_language
FROM parent_account pa
JOIN parent_child pc ON pc.parent_id = pa.id
WHERE pa.created_by_user_id = $1
AND (
(SELECT array_length(affected_class_ids, 1) FROM cal_school_event WHERE id = $2) IS NULL
OR pc.tt_class_id = ANY(
(SELECT affected_class_ids FROM cal_school_event WHERE id = $2)
)
)
`, e.OwnerUserID, e.ID)
if err != nil {
return nil, "de", err
}
defer rows.Close()
var emails []string
primaryLang := "de"
first := true
for rows.Next() {
var email, lang string
if err := rows.Scan(&email, &lang); err != nil {
return nil, "de", err
}
emails = append(emails, email)
if first {
primaryLang = lang
first = false
}
}
return emails, primaryLang, nil
}
func (s *Service) urlFor(channel string) string {
switch channel {
case "matrix":
return s.matrixURL
case "email":
return s.emailURL
}
return ""
}
func (s *Service) postUpstream(ctx context.Context, url string, payload DispatchPayload) error {
body, _ := json.Marshal(payload)
cctx, cancel := context.WithTimeout(ctx, s.httpTimeout)
defer cancel()
req, err := http.NewRequestWithContext(cctx, "POST", url, bytes.NewReader(body))
if err != nil {
return err
}
req.Header.Set("Content-Type", "application/json")
resp, err := http.DefaultClient.Do(req)
if err != nil {
return err
}
defer resp.Body.Close()
if resp.StatusCode >= 400 {
return fmt.Errorf("upstream returned HTTP %d", resp.StatusCode)
}
return nil
}
func (s *Service) writeLog(ctx context.Context, e dueEvent, audience, channel, status, errorMessage string, runDate time.Time) error {
_, err := s.db.Exec(ctx, `
INSERT INTO notification_log (event_id, lead_days, audience, channel, status, error_message, run_date)
VALUES ($1::uuid, $2, $3, $4, $5, NULLIF($6, ''), $7::date)
ON CONFLICT (event_id, lead_days, audience, channel) DO NOTHING
`, e.ID, e.LeadDays, audience, channel, status, errorMessage, runDate.Format("2006-01-02"))
return err
}