d4d9b60007
CI / detect-changes (push) Successful in 12s
CI / branch-name (push) Has been skipped
CI / guardrail-integrity (push) Has been skipped
CI / secret-scan (push) Has been skipped
CI / dep-audit (push) Has been skipped
CI / sbom-scan (push) Has been skipped
CI / validate-canonical-controls (push) Successful in 15s
CI / loc-budget (push) Successful in 20s
CI / go-lint (push) Has been skipped
CI / python-lint (push) Has been skipped
CI / nodejs-lint (push) Has been skipped
CI / nodejs-build (push) Successful in 3m8s
CI / test-go (push) Has been skipped
CI / iace-gt-coverage (push) Has been skipped
CI / test-python-backend (push) Successful in 47s
CI / test-python-document-crawler (push) Has been skipped
CI / test-python-dsms-gateway (push) Has been skipped
Backend wirft 90% der consent-tester-Daten weg — nur 4 Felder von einem
vollen Banner-Scan landeten im Email. Phases (before_consent / after_reject
/ after_accept), banner_checks.violations mit Rechtsgrundlagen,
category_tests, 46 structured_checks, completeness/correctness-Scores
waren alle nicht sichtbar.
Backend: agent_compliance_check_routes leitet jetzt das volle banner_result
durch (15 Felder statt 4).
Renderer (2 neue Module):
1) agent_doc_check_critical.build_critical_findings_html
- ROTER Sofortmassnahmen-Block GANZ OBEN in der Email
- Erkennt: banner-violations (HIGH/CRITICAL), leere Per-Category-Lists,
DSE-Score <30%, fehlende Cookie-Richtlinie, US-Tracker ohne SCC/DPF
- Pro Issue: konkrete Sofortmassnahme + Rechtsgrundlage + Bussgeld-
Praezedenz (CNIL TikTok 5 Mio, LfDI BW 30k, EuGH Schrems II, ...)
- Wird nur gerendert wenn echte Issues vorliegen
2) agent_doc_check_banner.build_banner_deep_html
- Banner-Quality-Score-Cards (Vollstaendigkeit / Korrektheit / Verstoesse)
- 3-Phasen-Cookie-Tabelle: vor Consent / nach Ablehnung / nach Annahme
mit Cookie-Count, Tracker-Count, Auffaelligkeiten
- Per-Category-Tracker-Listing (Statistik/Marketing) — zeigt explizit
wenn eine Kategorie keine Provider listet (Safetykon-Pattern)
- Violations-Liste mit Severity-Badge + Quellen-Hint (LG Rostock, EDPB)
Smoke-Test Safetykon: alle 6 neuen Blocks rendern, kein Regression.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
202 lines
9.0 KiB
Python
202 lines
9.0 KiB
Python
"""
|
|
P18 — Erweiterter Banner-Block fuer die Email.
|
|
|
|
Rendert die Daten aus dem consent-tester die heute weggeworfen wurden:
|
|
- 3-Phasen-Cookie-Tabelle (before_consent / after_reject / after_accept)
|
|
- Banner-Quality-Score (completeness/correctness/violations)
|
|
- Per-Category-Tracker-Listing
|
|
- Violations-Liste mit Rechtsgrundlagen
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
def _color_for(pct: int) -> str:
|
|
return ("#16a34a" if pct >= 80 else
|
|
"#d97706" if pct >= 50 else "#dc2626")
|
|
|
|
|
|
def _short_phase_label(key: str) -> str:
|
|
return {
|
|
"before_consent": "Vor Consent",
|
|
"after_reject": "Nach Ablehnung",
|
|
"after_accept": "Nach Annahme",
|
|
}.get(key, key)
|
|
|
|
|
|
def _phase_color(key: str, cookie_count: int) -> str:
|
|
if key == "before_consent":
|
|
return "#16a34a" if cookie_count == 0 else "#dc2626"
|
|
if key == "after_reject":
|
|
return "#16a34a" if cookie_count <= 1 else "#d97706"
|
|
return "#94a3b8"
|
|
|
|
|
|
def build_banner_deep_html(banner_result: dict | None) -> str:
|
|
"""Render: Banner-Quality + Phases + Violations.
|
|
|
|
Konsumiert das volle consent-tester-Response. Komplementiert
|
|
`build_provider_list_html` (das nur Summary + TCF-Vendor-Tabelle macht).
|
|
"""
|
|
if not banner_result:
|
|
return ""
|
|
|
|
parts: list[str] = [
|
|
'<div style="font-family:-apple-system,BlinkMacSystemFont,sans-serif;'
|
|
'max-width:700px;margin:0 auto 16px;padding:14px 18px;'
|
|
'background:#fff;border:1px solid #cbd5e1;border-radius:8px">'
|
|
'<h3 style="margin:0 0 12px;font-size:14px;color:#0f172a">'
|
|
'Cookie-Banner — technische Analyse</h3>'
|
|
]
|
|
|
|
# 1) Quality-Score-Cards
|
|
compl = banner_result.get("completeness_pct")
|
|
corr = banner_result.get("correctness_pct")
|
|
summary = banner_result.get("summary") or {}
|
|
n_critical = summary.get("critical", 0)
|
|
n_high = summary.get("high", 0)
|
|
if compl is not None or corr is not None:
|
|
parts.append(
|
|
'<table style="width:100%;border-collapse:separate;'
|
|
'border-spacing:6px;margin-bottom:10px"><tr>'
|
|
)
|
|
if compl is not None:
|
|
c = _color_for(int(compl))
|
|
parts.append(
|
|
f'<td style="width:33%;padding:8px 10px;background:#f8fafc;'
|
|
f'border-radius:5px;border-left:3px solid {c}">'
|
|
f'<div style="font-size:10px;color:#64748b;text-transform:uppercase">'
|
|
f'Vollstaendigkeit</div>'
|
|
f'<div style="font-size:18px;font-weight:700;color:{c}">{compl}%</div>'
|
|
f'</td>'
|
|
)
|
|
if corr is not None:
|
|
c = _color_for(int(corr))
|
|
parts.append(
|
|
f'<td style="width:33%;padding:8px 10px;background:#f8fafc;'
|
|
f'border-radius:5px;border-left:3px solid {c}">'
|
|
f'<div style="font-size:10px;color:#64748b;text-transform:uppercase">'
|
|
f'Korrektheit</div>'
|
|
f'<div style="font-size:18px;font-weight:700;color:{c}">{corr}%</div>'
|
|
f'</td>'
|
|
)
|
|
viol_c = ("#dc2626" if n_critical + n_high > 0 else
|
|
"#d97706" if (summary.get("total_violations") or 0) > 0 else
|
|
"#16a34a")
|
|
parts.append(
|
|
f'<td style="width:33%;padding:8px 10px;background:#f8fafc;'
|
|
f'border-radius:5px;border-left:3px solid {viol_c}">'
|
|
f'<div style="font-size:10px;color:#64748b;text-transform:uppercase">'
|
|
f'Verstoesse</div>'
|
|
f'<div style="font-size:18px;font-weight:700;color:{viol_c}">'
|
|
f'{summary.get("total_violations", 0)}'
|
|
f'<span style="font-size:11px;color:#64748b;margin-left:6px">'
|
|
f'(crit:{n_critical} high:{n_high})</span></div></td>'
|
|
)
|
|
parts.append('</tr></table>')
|
|
|
|
# 2) 3-Phasen-Tabelle
|
|
phases = banner_result.get("phases") or {}
|
|
if phases:
|
|
parts.append(
|
|
'<div style="font-size:11px;color:#475569;margin:8px 0 4px;'
|
|
'font-weight:600">Cookie-Setzungen pro Phase '
|
|
'(echter Browser-Test):</div>'
|
|
'<table style="width:100%;border-collapse:collapse;font-size:11px;'
|
|
'margin-bottom:10px;border:1px solid #e2e8f0">'
|
|
'<thead><tr style="background:#f1f5f9;color:#475569;text-align:left">'
|
|
'<th style="padding:5px 8px">Phase</th>'
|
|
'<th style="padding:5px 8px;text-align:center">Cookies</th>'
|
|
'<th style="padding:5px 8px;text-align:center">Tracker</th>'
|
|
'<th style="padding:5px 8px">Auffaelligkeiten</th>'
|
|
'</tr></thead><tbody>'
|
|
)
|
|
for key in ("before_consent", "after_reject", "after_accept"):
|
|
ph = phases.get(key) or {}
|
|
if not isinstance(ph, dict): continue
|
|
cookies = ph.get("cookies") or []
|
|
trackers = ph.get("tracking_services") or []
|
|
new_track = ph.get("new_tracking") or []
|
|
violations = ph.get("violations") or []
|
|
undoc = ph.get("undocumented") or []
|
|
color = _phase_color(key, len(cookies))
|
|
issues_parts = []
|
|
if violations: issues_parts.append(f"{len(violations)} Verstoss")
|
|
if new_track: issues_parts.append(f"{len(new_track)} neue Tracker")
|
|
if undoc: issues_parts.append(f"{len(undoc)} undokumentiert")
|
|
issues_str = ", ".join(issues_parts) or "—"
|
|
parts.append(
|
|
f'<tr style="border-top:1px solid #e2e8f0">'
|
|
f'<td style="padding:5px 8px;color:#1e293b;font-weight:600">'
|
|
f'<span style="display:inline-block;width:6px;height:6px;'
|
|
f'border-radius:50%;background:{color};margin-right:6px"></span>'
|
|
f'{_short_phase_label(key)}</td>'
|
|
f'<td style="padding:5px 8px;text-align:center;color:{color};'
|
|
f'font-weight:600">{len(cookies)}</td>'
|
|
f'<td style="padding:5px 8px;text-align:center">{len(trackers)}</td>'
|
|
f'<td style="padding:5px 8px;color:#475569">{issues_str}</td>'
|
|
f'</tr>'
|
|
)
|
|
parts.append('</tbody></table>')
|
|
|
|
# 3) Per-Category-Tracker
|
|
cats = banner_result.get("category_tests") or []
|
|
if cats:
|
|
non_essential = [c for c in cats if c.get("category") != "necessary"]
|
|
if non_essential:
|
|
parts.append(
|
|
'<div style="font-size:11px;color:#475569;margin:8px 0 4px;'
|
|
'font-weight:600">Provider-Listing pro Banner-Kategorie:</div>'
|
|
'<table style="width:100%;border-collapse:collapse;font-size:11px;'
|
|
'margin-bottom:10px;border:1px solid #e2e8f0">'
|
|
'<thead><tr style="background:#f1f5f9;color:#475569;text-align:left">'
|
|
'<th style="padding:5px 8px">Kategorie</th>'
|
|
'<th style="padding:5px 8px;text-align:center">Anbieter</th>'
|
|
'<th style="padding:5px 8px">Hinweis</th>'
|
|
'</tr></thead><tbody>'
|
|
)
|
|
for c in non_essential:
|
|
n = len(c.get("tracking_services") or [])
|
|
label = c.get("category_label") or c.get("category", "?")
|
|
if n == 0:
|
|
color = "#dc2626"
|
|
hint = ("Keine Anbieter sichtbar — Nutzer kann nicht "
|
|
"informiert einwilligen (Art. 7 DSGVO)")
|
|
else:
|
|
color = "#16a34a"
|
|
hint = ""
|
|
parts.append(
|
|
f'<tr style="border-top:1px solid #e2e8f0">'
|
|
f'<td style="padding:5px 8px">{label}</td>'
|
|
f'<td style="padding:5px 8px;text-align:center;color:{color};'
|
|
f'font-weight:600">{n}</td>'
|
|
f'<td style="padding:5px 8px;color:#dc2626;font-size:10px">'
|
|
f'{hint}</td></tr>'
|
|
)
|
|
parts.append('</tbody></table>')
|
|
|
|
# 4) Violations mit Rechtsgrundlage
|
|
violations = (banner_result.get("banner_checks") or {}).get("violations", [])
|
|
if violations:
|
|
parts.append(
|
|
'<div style="font-size:11px;color:#475569;margin:8px 0 4px;'
|
|
'font-weight:600">Erkannte Banner-Verstoesse:</div>'
|
|
'<ul style="margin:0 0 8px 18px;padding:0;font-size:11px;color:#1e293b">'
|
|
)
|
|
for v in violations[:8]:
|
|
sev = (v.get("severity") or "MEDIUM").upper()
|
|
sev_c = ("#dc2626" if sev in ("CRITICAL", "HIGH") else
|
|
"#d97706" if sev == "MEDIUM" else "#94a3b8")
|
|
parts.append(
|
|
f'<li style="margin-bottom:6px">'
|
|
f'<span style="display:inline-block;background:{sev_c};color:#fff;'
|
|
f'font-size:9px;padding:1px 5px;border-radius:3px;margin-right:6px">'
|
|
f'{sev}</span>{v.get("text", "")[:200]}'
|
|
f'<div style="font-size:10px;color:#94a3b8;margin-top:2px;'
|
|
f'font-style:italic">Quelle: {v.get("legal_ref", "")}</div></li>'
|
|
)
|
|
parts.append('</ul>')
|
|
|
|
parts.append('</div>')
|
|
return "".join(parts)
|