Benjamin Admin
129849aa21
CI / branch-name (push) Has been skipped
CI / test-python-dsms-gateway (push) Successful in 21s
CI / validate-canonical-controls (push) Successful in 13s
CI / guardrail-integrity (push) Has been skipped
CI / loc-budget (push) Failing after 15s
CI / secret-scan (push) Has been skipped
CI / go-lint (push) Has been skipped
CI / python-lint (push) Has been skipped
CI / nodejs-lint (push) Has been skipped
CI / nodejs-build (push) Successful in 2m38s
CI / dep-audit (push) Has been skipped
CI / sbom-scan (push) Has been skipped
CI / test-go (push) Successful in 45s
CI / test-python-backend (push) Successful in 52s
CI / test-python-document-crawler (push) Successful in 30s
Check 12: Click count — reject requires more clicks than accept (CNIL 150M EUR) Check 13: Color contrast — reject button invisible (same bg as banner) Check 14: Google Consent Mode — analytics_storage 'granted' as default Check 15: Pre-consent cookies — tracking cookies set before any interaction Check 16: Registration coupling — login button = consent (Art. 7(4) DSGVO) Check 17: Language mismatch — banner vs page language (all 26 EU languages) Check 18: Consent cookie expiry — >13 months violates CNIL guidelines Check 19: Nudging — reject button below fold / requires scrolling Check 20: Emotional language (Stirring) — "volle Funktionalitaet" etc. Language detection covers: BG, CS, DA, DE, EL, EN, ES, ET, FI, FR, GA, HR, HU, IS, IT, LT, LV, MT, NL, NO, PL, PT, RO, SK, SL, SV New file: banner_advanced_checks.py (396 LOC) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
408 lines
19 KiB
Python
408 lines
19 KiB
Python
"""
|
|
Banner text legal checks — extracted from consent_scanner.py.
|
|
|
|
11 checks for cookie banner legal compliance:
|
|
1. Impressum link accessible (§5 TMG)
|
|
2. DSE link in banner (Art. 13 DSGVO)
|
|
3. Wrong DSE consent wording (Art. 13 DSGVO)
|
|
4. Reject button visible (§25 TDDDG)
|
|
5. Pre-ticked checkboxes (Planet49)
|
|
6. Dark pattern button size (EDPB 05/2020)
|
|
7. Cookie wall (Phase B check)
|
|
8. Re-access to settings (Art. 7(3) DSGVO)
|
|
9. Third-party DSE link (Art. 13 DSGVO)
|
|
10. Dark-pattern language (EDPB 05/2020)
|
|
11. Non-modal dismiss = consent (Planet49)
|
|
"""
|
|
|
|
import logging
|
|
|
|
from services.script_analyzer import Violation
|
|
from services.banner_advanced_checks import run_advanced_checks
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
async def check_banner_text(page) -> dict:
|
|
"""Check cookie banner text for legal issues.
|
|
|
|
1. Impressum link must be accessible even with banner overlay (§5 TMG)
|
|
2. DSE link must be accessible from banner
|
|
3. "Zustimmung zur Datenschutzerklärung" is WRONG — DSE is an information
|
|
obligation (Art. 13 DSGVO), not something users "agree" to
|
|
"""
|
|
violations = []
|
|
has_impressum = False
|
|
has_dse = False
|
|
|
|
try:
|
|
# Get banner text and links
|
|
banner_text = ""
|
|
banner_links = []
|
|
|
|
# Try common banner container selectors
|
|
for selector in [
|
|
"#CybotCookiebotDialog", "#onetrust-banner-sdk", "#didomi-host",
|
|
"#usercentrics-root", ".cky-consent-container", "#cmpbox",
|
|
'[class*="cookie-banner"]', '[class*="consent-banner"]',
|
|
'[class*="cookie-notice"]', '[role="dialog"]',
|
|
]:
|
|
try:
|
|
el = page.locator(selector).first
|
|
if await el.count() > 0:
|
|
banner_text = (await el.text_content() or "").strip()
|
|
# Get links inside banner
|
|
links = await el.locator("a[href]").all()
|
|
for link in links:
|
|
href = await link.get_attribute("href") or ""
|
|
text = (await link.text_content() or "").strip()
|
|
banner_links.append({"href": href.lower(), "text": text.lower()})
|
|
if banner_text:
|
|
break
|
|
except Exception:
|
|
continue
|
|
|
|
if not banner_text:
|
|
return {"violations": violations, "has_impressum": False, "has_dse": False}
|
|
|
|
banner_lower = banner_text.lower()
|
|
|
|
# Check 1: Impressum link in or accessible through banner
|
|
has_impressum = any(
|
|
"impressum" in l["href"] or "impressum" in l["text"] or
|
|
"imprint" in l["href"] or "legal notice" in l["text"]
|
|
for l in banner_links
|
|
)
|
|
# Also check if impressum is visible behind/around banner
|
|
if not has_impressum:
|
|
try:
|
|
imp_visible = await page.locator('a[href*="impressum"], a[href*="imprint"]').first
|
|
if await imp_visible.count() > 0 and await imp_visible.is_visible():
|
|
has_impressum = True
|
|
except Exception:
|
|
pass
|
|
|
|
if not has_impressum:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="HIGH",
|
|
text="Impressum nicht aus dem Cookie-Banner erreichbar. "
|
|
"Bei ueberlagerndem Banner muss ein Impressum-Link im Banner vorhanden sein (§5 TMG).",
|
|
legal_ref="§5 TMG, LG Rostock Az. 3 O 22/19",
|
|
))
|
|
|
|
# Check 2: DSE link in banner
|
|
has_dse = any(
|
|
"datenschutz" in l["href"] or "datenschutz" in l["text"] or
|
|
"privacy" in l["href"] or "privacy" in l["text"] or
|
|
"dsgvo" in l["href"]
|
|
for l in banner_links
|
|
)
|
|
if not has_dse:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="MEDIUM",
|
|
text="Kein Link zur Datenschutzerklaerung im Cookie-Banner. "
|
|
"Nutzer sollten vor der Einwilligung die DSE einsehen koennen.",
|
|
legal_ref="Art. 13 DSGVO, ErwGr. 42 DSGVO (informierte Einwilligung)",
|
|
))
|
|
|
|
# Check 3: Wrong wording — "Zustimmung zur Datenschutzerklärung"
|
|
wrong_dse_consent_patterns = [
|
|
"stimme der datenschutz",
|
|
"stimme den datenschutz",
|
|
"akzeptiere die datenschutz",
|
|
"akzeptiere die privacy",
|
|
"agree to the privacy policy",
|
|
"accept the privacy",
|
|
"datenschutzerklaerung zustimmen",
|
|
"datenschutzrichtlinie akzeptieren",
|
|
"datenschutzrichtlinie zustimmen",
|
|
"i agree to the privacy",
|
|
"i accept the privacy",
|
|
]
|
|
for pattern in wrong_dse_consent_patterns:
|
|
if pattern in banner_lower:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="HIGH",
|
|
text=f"Falsche Formulierung im Banner: 'Zustimmung zur Datenschutzerklaerung'. "
|
|
f"Die DSE ist eine Informationspflicht (Art. 13 DSGVO) — man kann sie "
|
|
f"nur zur Kenntnis nehmen, nicht 'zustimmen'. "
|
|
f"Korrekt: 'Ich habe die Datenschutzinformationen zur Kenntnis genommen'.",
|
|
legal_ref="Art. 13 DSGVO, ErwGr. 42 (informierte Einwilligung ≠ Zustimmung zur DSE)",
|
|
))
|
|
break
|
|
|
|
# Check 4: Reject button visible (no hidden reject)
|
|
reject_texts = ["ablehnen", "reject", "nur notwendige", "alle ablehnen", "decline"]
|
|
has_visible_reject = any(t in banner_lower for t in reject_texts)
|
|
if not has_visible_reject:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="HIGH",
|
|
text="Kein sichtbarer 'Ablehnen'-Button im Banner erkannt. "
|
|
"Die Ablehnung muss ebenso einfach sein wie die Zustimmung.",
|
|
legal_ref="§25 Abs. 1 TDDDG, EDPB Guidelines 05/2020 (Consent)",
|
|
))
|
|
|
|
# Check 5: Pre-ticked checkboxes (EuGH Planet49)
|
|
try:
|
|
pre_checked = await page.evaluate("""
|
|
() => {
|
|
const banner = document.querySelector(
|
|
'#CybotCookiebotDialog, #onetrust-banner-sdk, #didomi-host, '
|
|
+ '#usercentrics-root, .cky-consent-container, #cmpbox, '
|
|
+ '[class*="cookie-banner"], [class*="consent-banner"], [role="dialog"]'
|
|
);
|
|
if (!banner) return [];
|
|
const checked = banner.querySelectorAll(
|
|
'input[type="checkbox"]:checked:not([disabled])'
|
|
);
|
|
return [...checked]
|
|
.filter(cb => {
|
|
const label = cb.closest('label')?.textContent || cb.getAttribute('aria-label') || '';
|
|
const isNecessary = /notwendig|necessary|essential|erforderlich/i.test(label);
|
|
return !isNecessary;
|
|
})
|
|
.map(cb => cb.closest('label')?.textContent?.trim() || cb.id || 'unknown');
|
|
}
|
|
""")
|
|
if pre_checked:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="HIGH",
|
|
text=f"Vorausgewaehlte Checkboxen im Banner: {', '.join(pre_checked[:3])}. "
|
|
f"Einwilligung muss durch aktive Handlung erfolgen — vorausgefuellte "
|
|
f"Checkboxen sind ungueltig.",
|
|
legal_ref="Art. 4(11) DSGVO, EuGH C-673/17 (Planet49)",
|
|
))
|
|
except Exception:
|
|
pass
|
|
|
|
# Check 6: Dark Pattern — button size/prominence comparison
|
|
try:
|
|
button_info = await page.evaluate("""
|
|
() => {
|
|
const banner = document.querySelector(
|
|
'#CybotCookiebotDialog, #onetrust-banner-sdk, #didomi-host, '
|
|
+ '#usercentrics-root, .cky-consent-container, #cmpbox, '
|
|
+ '[class*="cookie-banner"], [class*="consent-banner"], [role="dialog"]'
|
|
);
|
|
if (!banner) return null;
|
|
const buttons = [...banner.querySelectorAll('button, a[role="button"], [class*="btn"]')];
|
|
return buttons.slice(0, 6).map(b => {
|
|
const style = window.getComputedStyle(b);
|
|
const rect = b.getBoundingClientRect();
|
|
return {
|
|
text: b.textContent?.trim()?.substring(0, 40) || '',
|
|
width: rect.width,
|
|
height: rect.height,
|
|
area: rect.width * rect.height,
|
|
bgColor: style.backgroundColor,
|
|
fontSize: parseFloat(style.fontSize),
|
|
visible: rect.width > 0 && rect.height > 0,
|
|
};
|
|
});
|
|
}
|
|
""")
|
|
if button_info and len(button_info) >= 2:
|
|
accept_btn = None
|
|
reject_btn = None
|
|
accept_kw = ["akzeptieren", "accept", "zustimmen", "agree", "einverstanden", "ok"]
|
|
reject_kw = ["ablehnen", "reject", "notwendige", "decline", "nein"]
|
|
|
|
for btn in button_info:
|
|
text_lower = btn["text"].lower()
|
|
if any(k in text_lower for k in accept_kw):
|
|
accept_btn = btn
|
|
elif any(k in text_lower for k in reject_kw):
|
|
reject_btn = btn
|
|
|
|
if accept_btn and reject_btn:
|
|
area_ratio = accept_btn["area"] / max(reject_btn["area"], 1)
|
|
if area_ratio > 2.5:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="MEDIUM",
|
|
text=f"Dark Pattern: 'Akzeptieren'-Button ist {area_ratio:.1f}x groesser als "
|
|
f"'Ablehnen'-Button. Beide Optionen muessen gleichwertig dargestellt werden.",
|
|
legal_ref="EDPB Guidelines 05/2020, §25 TDDDG, DSK Orientierungshilfe Telemedien",
|
|
))
|
|
size_ratio = accept_btn["fontSize"] / max(reject_btn["fontSize"], 1)
|
|
if size_ratio > 1.5:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="MEDIUM",
|
|
text=f"Dark Pattern: Schriftgroesse 'Akzeptieren' ({accept_btn['fontSize']:.0f}px) "
|
|
f"vs. 'Ablehnen' ({reject_btn['fontSize']:.0f}px). "
|
|
f"Unterschiedliche Schriftgroessen sind ein Dark Pattern.",
|
|
legal_ref="EDPB Guidelines 05/2020 (gleichwertige Darstellung)",
|
|
))
|
|
except Exception:
|
|
pass
|
|
|
|
# Check 7: Cookie Wall — does rejecting block the site?
|
|
# (This is checked in Phase B — if after reject the page is not navigable)
|
|
|
|
# Check 8: Re-access to settings (Art. 7(3) — revocation as easy as consent)
|
|
try:
|
|
settings_accessible = False
|
|
settings_selectors = [
|
|
'[class*="cookie-settings"]', '[class*="privacy-settings"]',
|
|
'a[href*="cookie"]', 'a[href*="datenschutz-einstellungen"]',
|
|
'[class*="consent-settings"]', '#ot-sdk-btn',
|
|
'.cky-btn-revisit', '#CybotCookiebotDialogBodyButtonDetails',
|
|
'[data-testid="uc-footer-link"]',
|
|
]
|
|
for sel in settings_selectors:
|
|
try:
|
|
if await page.locator(sel).count() > 0:
|
|
settings_accessible = True
|
|
break
|
|
except Exception:
|
|
continue
|
|
|
|
# Also check footer for cookie settings link
|
|
if not settings_accessible:
|
|
footer_text = ""
|
|
try:
|
|
footer = page.locator("footer").first
|
|
if await footer.count() > 0:
|
|
footer_text = (await footer.text_content() or "").lower()
|
|
except Exception:
|
|
pass
|
|
if any(kw in footer_text for kw in ["cookie-einstellungen", "cookie settings",
|
|
"datenschutz-einstellungen", "privacy settings"]):
|
|
settings_accessible = True
|
|
|
|
if not settings_accessible:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="MEDIUM",
|
|
text="Kein erneuter Zugang zu Cookie-Einstellungen gefunden. "
|
|
"Der Widerruf der Einwilligung muss ebenso einfach sein wie "
|
|
"die Erteilung (Art. 7 Abs. 3 DSGVO).",
|
|
legal_ref="Art. 7 Abs. 3 DSGVO (Widerruf so einfach wie Einwilligung)",
|
|
))
|
|
except Exception:
|
|
pass
|
|
|
|
# Check 9: Third-party DSE link — consent links to external domain DSE
|
|
try:
|
|
page_domain = page.url.split("/")[2].replace("www.", "")
|
|
for link in banner_links:
|
|
href = link["href"]
|
|
if not href.startswith("http"):
|
|
continue
|
|
link_domain = href.split("/")[2].replace("www.", "") if len(href.split("/")) > 2 else ""
|
|
if not link_domain:
|
|
continue
|
|
is_dse_link = any(kw in link["text"] for kw in [
|
|
"datenschutz", "privacy", "dsgvo", "data protection",
|
|
])
|
|
if is_dse_link and link_domain != page_domain:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="HIGH",
|
|
text=f"Consent verweist auf Datenschutzerklaerung von {link_domain} "
|
|
f"statt auf eigene DSE. Der Verantwortliche muss eine eigene "
|
|
f"Datenschutzerklaerung bereitstellen (Art. 13 DSGVO). "
|
|
f"Ein Verweis auf die DSE eines Drittanbieters/Auftragsverarbeiters "
|
|
f"reicht nicht aus.",
|
|
legal_ref="Art. 13 DSGVO (Informationspflichten), Art. 26 DSGVO (gemeinsame Verantwortlichkeit)",
|
|
))
|
|
break
|
|
except Exception:
|
|
pass
|
|
|
|
# Check 10: Dark-Pattern language — "muessen/erforderlich" for non-essential
|
|
dark_pattern_phrases = [
|
|
("muessen heruntergeladen werden", "heruntergeladen"),
|
|
("muessen akzeptiert werden", "akzeptiert"),
|
|
("muessen gesetzt werden", "gesetzt"),
|
|
("cookies sind erforderlich", "erforderlich"),
|
|
("cookies are required", "required"),
|
|
("must be downloaded", "downloaded"),
|
|
("must be accepted", "accepted"),
|
|
("sind zwingend notwendig", "zwingend"),
|
|
("unbedingt erforderlich", "unbedingt"),
|
|
]
|
|
for phrase, keyword in dark_pattern_phrases:
|
|
if phrase in banner_lower:
|
|
# Check if context is about non-essential cookies
|
|
context_essential = any(kw in banner_lower for kw in [
|
|
"technisch notwendig", "essential", "strictly necessary",
|
|
"unbedingt erforderlich fuer den betrieb",
|
|
])
|
|
if not context_essential:
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="MEDIUM",
|
|
text=f"Dark-Pattern-Sprache: '{phrase}' suggeriert technische "
|
|
f"Notwendigkeit fuer nicht-essentielle Cookies. Nutzer koennten "
|
|
f"den Eindruck gewinnen, eine Zustimmung sei alternativlos.",
|
|
legal_ref="EDPB Guidelines 05/2020 Rn. 70, Art. 7(4) DSGVO (freiwillige Einwilligung)",
|
|
))
|
|
break
|
|
|
|
# Check 11: Modal dismiss = consent (click outside closes + sets consent)
|
|
try:
|
|
dismiss_is_consent = await page.evaluate("""
|
|
() => {
|
|
const dialog = document.querySelector(
|
|
'#CybotCookiebotDialog, #onetrust-banner-sdk, #didomi-host, '
|
|
+ '#usercentrics-root, .cky-consent-container, #cmpbox, '
|
|
+ '[class*="cookie-banner"], [class*="consent-banner"], [role="dialog"]'
|
|
);
|
|
if (!dialog) return { hasOverlay: false, overlayCloses: false };
|
|
// Check for overlay/backdrop elements
|
|
const overlays = document.querySelectorAll(
|
|
'.overlay, .backdrop, .modal-backdrop, '
|
|
+ '[class*="overlay"], [class*="backdrop"], '
|
|
+ '[class*="dimmer"], .cdk-overlay-backdrop'
|
|
);
|
|
let overlayHasClick = false;
|
|
for (const ov of overlays) {
|
|
const listeners = getEventListeners ? getEventListeners(ov) : {};
|
|
if (listeners.click && listeners.click.length > 0) {
|
|
overlayHasClick = true;
|
|
}
|
|
}
|
|
// Alternative: check if dialog is non-modal (no inert on background)
|
|
const isModal = dialog.getAttribute('aria-modal') === 'true' ||
|
|
dialog.hasAttribute('open');
|
|
return {
|
|
hasOverlay: overlays.length > 0,
|
|
overlayHasClick: overlayHasClick,
|
|
isModal: isModal,
|
|
dialogRole: dialog.getAttribute('role'),
|
|
};
|
|
}
|
|
""")
|
|
if dismiss_is_consent and dismiss_is_consent.get("hasOverlay") and not dismiss_is_consent.get("isModal"):
|
|
violations.append(Violation(
|
|
service="Cookie-Banner",
|
|
severity="HIGH",
|
|
text="Consent-Dialog ist nicht modal — Klick auf den Hintergrund kann "
|
|
"das Fenster schliessen und als Einwilligung gewertet werden. "
|
|
"Ein versehentlicher Klick ist keine aktive Einwilligung. "
|
|
"Der Dialog muss modal sein (nur explizite Buttons als Optionen).",
|
|
legal_ref="EuGH C-673/17 Planet49 (aktive Handlung), Art. 7(1) DSGVO (Nachweispflicht), "
|
|
"EDPB Guidelines 05/2020 Rn. 77 (silence/inactivity ≠ consent)",
|
|
))
|
|
except Exception:
|
|
pass
|
|
|
|
# ── Checks 12-20: Advanced checks ──────────────────────
|
|
try:
|
|
advanced = await run_advanced_checks(page, banner_text)
|
|
violations.extend(advanced)
|
|
except Exception as e:
|
|
logger.warning("Advanced banner checks failed: %s", e)
|
|
|
|
except Exception as e:
|
|
logger.warning("Banner text check failed: %s", e)
|
|
|
|
return {"violations": violations, "has_impressum": has_impressum, "has_dse": has_dse}
|