Files
breakpilot-compliance/admin-compliance/app/sdk/control-library/page.tsx
T
Benjamin Admin 662327e8b4
CI / nodejs-build (push) Successful in 2m47s
CI / branch-name (push) Has been skipped
CI / guardrail-integrity (push) Has been skipped
CI / detect-changes (push) Successful in 10s
CI / secret-scan (push) Has been skipped
CI / dep-audit (push) Has been skipped
CI / sbom-scan (push) Has been skipped
CI / validate-canonical-controls (push) Successful in 16s
CI / loc-budget (push) Failing after 17s
CI / go-lint (push) Has been skipped
CI / python-lint (push) Has been skipped
CI / nodejs-lint (push) Has been skipped
CI / test-python-backend (push) Successful in 42s
CI / test-python-document-crawler (push) Has been skipped
CI / test-go (push) Has been skipped
CI / iace-gt-coverage (push) Has been skipped
CI / test-python-dsms-gateway (push) Has been skipped
feat(compliance-check): MC-Classification + Embedding + Vendor-Redundanz + Action-Recipes + Borlabs-Features
Massiv-Update auf Basis BMW-Test-Iterationen (v1→v9):

Core Compliance-Check
- Sonnet check_type Klassifikation: text/process/review fuer alle 1874 MCs
  in compliance.doc_check_controls (script + Sidecar /data/mc_classification.db).
  rag_document_checker filtert auf check_type='text' fuer doc_check.
  Plus fits_doc_type-Audit (v2) + ui_only-Audit fuer DSA/E-Commerce-MCs in
  falscher doc_type-Schublade.
- scope_requires-Filter: biometric/ai_decision/child_targeting MCs werden
  per business_profile gefiltert (FRT skipped fuer BMW etc.).
- Embedding-Match (BGE-M3) als Phase-3 nach Regex-Match:
  Per-doc_type-Threshold-Override (impressum 0.50, dse/cookie 0.60),
  Short-Field-Rescue (15-Wort-Chunks) fuer Pflichtfelder im Impressum.
  Title+check_question als Embedding-Input fuer mehr Kontext.
- Cookie-Text-Routing: consent-tester gibt cmp_cookie_text aus dem
  CMP-Reconstruct zurueck, Backend bevorzugt das gegen DOM-Extraction
  wenn richer (BMW 1824 vs 600 Worte).

Vendor-Redundanz + EU-Alternativen + Cost-Saving
- vendor_redundancy.analyze() — funktionale Kategorisierung der CMP-Vendors,
  Detektion von Mehrfach-Anbietern pro Kategorie, EU-Alternative-Lookup
  (Matomo, IONOS, HERE, Friendly Captcha, Smart AdServer, ...).
- vendor_cost_estimator: Tier-Inferenz aus Cookie-Footprint (Cookie-Anzahl
  + Premium-Feature-Cookies + Third-Party-Quote → starter/professional/
  enterprise/premier).
- Self-Service-Werbung (Google/Meta/Pinterest/...) = 0 Lizenz-Kosten
  (nur Media-Spend, separat). DSP-Plattformen behalten enge Range.
- Tier-aware Saving-Range: bei Enterprise/Premier nutzen wir den
  oberen 40-100%-Band der Listpreise, nicht starter→premier.
- Multi-Function-Tools (Matomo Pro, SAP CX, IONOS Cloud, Userlike, Smart
  AdServer, HERE Maps, Vimeo Pro, LamaPoll) — ein Tool ersetzt mehrere
  Kategorien gleichzeitig.

Cookie-Wissens-DB + Funktionale Klassifikation
- cookie_knowledge_db: 50 kuratierte Top-Cookies (Google/Meta/Adobe/MS/...)
  mit vendor, exact_purpose, data_collected, IAB-TCF-IDs, reid_risk,
  schrems_ii_status, EuGH-Urteile, EU-Alternative.
- cookie_function_classifier: pro Cookie funktionale Rolle (tracking_id,
  ad_pixel, session_id, ab_test, csrf, ...) + blocking_impact.

Country-Inferenz aus Rechtsform
- cookie_link_validator: Country-Field wird aus Vendor-Name abgeleitet
  (A/S=DK, GmbH=DE, Inc=US, B.V.=NL, ...) plus Vendor-Lookup-Table.
  Reduziert false-positive no_country-Flags bei eindeutig-EU-Vendors
  (Adform DK, Pinterest IE).

Action-Recipes + Doc-Anchor-Locator
- finding_action_recipes: pro Finding-Typ (no_cookies_listed, no_country,
  broken_opt_out, "Auftragsverarbeiter erwaehnen", "Art. 22 Profiling",
  ...) eine strukturierte Anweisung mit what/why/fix_text/where/example.
  Zum 1:1-Einfuegen in Kunden-Dokumente.
- doc_anchor_locator: Embedding-basiert (BGE-M3 cosine) — sucht den
  passenden Absatz im existierenden Kundendokument fuer jeden Finding.
  Per-Run Thread-Local-Cache. Fallback: keyword-Match.
- Email-Rendering integriert Recipe + Anchor pro Doc-Pruefungs-Fail
  + Vendor-Flag-Liste mit aufklappbarer Action-Liste.
- Score-Erklaerung pro Vendor-Zeile (3/5-Untertitel + Tooltip).

Migration-Pipeline (Compliance-Check -> Customer Banner/Documents)
- migration_to_banner.py: Vendor-Liste -> CookieBannerConfig mit
  4 Kategorien + Review-Flags.
- migration_to_document.py: Vendor-Liste -> Cookie-Policy + VVT-Register
  + Privacy-Policy-Pre-Fills.
- agent_migration_routes: 3 Preview-Endpoints (banner-preview,
  document-preview, summary). Persistierung der cmp_vendors in
  /data/compliance_audits.db check_payloads-Tabelle.

Borlabs-Parity Cookie-Banner-Features
- Consent-Historie im Banner: window.bpShowConsentHistory() + localStorage.
- Content-Blocker: cookie-banner-content-blocker.ts — YouTube/Maps/Video
  Placeholder bis Einwilligung.
- Google Consent Mode v2 erweitert: wait_for_update + region=EEA/CH/GB.
- Consent-Log Export (CSV/JSON) per einwilligungen_export_routes.

Bug-Fixes
- canonical_control_routes: _jsonish-Helper fuer string-typed jsonb,
  similar-controls-Endpoint mit _has_embedding_col()-Cache (kein 500 mehr).
- Control-Library Frontend: defensive .map-Coercer in 2 Detail-Views.
- Embedding-Service-Batching (32er Batches statt 165 in einem Call).
- KeyError 'control_id' in MC-Result-Aggregation (defensive .get).
- Master-Controls-Klick-Through von /sdk/master-controls auf
  /sdk/control-library?control=<id> mit URL-Param-Auto-Open.
- Dockerfile: /data pre-chowned auf appuser (Audit-DB-Schreibrecht).
- Cookie-Text-Routing-Bug (cmp_reconstructed > DOM-extraction).
- doc_type-aware MC-Filter (statt all-text-MCs).
- Master-Contract-Dedup (60 BMW-Internal-Eintraege = 1 Adobe-Vertrag).
- A3-v2-Audit hat 24 UI-Sprache-MCs als 'process' reklassifiziert.

Tests
- test_migration_mappers.py (9 Tests)
- test_migration_endpoints.py (4 Tests)

Skripte (one-shot)
- classify_mc_check_type.py (v1) + _v2 (PK=control_id,doc_type)
- audit_mc_doctype_fit.py (v1 fits) + _v2 (ui_only + scope_requires)

BMW-Run-Bilanz v1 (broken) -> v9 (alle Fixes):
  DSE     7,5% -> 81-83%
  Impressum 4%   -> 100% (6 echte MCs alle erfuellt)
  Cookie  0%    -> 79-83% (CMP-Text-Routing + Embedding)
  Plus: 10 Konsolidierungs-Kategorien, geschaetzte Saving 200k-3M / Jahr
  Plus: Action-Recipes + Doc-Anchors fuer jeden Fail

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 18:30:08 +02:00

266 lines
10 KiB
TypeScript

'use client'
import { useEffect } from 'react'
import { useSearchParams } from 'next/navigation'
import { EMPTY_CONTROL } from './components/helpers'
import { ControlForm } from './components/ControlForm'
import { ControlDetail } from './components/ControlDetail'
import { ReviewCompare } from './components/ReviewCompare'
import { V1CompareView } from './components/V1CompareView'
import { ControlListView } from './components/ControlListView'
import { useControlLibraryState } from './components/useControlLibraryState'
import { createCRUDHandlers } from './components/useControlCRUD'
import { BACKEND_URL } from './components/helpers'
export default function ControlLibraryPage() {
const state = useControlLibraryState()
const searchParams = useSearchParams()
// Deep-link via /sdk/control-library?control=<id>
// — e.g. from /sdk/master-controls member list.
useEffect(() => {
const cid = searchParams?.get('control')
if (!cid || state.selectedControl?.control_id === cid) return
fetch(`${BACKEND_URL}?endpoint=control&id=${encodeURIComponent(cid)}`)
.then(r => r.ok ? r.json() : null)
.then(ctrl => {
if (ctrl?.control_id) {
state.setSelectedControl(ctrl)
state.setMode('detail')
}
})
.catch(() => { /* user just sees the list */ })
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [searchParams])
const {
handleCreate, handleUpdate, handleDelete, handleReview, handleBulkReject,
} = createCRUDHandlers({
selectedControl: state.selectedControl,
fullReload: state.fullReload,
reviewMode: state.reviewMode,
reviewIndex: state.reviewIndex,
reviewItems: state.reviewItems,
setMode: state.setMode,
setSelectedControl: state.setSelectedControl,
setReviewMode: state.setReviewMode,
setReviewItems: state.setReviewItems,
setReviewIndex: state.setReviewIndex,
setSaving: state.setSaving,
setBulkProcessing: state.setBulkProcessing,
reviewCount: state.reviewCount,
totalCount: state.totalCount,
stateFilter: state.stateFilter,
})
// Loading / error screens
if (state.loading && state.controls.length === 0) {
return (
<div className="flex items-center justify-center h-96">
<div className="animate-spin rounded-full h-8 w-8 border-2 border-purple-600 border-t-transparent" />
</div>
)
}
if (state.error) {
return (
<div className="flex items-center justify-center h-96">
<p className="text-red-600">{state.error}</p>
</div>
)
}
// CREATE mode
if (state.mode === 'create') {
return <ControlForm initial={EMPTY_CONTROL} onSave={handleCreate} onCancel={() => state.setMode('list')} saving={state.saving} />
}
// EDIT mode
if (state.mode === 'edit' && state.selectedControl) {
return (
<ControlForm
initial={{
...EMPTY_CONTROL,
...state.selectedControl,
scope: {
platforms: state.selectedControl.scope?.platforms ?? [],
components: state.selectedControl.scope?.components ?? [],
data_classes: state.selectedControl.scope?.data_classes ?? [],
},
target_audience: Array.isArray(state.selectedControl.target_audience)
? state.selectedControl.target_audience.join(', ')
: state.selectedControl.target_audience,
risk_score: state.selectedControl.risk_score,
implementation_effort: state.selectedControl.implementation_effort,
open_anchors: state.selectedControl.open_anchors.length > 0
? state.selectedControl.open_anchors
: [{ framework: '', ref: '', url: '' }],
requirements: state.selectedControl.requirements.length > 0 ? state.selectedControl.requirements : [''],
test_procedure: state.selectedControl.test_procedure.length > 0 ? state.selectedControl.test_procedure : [''],
evidence: state.selectedControl.evidence.length > 0
? state.selectedControl.evidence.map(e => typeof e === 'string' ? { type: '', description: e } : e)
: [{ type: '', description: '' }],
}}
onSave={handleUpdate}
onCancel={() => state.setMode('detail')}
saving={state.saving}
/>
)
}
// V1 COMPARE mode
if (state.compareMode && state.compareV1Control) {
return (
<V1CompareView
v1Control={state.compareV1Control}
matches={state.compareMatches}
onBack={() => state.setCompareMode(false)}
onNavigateToControl={async (controlId: string) => {
try {
const res = await fetch(`${BACKEND_URL}?endpoint=control&id=${controlId}`)
if (res.ok) { state.setCompareMode(false); state.setSelectedControl(await res.json()); state.setMode('detail') }
} catch { /* ignore */ }
}}
/>
)
}
// DETAIL mode
if (state.mode === 'detail' && state.selectedControl) {
const isDuplicateReview = state.reviewMode && state.reviewTab === 'duplicates'
const reviewTabBar = state.reviewMode ? (
<div className="border-b border-gray-200 bg-white px-6 py-2 flex items-center gap-4">
<button
onClick={() => state.switchReviewTab('duplicates')}
className={`px-3 py-1.5 text-sm rounded-lg font-medium ${state.reviewTab === 'duplicates' ? 'bg-amber-100 text-amber-800 border border-amber-300' : 'text-gray-500 hover:text-gray-700 hover:bg-gray-100'}`}
>
Duplikat-Verdacht ({state.reviewDuplicates.length})
</button>
<button
onClick={() => state.switchReviewTab('rule3')}
className={`px-3 py-1.5 text-sm rounded-lg font-medium ${state.reviewTab === 'rule3' ? 'bg-purple-100 text-purple-800 border border-purple-300' : 'text-gray-500 hover:text-gray-700 hover:bg-gray-100'}`}
>
Rule 3 ohne Anchor ({state.reviewRule3.length})
</button>
</div>
) : null
const reviewNavProps = {
reviewMode: state.reviewMode,
reviewIndex: state.reviewIndex,
reviewTotal: state.reviewItems.length,
onReviewPrev: () => {
const idx = Math.max(0, state.reviewIndex - 1)
state.setReviewIndex(idx)
state.setSelectedControl(state.reviewItems[idx])
},
onReviewNext: () => {
const idx = Math.min(state.reviewItems.length - 1, state.reviewIndex + 1)
state.setReviewIndex(idx)
state.setSelectedControl(state.reviewItems[idx])
},
}
if (isDuplicateReview) {
return (
<div className="flex flex-col h-full">
{reviewTabBar}
<div className="flex-1 overflow-hidden">
<ReviewCompare
ctrl={state.selectedControl}
onBack={() => { state.setMode('list'); state.setSelectedControl(null); state.setReviewMode(false) }}
onReview={handleReview}
onEdit={() => state.setMode('edit')}
reviewIndex={state.reviewIndex}
reviewTotal={state.reviewItems.length}
onReviewPrev={reviewNavProps.onReviewPrev}
onReviewNext={reviewNavProps.onReviewNext}
/>
</div>
</div>
)
}
return (
<div className="flex flex-col h-full">
{reviewTabBar}
<div className="flex-1 overflow-hidden">
<ControlDetail
ctrl={state.selectedControl}
onBack={() => { state.setMode('list'); state.setSelectedControl(null); state.setReviewMode(false) }}
onEdit={() => state.setMode('edit')}
onDelete={handleDelete}
onReview={handleReview}
onRefresh={state.fullReload}
onCompare={(ctrl, matches) => { state.setCompareV1Control(ctrl); state.setCompareMatches(matches); state.setCompareMode(true) }}
onNavigateToControl={async (controlId: string) => {
try {
const res = await fetch(`${BACKEND_URL}?endpoint=control&id=${controlId}`)
if (res.ok) { state.setSelectedControl(await res.json()); state.setMode('detail') }
} catch { /* ignore */ }
}}
reviewMode={state.reviewMode}
reviewIndex={state.reviewIndex}
reviewTotal={state.reviewItems.length}
onReviewPrev={reviewNavProps.onReviewPrev}
onReviewNext={reviewNavProps.onReviewNext}
/>
</div>
</div>
)
}
// LIST mode
return (
<ControlListView
frameworks={state.frameworks}
controls={state.controls}
totalCount={state.totalCount}
meta={state.meta}
loading={state.loading}
reviewCount={state.reviewCount}
bulkProcessing={state.bulkProcessing}
showStats={state.showStats}
processedStats={state.processedStats}
showGenerator={state.showGenerator}
currentPage={state.currentPage}
totalPages={state.totalPages}
sortBy={state.sortBy}
searchQuery={state.searchQuery}
severityFilter={state.severityFilter}
domainFilter={state.domainFilter}
stateFilter={state.stateFilter}
verificationFilter={state.verificationFilter}
categoryFilter={state.categoryFilter}
evidenceTypeFilter={state.evidenceTypeFilter}
audienceFilter={state.audienceFilter}
sourceFilter={state.sourceFilter}
typeFilter={state.typeFilter}
hideDuplicates={state.hideDuplicates}
setSearchQuery={state.setSearchQuery}
setSeverityFilter={state.setSeverityFilter}
setDomainFilter={state.setDomainFilter}
setStateFilter={state.setStateFilter}
setVerificationFilter={state.setVerificationFilter}
setCategoryFilter={state.setCategoryFilter}
setEvidenceTypeFilter={state.setEvidenceTypeFilter}
setAudienceFilter={state.setAudienceFilter}
setSourceFilter={state.setSourceFilter}
setTypeFilter={state.setTypeFilter}
setHideDuplicates={state.setHideDuplicates}
setSortBy={state.setSortBy}
setShowStats={state.setShowStats}
setShowGenerator={state.setShowGenerator}
setCurrentPage={state.setCurrentPage}
onSelectControl={(ctrl) => { state.setSelectedControl(ctrl); state.setMode('detail') }}
onCreateMode={() => state.setMode('create')}
onEnterReview={state.enterReviewMode}
onBulkReject={handleBulkReject}
onRefresh={() => { state.loadControls(); state.loadMeta(); state.loadFrameworks(); state.loadReviewCount() }}
onLoadStats={state.loadProcessedStats}
onFullReload={state.fullReload}
/>
)
}