Sharang Parnerkar 0c2e03f294 refactor(backend/api): extract Email Template services (Step 4 — file 10 of 18) ...

compliance/api/email_template_routes.py (823 LOC) -> 295 LOC thin routes
+ 402-line EmailTemplateService + 241-line EmailTemplateVersionService +
61-line schemas file.

Two-service split along natural responsibility seam:

  email_template_service.py (402 LOC):
    - Template type catalog (TEMPLATE_TYPES constant)
    - Template CRUD (list, create, get)
    - Stats, settings, send logs, initialization, default content
    - Shared _template_to_dict / _version_to_dict / _render_template helpers

  email_template_version_service.py (241 LOC):
    - Version CRUD (create, list, get, update)
    - Workflow transitions (submit, approve, reject, publish)
    - Preview and test-send

TEMPLATE_TYPES, VALID_CATEGORIES, VALID_STATUSES re-exported from the
route module for any legacy consumers.

State-transition errors use ValidationError (-> HTTPException 400) to
preserve the original handler's 400 status for "Only draft/review
versions can be ..." checks, since the existing TestClient integration
tests (47 tests) assert status_code == 400.

Verified:
  - 47/47 tests/test_email_template_routes.py pass
  - OpenAPI 360/484 unchanged
  - mypy compliance/ -> Success on 138 source files
  - email_template_routes.py 823 -> 295 LOC
  - Hard-cap violations: 9 -> 8

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-04-08 22:39:19 +02:00

..

contracts

refactor(backend/api): extract Email Template services (Step 4 — file 10 of 18)

2026-04-08 22:39:19 +02:00

__init__.py

…

test_audit_routes_integration.py

tech-debt: mypy --strict config + integration tests for audit routes

2026-04-07 18:39:40 +02:00

test_banner_routes.py

feat: Consent-Service Module nach Compliance migriert (DSR, E-Mail-Templates, Legal Docs, Banner)

2026-03-05 00:36:24 +01:00

test_canonical_control_routes.py

feat(canonical-controls): Canonical Control Library — rechtssichere Security Controls

2026-03-12 19:55:06 +01:00

test_change_request_routes.py

feat(sdk): Multi-Tenancy, Versionierung, Change-Requests, Dokumentengenerierung (Phase 1-6)

2026-03-07 14:12:34 +01:00

test_company_profile_extend.py

feat(sdk): Multi-Tenancy, Versionierung, Change-Requests, Dokumentengenerierung (Phase 1-6)

2026-03-07 14:12:34 +01:00

test_company_profile_routes.py

fix(quality): Ruff/CVE/TS-Fixes, 104 neue Tests, Complexity-Refactoring

2026-03-07 19:00:33 +01:00

test_compliance_scope_routes.py

feat: Vorbereitung-Module auf 100% — Compliance-Scope Backend, DELETE-Endpoints, Proxy-Fixes, blocked-content Tab

2026-03-04 17:43:29 +01:00

test_consent_template_routes.py

feat: Betrieb-Module → 100% — Echte CRUD-Flows, kein Mock-Data

2026-03-03 12:48:43 +01:00

test_control_generator.py

feat(control-generator): 7-stage pipeline for RAG→LLM→Controls generation

2026-03-13 09:03:37 +01:00

test_control_routes.py

feat(compliance-kern): Tests, MkDocs + RAG-Controls Button für Anforderungen/Controls/Nachweise/Risiken

2026-03-05 13:43:02 +01:00

test_document_versions.py

feat(sdk): Multi-Tenancy, Versionierung, Change-Requests, Dokumentengenerierung (Phase 1-6)

2026-03-07 14:12:34 +01:00

test_dsfa_routes.py

refactor: phase 0 guardrails + phase 1 step 2 (models.py split)

2026-04-07 13:18:29 +02:00

test_dsr_routes.py

refactor: phase 0 guardrails + phase 1 step 2 (models.py split)

2026-04-07 13:18:29 +02:00

test_einwilligungen_routes.py

refactor: phase 0 guardrails + phase 1 step 2 (models.py split)

2026-04-07 13:18:29 +02:00

test_email_template_routes.py

feat: Consent-Service Module nach Compliance migriert (DSR, E-Mail-Templates, Legal Docs, Banner)

2026-03-05 00:36:24 +01:00

test_escalation_routes.py

feat(sdk): API-Referenz Frontend + Backend-Konsolidierung (Shared Utilities, CRUD Factory)

2026-03-07 17:07:43 +01:00

test_evidence_routes.py

fix(quality): Ruff/CVE/TS-Fixes, 104 neue Tests, Complexity-Refactoring

2026-03-07 19:00:33 +01:00

test_extraction_routes.py

feat(extraction): POST /compliance/extract-requirements-from-rag

2026-03-05 15:11:10 +01:00

test_generation_routes.py

fix(quality): Ruff/CVE/TS-Fixes, 104 neue Tests, Complexity-Refactoring

2026-03-07 19:00:33 +01:00

test_import_routes.py

fix(import+screening): GET-Alias, DELETE-Endpoint, ehrlicher Scan-Status

2026-03-05 12:07:01 +01:00

test_incident_routes.py

feat(incidents): Go Incidents nach Python migrieren, Proxy umleiten, 50 Tests

2026-03-06 20:50:00 +01:00

test_isms_routes.py

refactor: phase 0 guardrails + phase 1 step 2 (models.py split)

2026-04-07 13:18:29 +02:00

test_legal_document_routes_extended.py

refactor: phase 0 guardrails + phase 1 step 2 (models.py split)

2026-04-07 13:18:29 +02:00

test_legal_document_routes.py

refactor: phase 0 guardrails + phase 1 step 2 (models.py split)

2026-04-07 13:18:29 +02:00

test_legal_template_routes.py

feat(sdk): API-Referenz Frontend + Backend-Konsolidierung (Shared Utilities, CRUD Factory)

2026-03-07 17:07:43 +01:00

test_license_gate.py

feat(canonical-controls): Canonical Control Library — rechtssichere Security Controls

2026-03-12 19:55:06 +01:00

test_loeschfristen_routes.py

feat(sdk): API-Referenz Frontend + Backend-Konsolidierung (Shared Utilities, CRUD Factory)

2026-03-07 17:07:43 +01:00

test_module_routes.py

feat(freigabe): Import/Screening/Modules/RAG — API-Tests, Migration 031, Bug-Fix

2026-03-05 11:42:19 +01:00

test_notfallplan_routes.py

feat: Alle 5 verbleibenden SDK-Module auf 100% — RAG, Security-Backlog, Quality, Notfallplan, Loeschfristen

2026-03-03 18:04:53 +01:00

test_obligation_routes.py

feat(sdk): API-Referenz Frontend + Backend-Konsolidierung (Shared Utilities, CRUD Factory)

2026-03-07 17:07:43 +01:00

test_project_routes.py

feat(sdk): Multi-Projekt-Architektur — mehrere Projekte pro Tenant

2026-03-09 14:53:50 +01:00

test_quality_routes.py

feat(sdk): API-Referenz Frontend + Backend-Konsolidierung (Shared Utilities, CRUD Factory)

2026-03-07 17:07:43 +01:00

test_rag_client.py

…

test_requirement_routes.py

feat(compliance-kern): Tests, MkDocs + RAG-Controls Button für Anforderungen/Controls/Nachweise/Risiken

2026-03-05 13:43:02 +01:00

test_risk_routes.py

feat(compliance-kern): Tests, MkDocs + RAG-Controls Button für Anforderungen/Controls/Nachweise/Risiken

2026-03-05 13:43:02 +01:00

test_routes_legal_context.py

…

test_screening_routes.py

feat(freigabe): Import/Screening/Modules/RAG — API-Tests, Migration 031, Bug-Fix

2026-03-05 11:42:19 +01:00

test_security_backlog_routes.py

feat(sdk): API-Referenz Frontend + Backend-Konsolidierung (Shared Utilities, CRUD Factory)

2026-03-07 17:07:43 +01:00

test_source_policy_routes.py

…

test_tom_routes.py

feat(tom): TOM-Backend in Python erstellen, Frontend von In-Memory auf DB migrieren

2026-03-06 17:35:44 +01:00

test_validate_controls.py

feat(canonical-controls): Canonical Control Library — rechtssichere Security Controls

2026-03-12 19:55:06 +01:00

test_vendor_compliance_routes.py

refactor: phase 0 guardrails + phase 1 step 2 (models.py split)

2026-04-07 13:18:29 +02:00

test_vvt_routes.py

refactor: phase 0 guardrails + phase 1 step 2 (models.py split)

2026-04-07 13:18:29 +02:00

test_vvt_tenant_isolation.py

refactor: phase 0 guardrails + phase 1 step 2 (models.py split)

2026-04-07 13:18:29 +02:00