ci(go-lint): golangci-lint v1.64.8 (go1.24) + new-from-merge-base #32

Merged

Benjamin_Boenisch merged 1 commits from fix/ci-golangci-go124 into main 2026-06-23 10:58:49 +00:00

Conversation 0 Commits 1 Files Changed 2

+8 -7

Benjamin_Boenisch commented 2026-06-23 10:45:47 +00:00

Owner

Copy Link

Copy Source

Summary

The go-lint job failed on every PR — golangci-lint v1.62-alpine is built with go1.23 and refuses to load a go1.24.0 module config (language version go1.23 lower than targeted 1.24.0), so it never actually linted. This fixes the toolchain + config and touches only CI config files.

• container v1.62-alpine -> v1.64.8-alpine (built with go1.24.1)
• the revive exported rule used the old map-argument form, which v1.64 rejects (expecting a string, got map) -> string form (disableStutteringCheck)
• the first real golangci run surfaces ~15 pre-existing findings in unrelated packages (academy / whistleblower / iace / training + a few tests). Switch issues.new false -> new-from-merge-base main so only newly changed lines fail CI (the config already anticipated this: Remove this once a clean baseline is established)
• new-from-merge-base needs the merge base, so the go-lint checkout now does a full clone (local main ref) instead of a shallow single-branch clone

Test plan

• Verified locally with golangci-lint v1.64.8: a clean branch over main lints to 0 issues (pre-existing debt ignored) and the config loads without error
• go-lint green on the next PR after this merges

Note: this PR's own go-lint may still run the old (main) workflow and report the pre-existing failure; the fix only takes effect for subsequent PRs after merge.

## Summary The go-lint job failed on every PR — golangci-lint v1.62-alpine is built with go1.23 and refuses to load a go1.24.0 module config (language version go1.23 lower than targeted 1.24.0), so it never actually linted. This fixes the toolchain + config and touches only CI config files. - container v1.62-alpine -> v1.64.8-alpine (built with go1.24.1) - the revive exported rule used the old map-argument form, which v1.64 rejects (expecting a string, got map) -> string form (disableStutteringCheck) - the first real golangci run surfaces ~15 pre-existing findings in unrelated packages (academy / whistleblower / iace / training + a few tests). Switch issues.new false -> new-from-merge-base main so only newly changed lines fail CI (the config already anticipated this: Remove this once a clean baseline is established) - new-from-merge-base needs the merge base, so the go-lint checkout now does a full clone (local main ref) instead of a shallow single-branch clone ## Test plan - [x] Verified locally with golangci-lint v1.64.8: a clean branch over main lints to 0 issues (pre-existing debt ignored) and the config loads without error - [ ] go-lint green on the next PR after this merges Note: this PR's own go-lint may still run the old (main) workflow and report the pre-existing failure; the fix only takes effect for subsequent PRs after merge.

Benjamin_Boenisch added 1 commit 2026-06-23 10:45:47 +00:00

ci(go-lint): golangci-lint v1.64.8 (go1.24) + new-from-merge-base ... b5f7cc9e9b

go-lint failed on every PR: golangci-lint v1.62-alpine is built with go1.23 and
refuses to load a go1.24.0 module's config ("language version go1.23 lower than
targeted 1.24.0"), so it never actually linted.

- container v1.62-alpine -> v1.64.8-alpine (built with go1.24.1)
- revive `exported` used the old map-argument form, which v1.64 rejects
  ("expecting a string, got map") -> string form (disableStutteringCheck)
- running golangci for the first time surfaces ~15 pre-existing findings in
  unrelated packages (academy/whistleblower/iace/training + a few tests);
  switch issues.new:false -> new-from-merge-base:main so only newly changed
  lines fail (the config already anticipated this)
- new-from-merge-base needs the merge base -> go-lint checkout now does a full
  clone (local `main` ref) instead of a shallow single-branch clone

Verified locally with v1.64.8: a clean branch over main lints to 0 issues
(pre-existing debt ignored), config loads cleanly. Touches only CI config.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Benjamin_Boenisch merged commit b83c3e6e00 into main 2026-06-23 10:58:49 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

config

Env vars, secrets management, startup validation

data-integrity

Transactions, indexes, pagination

frontend

Next.js, client-side concerns

observability

Logging, audit trails, health checks

reliability

Error handling, retries, circuit breakers

security

Auth, secrets, injection, tenant isolation

severity: critical

System-level risk, data breach or full outage

severity: high

Significant risk, must fix before go-live

severity: medium

Important but not blocking go-live

testing

Test coverage, integration tests

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

sharang (Sharang Parnerkar) Benjamin_Boenisch

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Benjamin_Boenisch/breakpilot-compliance#32