Benjamin_Boenisch/breakpilot-compliance
1
0
Fork 0
Code Issues 24 Pull Requests Actions Packages Projects Releases Wiki Activity

Improve Go SDK test coverage: audit trail and LLM fallback paths #23

New Issue
Open
opened 2026-04-20 09:37:18 +00:00 by sharang · 0 comments
sharang commented 2026-04-20 09:37:18 +00:00
Owner
Copy Link
Copy Source

Problem

ai-compliance-sdk has handler and service code but sparse test coverage:

  • Audit trail validation logic has no table-driven tests
  • LLM fallback path (when primary model is unavailable) is untested
  • CI reports coverage but no gate enforces the 80% target in service/

Required Actions

  1. Add table-driven tests for audit trail service: internal/service/audit/audit_service_test.go
  2. Add tests for LLM provider fallback: mock primary as unavailable, assert secondary is tried
  3. Add go test -coverprofile=coverage.out ./... gate: fail CI if coverage drops below 80% on internal/service/
  4. Ensure handler tests use httptest.NewRecorder per AGENTS.go.md

Acceptance Criteria

  • go tool cover -func=coverage.out shows ≥80% on internal/service/
  • CI fails on coverage regression
  • At least 5 new table-driven test cases added
## Problem `ai-compliance-sdk` has handler and service code but sparse test coverage: - Audit trail validation logic has no table-driven tests - LLM fallback path (when primary model is unavailable) is untested - CI reports coverage but no gate enforces the 80% target in `service/` ## Required Actions 1. Add table-driven tests for audit trail service: `internal/service/audit/audit_service_test.go` 2. Add tests for LLM provider fallback: mock primary as unavailable, assert secondary is tried 3. Add `go test -coverprofile=coverage.out ./...` gate: fail CI if coverage drops below 80% on `internal/service/` 4. Ensure handler tests use `httptest.NewRecorder` per AGENTS.go.md ## Acceptance Criteria - `go tool cover -func=coverage.out` shows ≥80% on `internal/service/` - CI fails on coverage regression - At least 5 new table-driven test cases added
sharang added this to the M4: Testing & Contract Stability milestone 2026-04-20 09:37:18 +00:00
sharang added the testingseverity: medium labels 2026-04-20 09:37:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
config
Env vars, secrets management, startup validation
 data-integrity
Transactions, indexes, pagination
 frontend
Next.js, client-side concerns
 observability
Logging, audit trails, health checks
 reliability
Error handling, retries, circuit breakers
 security
Auth, secrets, injection, tenant isolation
 severity: critical
System-level risk, data breach or full outage
 severity: high
Significant risk, must fix before go-live
 severity: medium
Important but not blocking go-live
 testing
Test coverage, integration tests
No Label severity: medium testing
Milestone
No items
No Milestone M4: Testing & Contract Stability
Projects
Clear projects
No project
Assignees
Clear assignees
sharang (Sharang Parnerkar) Benjamin_Boenisch
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Benjamin_Boenisch/breakpilot-compliance#23
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?