refactor(backend/api): split schemas.py into per-domain modules (1899 -> 39 LOC shim)
Phase 1 Step 3 of PHASE1_RUNBOOK.md. compliance/api/schemas.py is
decomposed into 16 per-domain Pydantic schema modules under
compliance/schemas/:
common.py ( 79) — 6 API enums + PaginationMeta
regulation.py ( 52)
requirement.py ( 80)
control.py (119) — Control + Mapping
evidence.py ( 66)
risk.py ( 79)
ai_system.py ( 63)
dashboard.py (195) — Dashboard, Export, Executive Dashboard
service_module.py (121)
bsi.py ( 58) — BSI + PDF extraction
audit_session.py (172)
report.py ( 53)
isms_governance.py (343) — Scope, Context, Policy, Objective, SoA
isms_audit.py (431) — Finding, CAPA, Review, Internal Audit, Readiness, Trail, ISO27001
vvt.py (168)
tom.py ( 71)
compliance/api/schemas.py becomes a 39-line re-export shim so existing
imports (from compliance.api.schemas import RegulationResponse) keep
working unchanged. New code should import from the domain module
directly (from compliance.schemas.regulation import RegulationResponse).
Deferred-from-sweep: all 28 class Config blocks in the original file
were converted to model_config = ConfigDict(...) during the split.
schemas.py-sourced PydanticDeprecatedSince20 warnings are now gone.
Cross-domain references handled via targeted imports (e.g. dashboard.py
imports EvidenceResponse from evidence, RiskResponse from risk). common
API enums + PaginationMeta are imported by every domain module.
Verified:
- 173/173 pytest compliance/tests/ tests/contracts/ pass
- OpenAPI 360 paths / 484 operations unchanged (contract test green)
- All new files under the 500-line hard cap (largest: isms_audit.py
at 431, isms_governance.py at 343, dashboard.py at 195)
- No file in compliance/schemas/ or compliance/api/schemas.py
exceeds the hard cap
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
79
backend-compliance/compliance/schemas/risk.py
Normal file
79
backend-compliance/compliance/schemas/risk.py
Normal file
@@ -0,0 +1,79 @@
|
||||
"""
|
||||
Risk Pydantic schemas — extracted from compliance/api/schemas.py.
|
||||
|
||||
Phase 1 Step 3: the monolithic ``compliance.api.schemas`` module is being
|
||||
split per domain under ``compliance.schemas``. This module is re-exported
|
||||
from ``compliance.api.schemas`` for backwards compatibility.
|
||||
"""
|
||||
|
||||
from datetime import datetime, date
|
||||
from typing import Optional, List, Any, Dict
|
||||
|
||||
from pydantic import BaseModel, ConfigDict, Field
|
||||
|
||||
from compliance.schemas.common import (
|
||||
PaginationMeta, RegulationType, ControlType, ControlDomain,
|
||||
ControlStatus, RiskLevel, EvidenceStatus,
|
||||
)
|
||||
|
||||
|
||||
# ============================================================================
|
||||
# Risk Schemas
|
||||
# ============================================================================
|
||||
|
||||
class RiskBase(BaseModel):
|
||||
risk_id: str
|
||||
title: str
|
||||
description: Optional[str] = None
|
||||
category: str
|
||||
likelihood: int = Field(ge=1, le=5)
|
||||
impact: int = Field(ge=1, le=5)
|
||||
mitigating_controls: Optional[List[str]] = None
|
||||
owner: Optional[str] = None
|
||||
treatment_plan: Optional[str] = None
|
||||
|
||||
|
||||
class RiskCreate(RiskBase):
|
||||
pass
|
||||
|
||||
|
||||
class RiskUpdate(BaseModel):
|
||||
title: Optional[str] = None
|
||||
description: Optional[str] = None
|
||||
category: Optional[str] = None
|
||||
likelihood: Optional[int] = Field(default=None, ge=1, le=5)
|
||||
impact: Optional[int] = Field(default=None, ge=1, le=5)
|
||||
residual_likelihood: Optional[int] = Field(default=None, ge=1, le=5)
|
||||
residual_impact: Optional[int] = Field(default=None, ge=1, le=5)
|
||||
mitigating_controls: Optional[List[str]] = None
|
||||
owner: Optional[str] = None
|
||||
status: Optional[str] = None
|
||||
treatment_plan: Optional[str] = None
|
||||
|
||||
|
||||
class RiskResponse(RiskBase):
|
||||
id: str
|
||||
inherent_risk: str
|
||||
residual_likelihood: Optional[int] = None
|
||||
residual_impact: Optional[int] = None
|
||||
residual_risk: Optional[str] = None
|
||||
status: str
|
||||
identified_date: Optional[date] = None
|
||||
review_date: Optional[date] = None
|
||||
last_assessed_at: Optional[datetime] = None
|
||||
created_at: datetime
|
||||
updated_at: datetime
|
||||
|
||||
model_config = ConfigDict(from_attributes=True)
|
||||
|
||||
|
||||
class RiskListResponse(BaseModel):
|
||||
risks: List[RiskResponse]
|
||||
total: int
|
||||
|
||||
|
||||
class RiskMatrixResponse(BaseModel):
|
||||
"""Risk matrix data for visualization."""
|
||||
matrix: Dict[str, Dict[str, List[str]]] # likelihood -> impact -> risk_ids
|
||||
risks: List[RiskResponse]
|
||||
|
||||
Reference in New Issue
Block a user