fix(onboarding): decouple partial/indicative signals from detected — partial no longer removes a question
Fix B of the pre-#59 semantic correction. The Silent Pass had only TWO effective states though the data
carries three: a `detected` mapping (a concrete artifact) AND a `partial` mapping (an indicative signal,
e.g. a CI pipeline -> secure-development-lifecycle) both flowed through capability_ids() and were fed to
the Advisor as already-present — so a weak indication silently removed a question, exactly the Welt-1/
Welt-2 transparency we want to keep.
Now three distinct states:
- detected -> reduces the delta immediately (auto_detected, not asked). [unchanged]
- partial -> raises assumption strength but does NOT replace the question (surfaced as `indications`,
the capability stays in the delta and is still asked).
- requirement-> describes a target, never the present state (already handled by Fix A's kind split).
Changes (data + thin wiring, no new architecture):
- SilentIntakeResult.capability_ids() returns only relationship==detected; new indicative_capability_ids()
returns the partial ones.
- advisor_start() gains indicative_capabilities (NOT fed into the profile) and surfaces result.indications
= indicative ∩ required − auto_detected.
- AdvisorResult / AdvisorResponse gain `indications` (additive, contract-safe); the service passes the
indicative ids through.
Tests: a partial CI signal is indicative-not-detected and does NOT shrink the delta; end-to-end it appears
in `indications`, not `auto_detected`, and the gap is still asked. 28 onboarding tests pass, mypy --strict
clean on the onboarding modules, demo runs, check-loc 0. Runtime effect -> deploy + smoke.
This commit is contained in:
@@ -66,10 +66,15 @@ class SilentIntakeResult(BaseModel):
|
||||
summary: str = ""
|
||||
|
||||
def capability_ids(self) -> List[str]:
|
||||
"""The detected capability ids — fed into the Advisor as already-present (delta-reducing).
|
||||
"""The DETECTED capability ids (relationship == detected) — fed into the Advisor as already-present
|
||||
(delta-reducing, not asked). ONLY observation-kind signals reach here (requirements never become a
|
||||
present capability); a merely PARTIAL/indicative signal does NOT (see indicative_capability_ids)."""
|
||||
return sorted({d.capability for d in self.detected_capabilities if d.relationship == "detected"})
|
||||
|
||||
ONLY observation-kind signals reach here (requirements never become a present capability)."""
|
||||
return sorted({d.capability for d in self.detected_capabilities})
|
||||
def indicative_capability_ids(self) -> List[str]:
|
||||
"""Capabilities backed only by a PARTIAL/indicative signal — they raise assumption strength but do
|
||||
NOT replace a question (the gap stays open and is still asked, just with an indication shown)."""
|
||||
return sorted({d.capability for d in self.detected_capabilities if d.relationship != "detected"})
|
||||
|
||||
|
||||
def silent_intake(
|
||||
|
||||
Reference in New Issue
Block a user