Benjamin_Boenisch/breakpilot-compliance
1
0
Fork 0
Code Issues 24 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(iace): set-based measure-category filter + 235 pattern-author fixes

Browse Source 
Two-part nachhaltiger fix replacing the previous "fill to 5 mitigations
no matter what" behavior that the GT-Bremse benchmark proved
unfaithful (e.g. HP1625 "scharfe Kanten" returning M005 "Rotations-
bewegung vermeiden" via category fallback; HP1651 "Wiederanlauf
Roboter" returning M054 "Sichere thermische Auslegung" via
mismatched pattern reference).

PART A — Set-based category filter (handlers package):
- acceptableMeasureCategories: replaces 1:1 patternCatToMeasureCat
  with a curated set per pattern category, so e.g.
  safety_function_failure now accepts software_control measures
  (watchdogs, plausibility checks) and emc_hazard accepts both
  electrical and software_control measures
- isCategoryCompatible: gate every measure id against the accepted
  set before creating a mitigation; mismatches log MEASURE-SKIP
- The old category fallback is REMOVED. A hazard whose pattern has
  no category-compatible measure is now created with zero mitigations
  and logged as COVERAGE-GAP — the operator must consult an expert.
  No more silent invention of generic defaults.

PART B — 235 pattern author-error fixes across 26 files:
- HP040-HP044 (AI): M101/M102/M103 (Auffangwanne/Absauganlage) ->
  M133 Anomalieerkennung + M214 Plausibilitaet + M213 Sensor-Redundanz
  + M044 Zweikanalige Steuerung + others
- HP011-HP015, HP104-HP109, HP1085-HP1095, HP1281-HP1334 (electrical):
  M001-M005/M054/M061 placeholders -> M481/M482 Isolation +
  M511-M522 PE/Schutzleiter/RCD/Hauptschalter
- HP110-HP1331 (material_environmental): M101-M103 -> M384-M395
  Brandschutz/Laserschutz + M533/M408 SDB/PSA
- HP800-HP858, HP1178-HP1264 (software/sensor/hmi):
  M101/M104 -> M105/M106/M107/M214 SPS/Watchdog/Plausibilitaet
- HP026, HP611-HP1690 (ergonomic): M001/M082 -> M353-M360 +
  M530-M532 Hebehilfe/ergonomische Hoehe
- HP201-HP1697 (mechanical): M054/M051 -> M002/M008/M061/M141 +
  M487/M488 Tueroeffnung-Stillsetzung/Wiederanlauf
- Plus EMF/Strahlung/Brand/Lärm/Vibration/Kommunikation/Cyber

Coverage shift (Pattern-Author-Fehler bei aktiviertem Set-Filter):
   start:         237 patterns with zero category-compatible measures
   after Stufe 1A:   5 (AI)
   after Stufe 1B:  20 (mechanical Bestand)
   after Stufe 1C:  35 (electrical Bestand)
   after Stufe 1D:  29 (material_environmental)
   after Stufe 1E:  29 (software/sensor/hmi)
   after Stufe 1F:  20 (ergonomic)
   after Stufe 1G:  80 (thermal/comm/radiation/fire/safety)
   final:           0  (28 extended.go/extended2.go duplicates fixed)

New regression tests:
- TestEveryPattern_HasCategoryCompatibleMeasure: every pattern in
  collectAllPatterns() must reference at least one category-compatible
  measure; gaps must be explicitly listed in AllowlistKnownGaps
  (currently empty). Fails CI for any new pattern that drifts.
- TestAcceptableMeasureCategories: pins the set-mapping for the
  7 most-bug-prone pattern categories.
- TestIsCategoryCompatible_EmptyMeasureCat: protects legacy entries.

A separate task #11 tracks 58 HP-ID duplicates between
extended.go/extended2.go and cobot.go/press.go/operational.go —
patterns are semantically different and TestGetBuiltinHazardPatterns_-
UniqueIDs misses them because it only checks HP001-HP044.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Benjamin Admin
2026-05-16 21:11:02 +02:00
parent 938f9a6c51
commit 6a3e96d54c
36 changed files with 549 additions and 273 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ai-compliance-sdk/internal/iace/hazard_patterns_final_d.go
+18 -18
View File
@@ -107,7 +107,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part", "maintenance"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"ergonomic", "maintenance_hazard"},
SuggestedMeasureIDs: []string{"M001"},
SuggestedMeasureIDs: []string{"M035", "M037", "M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 62, ScenarioDE: "Wartungsstelle nur in Zwangshaltung erreichbar",
TriggerDE: "Enge Konstruktion, fehlende Wartungsoeffnung", HarmDE: "Fehlhandlung, Ueberlastung",
@@ -119,7 +119,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"user_interface", "structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"hmi_error", "ergonomic"},
SuggestedMeasureIDs: []string{"M001"},
SuggestedMeasureIDs: []string{"M204", "M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 58, ScenarioDE: "Bediener verwechselt Taster durch unguenstige Anordnung",
TriggerDE: "Aehnliche Taster nebeneinander, keine Farbcodierung", HarmDE: "Falscher Befehl, Unfall",
@@ -193,7 +193,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"safety_function_failure"},
SuggestedMeasureIDs: []string{"M001", "M005"},
SuggestedMeasureIDs: []string{"M227", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E08"},
Priority: 85, ScenarioDE: "Schutzhaube oder Verkleidung dauerhaft entfernt",
TriggerDE: "Bequemlichkeit, schnellerer Zugang", HarmDE: "Direkter Zugang zur Gefahrstelle",
@@ -205,7 +205,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part", "sensor_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"safety_function_failure"},
SuggestedMeasureIDs: []string{"M001", "M005", "M051"},
SuggestedMeasureIDs: []string{"M227", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E08"},
Priority: 85, ScenarioDE: "Sicherheitsschalter wird mit Draht/Magnet ueberbrueckt",
TriggerDE: "Produktionsdruck, haeufige Stoerungen", HarmDE: "Sicherheitsfunktion vollstaendig unwirksam",
@@ -217,7 +217,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"safety_function_failure"},
SuggestedMeasureIDs: []string{"M001"},
SuggestedMeasureIDs: []string{"M227", "M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 78, ScenarioDE: "Schalter mit Klebeband oder Draht fixiert",
TriggerDE: "Ergonomieprobleme, Dauerbetrieb", HarmDE: "Sicherheitsfunktion dauerhaft aus",
@@ -229,7 +229,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"sensor_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"safety_function_failure", "sensor_fault"},
SuggestedMeasureIDs: []string{"M001"},
SuggestedMeasureIDs: []string{"M227", "M214", "M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 80, ScenarioDE: "Sicherheitssensor absichtlich abgedeckt oder verdreht",
TriggerDE: "Fehlalarme, Produktionsstoerung", HarmDE: "Sicherheitssensor erkennt Gefahr nicht",
@@ -327,7 +327,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"electrical_part", "structural_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard", "mechanical_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M521", "M522", "M539", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 58, ScenarioDE: "Hochwasser flutet Maschinenraum/Keller",
TriggerDE: "Starkregen, Flusshochwasser, Rohrbruch", HarmDE: "Stromschlag, Maschinenschaden",
@@ -339,7 +339,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"electrical_part", "structural_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M138", "M329", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 55, ScenarioDE: "Blitzeinschlag zerstoert Steuerungselektronik",
TriggerDE: "Fehlender Blitzschutz, Ueberspannungsschutz", HarmDE: "Steuerungsausfall, Brand",
@@ -363,7 +363,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part", "has_software"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"thermal_hazard"},
SuggestedMeasureIDs: []string{"M001"},
SuggestedMeasureIDs: []string{"M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 55, ScenarioDE: "Extreme Kaelte oder Hitze fuehrt zu Funktionsausfall",
TriggerDE: "Ausfall Klimatisierung, extreme Witterung", HarmDE: "Unvorhersehbares Maschinenverhalten",
@@ -424,7 +424,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part", "programmable"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"safety_function_failure"},
SuggestedMeasureIDs: []string{"M001", "M051"},
SuggestedMeasureIDs: []string{"M227", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E08"},
Priority: 78, ScenarioDE: "Not-Halt stoppt nur eigene Maschine, nicht verkettete",
TriggerDE: "Fehlende Not-Halt-Verkettung, Design-Fehler", HarmDE: "Nachbaranlage laeuft weiter",
@@ -449,7 +449,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part", "electrical_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"safety_function_failure"},
SuggestedMeasureIDs: []string{"M001"},
SuggestedMeasureIDs: []string{"M188", "M227", "M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 72, ScenarioDE: "Ersatzkomponente passt nicht zur Sicherheitsarchitektur",
TriggerDE: "Falscher Ersatztyp, andere Kennwerte", HarmDE: "Sicherheitsfunktion beeintraechtigt",
@@ -485,7 +485,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"safety_function_failure"},
SuggestedMeasureIDs: []string{"M001", "M005"},
SuggestedMeasureIDs: []string{"M227", "M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 80, ScenarioDE: "Schutzeinrichtung fuer Umbau entfernt und nicht remontiert",
TriggerDE: "Vergessen nach Umbau, kein Pruefschritt", HarmDE: "Dauerhaft ungeschuetzte Gefahrstelle",
@@ -620,7 +620,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"ergonomic"},
SuggestedMeasureIDs: []string{"M001"},
SuggestedMeasureIDs: []string{"M360", "M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 68, ScenarioDE: "Keiner fuehlt sich verantwortlich bei mehreren Bedienern",
TriggerDE: "Fehlende Rollenzuweisung", HarmDE: "Doppel- oder Nichthandlung",
@@ -644,7 +644,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"ergonomic"},
SuggestedMeasureIDs: []string{"M001"},
SuggestedMeasureIDs: []string{"M033", "M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 68, ScenarioDE: "Bediener kann anderen nicht sehen",
TriggerDE: "Grosse Maschine, verdeckter Bereich", HarmDE: "Start trotz Person im Gefahrbereich",
@@ -668,7 +668,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"structural_part", "sensor_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"safety_function_failure"},
SuggestedMeasureIDs: []string{"M001", "M005"},
SuggestedMeasureIDs: []string{"M227", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E08"},
Priority: 72, ScenarioDE: "Schutzbereiche zweier Maschinen ueberlappen sich",
TriggerDE: "Zu enger Aufstellungsabstand", HarmDE: "Zugang trotz Sicherheitssignal",
@@ -937,7 +937,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"chemical_risk", "structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"material_environmental"},
SuggestedMeasureIDs: []string{"M124"},
SuggestedMeasureIDs: []string{"M405", "M414", "M141"},
SuggestedEvidenceIDs: []string{"E20"},
Priority: 72, ScenarioDE: "Absauganlage ist zu schwach oder defekt",
TriggerDE: "Verstopfter Filter, defekter Ventilator", HarmDE: "Erhoehte Gefahrstoffkonzentration",
@@ -949,7 +949,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"maintenance", "electrical_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard", "mechanical_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003", "M005"},
SuggestedMeasureIDs: []string{"M522", "M539", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06", "E08"},
Priority: 85, ScenarioDE: "Maschine wird gewartet ohne Energietrennung",
TriggerDE: "Kein LOTO-Verfahren, Zeitdruck", HarmDE: "Unerwarteter Anlauf, Stromschlag",
@@ -973,7 +973,7 @@ func GetFinalPatternsD() []HazardPattern {
RequiredComponentTags: []string{"chemical_risk", "structural_part"},
RequiredEnergyTags: []string{"electrical"},
GeneratedHazardCats: []string{"fire_explosion", "electrical_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M088", "M329", "M385", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 72, ScenarioDE: "Schuettgut laedt sich auf und Funke zuendet Staub",
TriggerDE: "Nicht geerdete Behaelter, trockene Luft", HarmDE: "Staubexplosion, Brand",