Benjamin_Boenisch/breakpilot-compliance
1
0
Fork 0
Code Issues 24 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(iace): set-based measure-category filter + 235 pattern-author fixes

Browse Source 
Two-part nachhaltiger fix replacing the previous "fill to 5 mitigations
no matter what" behavior that the GT-Bremse benchmark proved
unfaithful (e.g. HP1625 "scharfe Kanten" returning M005 "Rotations-
bewegung vermeiden" via category fallback; HP1651 "Wiederanlauf
Roboter" returning M054 "Sichere thermische Auslegung" via
mismatched pattern reference).

PART A — Set-based category filter (handlers package):
- acceptableMeasureCategories: replaces 1:1 patternCatToMeasureCat
  with a curated set per pattern category, so e.g.
  safety_function_failure now accepts software_control measures
  (watchdogs, plausibility checks) and emc_hazard accepts both
  electrical and software_control measures
- isCategoryCompatible: gate every measure id against the accepted
  set before creating a mitigation; mismatches log MEASURE-SKIP
- The old category fallback is REMOVED. A hazard whose pattern has
  no category-compatible measure is now created with zero mitigations
  and logged as COVERAGE-GAP — the operator must consult an expert.
  No more silent invention of generic defaults.

PART B — 235 pattern author-error fixes across 26 files:
- HP040-HP044 (AI): M101/M102/M103 (Auffangwanne/Absauganlage) ->
  M133 Anomalieerkennung + M214 Plausibilitaet + M213 Sensor-Redundanz
  + M044 Zweikanalige Steuerung + others
- HP011-HP015, HP104-HP109, HP1085-HP1095, HP1281-HP1334 (electrical):
  M001-M005/M054/M061 placeholders -> M481/M482 Isolation +
  M511-M522 PE/Schutzleiter/RCD/Hauptschalter
- HP110-HP1331 (material_environmental): M101-M103 -> M384-M395
  Brandschutz/Laserschutz + M533/M408 SDB/PSA
- HP800-HP858, HP1178-HP1264 (software/sensor/hmi):
  M101/M104 -> M105/M106/M107/M214 SPS/Watchdog/Plausibilitaet
- HP026, HP611-HP1690 (ergonomic): M001/M082 -> M353-M360 +
  M530-M532 Hebehilfe/ergonomische Hoehe
- HP201-HP1697 (mechanical): M054/M051 -> M002/M008/M061/M141 +
  M487/M488 Tueroeffnung-Stillsetzung/Wiederanlauf
- Plus EMF/Strahlung/Brand/Lärm/Vibration/Kommunikation/Cyber

Coverage shift (Pattern-Author-Fehler bei aktiviertem Set-Filter):
   start:         237 patterns with zero category-compatible measures
   after Stufe 1A:   5 (AI)
   after Stufe 1B:  20 (mechanical Bestand)
   after Stufe 1C:  35 (electrical Bestand)
   after Stufe 1D:  29 (material_environmental)
   after Stufe 1E:  29 (software/sensor/hmi)
   after Stufe 1F:  20 (ergonomic)
   after Stufe 1G:  80 (thermal/comm/radiation/fire/safety)
   final:           0  (28 extended.go/extended2.go duplicates fixed)

New regression tests:
- TestEveryPattern_HasCategoryCompatibleMeasure: every pattern in
  collectAllPatterns() must reference at least one category-compatible
  measure; gaps must be explicitly listed in AllowlistKnownGaps
  (currently empty). Fails CI for any new pattern that drifts.
- TestAcceptableMeasureCategories: pins the set-mapping for the
  7 most-bug-prone pattern categories.
- TestIsCategoryCompatible_EmptyMeasureCat: protects legacy entries.

A separate task #11 tracks 58 HP-ID duplicates between
extended.go/extended2.go and cobot.go/press.go/operational.go —
patterns are semantically different and TestGetBuiltinHazardPatterns_-
UniqueIDs misses them because it only checks HP001-HP044.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Benjamin Admin
2026-05-16 21:11:02 +02:00
parent 938f9a6c51
commit 6a3e96d54c
36 changed files with 549 additions and 273 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ai-compliance-sdk/internal/iace/hazard_patterns_final_b.go
+23 -23
View File
@@ -10,7 +10,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003", "M054"},
SuggestedMeasureIDs: []string{"M481", "M482", "M265", "M139", "M475"},
SuggestedEvidenceIDs: []string{"E01", "E06", "E08"},
Priority: 85, ScenarioDE: "Person beruehrt aktive Leiter bei offener Abdeckung",
TriggerDE: "Wartung ohne Freischalten, defekte Isolation", HarmDE: "Stromschlag, Herzrhythmusstoerung",
@@ -22,7 +22,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part", "structural_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M515", "M518", "M516", "M517", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 80, ScenarioDE: "Maschinengehaeuse fuehrt Spannung bei Isolationsfehler",
TriggerDE: "Isolationsversagen, fehlender Schutzleiter", HarmDE: "Stromschlag durch Gehaeuse",
@@ -46,7 +46,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part", "structural_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M477", "M521", "M139", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 72, ScenarioDE: "Kriechstrom fliesst ueber nasse Maschinenflaeche",
TriggerDE: "Reinigung mit Wasser, Kondensation, Leckage", HarmDE: "Stromschlag, Muskelverkrampfung",
@@ -58,7 +58,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part"},
RequiredEnergyTags: []string{"electrical"},
GeneratedHazardCats: []string{"electrical_hazard"},
SuggestedMeasureIDs: []string{"M001"},
SuggestedMeasureIDs: []string{"M088", "M329", "M141"},
SuggestedEvidenceIDs: []string{"E01"},
Priority: 55, ScenarioDE: "Elektrostatische Entladung zuendet Atmosphaere",
TriggerDE: "Statische Aufladung bei Schuettgut/Folie, Funke", HarmDE: "Brand, leichte Verbrennung",
@@ -71,7 +71,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part", "moving_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M508", "M509", "M520", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 75, ScenarioDE: "Kabelisolierung durch Scheuern oder Quetschung beschaedigt",
TriggerDE: "Kabel in Bewegungsbereich, scharfe Kante", HarmDE: "Brand, Stromschlag",
@@ -83,7 +83,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard", "thermal_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M510", "M477", "M520", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 70, ScenarioDE: "Lockere Klemme verursacht Lichtbogen und Brand",
TriggerDE: "Vibration lockert Klemme, Oxidation", HarmDE: "Schaltschrankbrand",
@@ -95,7 +95,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part", "structural_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M521", "M508", "M539"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 72, ScenarioDE: "Wasser dringt in elektrische Komponente ein",
TriggerDE: "Undichte Kabeldurchfuehrung, Ueberflutung", HarmDE: "Kurzschluss, Brand",
@@ -108,7 +108,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part", "high_temperature"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard", "thermal_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M520", "M519", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 72, ScenarioDE: "Motor ueberhitzt durch dauerhaften Ueberlastbetrieb",
TriggerDE: "Zu hohe Last, blockierter Antrieb, fehlender Schutz", HarmDE: "Wicklungsbrand, Rauchentwicklung",
@@ -120,7 +120,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard", "thermal_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M520", "M519", "M138", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 75, ScenarioDE: "Zu duenner Kabelquerschnitt fuehrt zu Kabelbrand",
TriggerDE: "Falsche Dimensionierung, fehlende Sicherung", HarmDE: "Kabelbrand, Brandausbreitung",
@@ -132,7 +132,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"electrical_part", "high_temperature"},
RequiredEnergyTags: []string{"electrical_energy"},
GeneratedHazardCats: []string{"electrical_hazard", "thermal_hazard"},
SuggestedMeasureIDs: []string{"M001", "M003"},
SuggestedMeasureIDs: []string{"M521", "M520", "M519", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E06"},
Priority: 70, ScenarioDE: "Schaltschrank ueberhitzt durch defekte Kuehlung",
TriggerDE: "Luefter defekt, Filter verstopft, Ueberbelegung", HarmDE: "Komponentenausfall, Brand",
@@ -487,7 +487,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"chemical_risk"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"material_environmental"},
SuggestedMeasureIDs: []string{"M124"},
SuggestedMeasureIDs: []string{"M533", "M141"},
SuggestedEvidenceIDs: []string{"E20"},
Priority: 62, ScenarioDE: "Chemikalie wird mit Getraenk verwechselt",
TriggerDE: "Umfuellen in Trinkflaschen, fehlende Kennzeichnung", HarmDE: "Akute Vergiftung",
@@ -659,7 +659,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"chemical_risk", "structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"material_environmental"},
SuggestedMeasureIDs: []string{"M124"},
SuggestedMeasureIDs: []string{"M406", "M407", "M141"},
SuggestedEvidenceIDs: []string{"E20"},
Priority: 72, ScenarioDE: "Legionellen vermehren sich im Kuehlkreislauf",
TriggerDE: "Stagnation, Temperatur 25-50C, fehlende Wartung", HarmDE: "Legionaerspneumonie",
@@ -671,7 +671,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"material_environmental"},
SuggestedMeasureIDs: []string{"M124"},
SuggestedMeasureIDs: []string{"M414", "M406", "M141"},
SuggestedEvidenceIDs: []string{"E20"},
Priority: 60, ScenarioDE: "Schimmelsporen aus Lueftung werden eingeatmet",
TriggerDE: "Feuchtigkeit im Kanal, fehlende Filterwartung", HarmDE: "Allergische Alveolitis",
@@ -744,7 +744,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"radiation_risk", "sensor_part"},
RequiredEnergyTags: []string{"radiation"},
GeneratedHazardCats: []string{"radiation_hazard"},
SuggestedMeasureIDs: []string{"M001", "M054"},
SuggestedMeasureIDs: []string{"M392", "M141"},
SuggestedEvidenceIDs: []string{"E08", "E20"},
Priority: 80, ScenarioDE: "Ionisierende Strahlung aus Roentgenpruefanlage",
TriggerDE: "Defekte Abschirmung, Zugang bei Betrieb", HarmDE: "Strahlenkrankheit, Krebs",
@@ -756,7 +756,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"radiation_risk"},
RequiredEnergyTags: []string{"radiation"},
GeneratedHazardCats: []string{"radiation_hazard"},
SuggestedMeasureIDs: []string{"M001", "M005", "M054"},
SuggestedMeasureIDs: []string{"M391", "M392", "M394", "M141"},
SuggestedEvidenceIDs: []string{"E08", "E20"},
Priority: 82, ScenarioDE: "Laserstrahl trifft Auge oder Haut",
TriggerDE: "Reflexion, offene Abdeckung, fehlende Brille", HarmDE: "Netzhautverbrennung, Erblindung",
@@ -768,7 +768,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"radiation_risk", "electrical_part"},
RequiredEnergyTags: []string{"electromagnetic"},
GeneratedHazardCats: []string{"radiation_hazard", "emc_hazard"},
SuggestedMeasureIDs: []string{"M001", "M054"},
SuggestedMeasureIDs: []string{"M392", "M141"},
SuggestedEvidenceIDs: []string{"E08", "E20"},
Priority: 68, ScenarioDE: "Starkes EMF-Feld durch HF-Anlage/Induktionsofen",
TriggerDE: "Aufenthalt im Nahfeld, fehlende Abschirmung", HarmDE: "Erwaermung Gewebe, Herzschrittmacher",
@@ -842,7 +842,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"chemical_risk", "structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"material_environmental"},
SuggestedMeasureIDs: []string{"M001", "M054", "M124"},
SuggestedMeasureIDs: []string{"M385", "M533", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E08", "E20"},
Priority: 85, ScenarioDE: "Inertgas verdraengt Sauerstoff im Raum",
TriggerDE: "Stickstoff-/Argonleck, Loeschanlage loest aus", HarmDE: "Bewusstlosigkeit, Erstickungstod",
@@ -854,7 +854,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"chemical_risk"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"material_environmental"},
SuggestedMeasureIDs: []string{"M001", "M054", "M124"},
SuggestedMeasureIDs: []string{"M385", "M533", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E20"},
Priority: 80, ScenarioDE: "CO2 aus Gaerprozess verdraengt Sauerstoff in Grube/Keller",
TriggerDE: "Betreten ohne Gasmessung, fehlende Lueftung", HarmDE: "Bewusstlosigkeit, Tod",
@@ -866,7 +866,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"structural_part"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"material_environmental"},
SuggestedMeasureIDs: []string{"M001", "M054"},
SuggestedMeasureIDs: []string{"M385", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E20"},
Priority: 82, ScenarioDE: "Sauerstoff wird durch Arbeiten in engem Raum verbraucht",
TriggerDE: "Schweissen/Schneiden in Behaelter ohne Lueftung", HarmDE: "Sauerstoffmangel, Erstickung",
@@ -903,7 +903,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"chemical_risk", "high_temperature"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"material_environmental"},
SuggestedMeasureIDs: []string{"M001", "M124"},
SuggestedMeasureIDs: []string{"M385", "M533", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E20"},
Priority: 82, ScenarioDE: "CO entsteht bei unvollstaendiger Verbrennung",
TriggerDE: "Verbrennungsmotor in Halle, defekter Abzug", HarmDE: "CO-Vergiftung, Tod",
@@ -987,7 +987,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"chemical_risk"},
RequiredEnergyTags: []string{},
GeneratedHazardCats: []string{"material_environmental", "thermal_hazard"},
SuggestedMeasureIDs: []string{"M001", "M124"},
SuggestedMeasureIDs: []string{"M385", "M386", "M533", "M141"},
SuggestedEvidenceIDs: []string{"E01", "E20"},
Priority: 78, ScenarioDE: "Falsches Mischen erzeugt unkontrollierte Reaktion",
TriggerDE: "Verwechslung Chemikalien, falsche Reihenfolge", HarmDE: "Explosion, Spritzer, Verbrennung",
@@ -1023,7 +1023,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"radiation_risk", "electrical_part"},
RequiredEnergyTags: []string{"electromagnetic"},
GeneratedHazardCats: []string{"radiation_hazard"},
SuggestedMeasureIDs: []string{"M001", "M054"},
SuggestedMeasureIDs: []string{"M392", "M141"},
SuggestedEvidenceIDs: []string{"E08", "E20"},
Priority: 65, ScenarioDE: "Mikrowellenstrahlung tritt aus defekter Abschirmung",
TriggerDE: "Beschaedigte Dichtung, fehlende Wartung", HarmDE: "Gewebeerwaermung, Augenschaden",
@@ -1035,7 +1035,7 @@ func GetFinalPatternsB() []HazardPattern {
RequiredComponentTags: []string{"radiation_risk", "structural_part"},
RequiredEnergyTags: []string{"radiation"},
GeneratedHazardCats: []string{"radiation_hazard"},
SuggestedMeasureIDs: []string{"M124"},
SuggestedMeasureIDs: []string{"M385", "M141", "M533"},
SuggestedEvidenceIDs: []string{"E20"},
Priority: 55, ScenarioDE: "Radon sammelt sich in schlecht belueftetem Keller",
TriggerDE: "Fehlende Lueftung, geologisch belastetes Gebiet", HarmDE: "Lungenkrebs bei Langzeitexposition",