feat(iace): wire OSHA minimum-distance library into measures + endpoint
The May-built OSHA distance library (minimum_distances.go, 29 CFR 1910, US public domain) was dead code — zero callers, no route, no test, while the mm values that actually appear in measures are independent hand-prose (some carrying ISO 13854/13857 values, not OSHA). This surfaces it without touching the measures response contract: - GET /iace/minimum-distances (+ ?measure_id=) returns the distances, the curated measure→distance link table and the licensing note. - AllMeasureDistanceLinks/MinimumDistancesForMeasure resolve only the defensible links (M600 value_source; M254/M065 public-domain crossref to ISO), with the relation made explicit so the join stays honest. - architecture.go lists the OSHA library so it shows in the audit explainer. - Tests: inch→mm conversion + license completeness, link integrity, and a consistency test pinning that a value_source measure's prose still matches the OSHA source (codifies the audit finding as a regression gate). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,30 @@
|
||||
package handlers
|
||||
|
||||
import (
|
||||
"net/http"
|
||||
|
||||
"github.com/breakpilot/ai-compliance-sdk/internal/iace"
|
||||
"github.com/gin-gonic/gin"
|
||||
)
|
||||
|
||||
// ListMinimumDistances handles GET /minimum-distances.
|
||||
// Read-only OSHA safety-distance reference (29 CFR 1910, US public domain)
|
||||
// plus the curated measure→distance link table, so an auditor can see WHERE a
|
||||
// measure's mm figure comes from. Optional ?measure_id= returns only the
|
||||
// distances (and links) tied to that protective measure.
|
||||
func (h *IACEHandler) ListMinimumDistances(c *gin.Context) {
|
||||
if mid := c.Query("measure_id"); mid != "" {
|
||||
c.JSON(http.StatusOK, gin.H{
|
||||
"measure_id": mid,
|
||||
"distances": iace.MinimumDistancesForMeasure(mid),
|
||||
"links": iace.LinksForMeasure(mid),
|
||||
"note": iace.MinimumDistanceNote,
|
||||
})
|
||||
return
|
||||
}
|
||||
c.JSON(http.StatusOK, gin.H{
|
||||
"distances": iace.GetOSHAMinimumDistances(),
|
||||
"links": iace.AllMeasureDistanceLinks(),
|
||||
"note": iace.MinimumDistanceNote,
|
||||
})
|
||||
}
|
||||
@@ -30,6 +30,7 @@ func registerIACERoutes(v1 *gin.RouterGroup, h *handlers.IACEHandler) {
|
||||
iaceRoutes.GET("/operational-states", h.ListOperationalStates)
|
||||
iaceRoutes.GET("/component-library", h.ListComponentLibrary)
|
||||
iaceRoutes.GET("/energy-sources", h.ListEnergySources)
|
||||
iaceRoutes.GET("/minimum-distances", h.ListMinimumDistances)
|
||||
iaceRoutes.GET("/tags", h.ListTags)
|
||||
iaceRoutes.GET("/hazard-patterns", h.ListHazardPatterns)
|
||||
|
||||
|
||||
@@ -146,6 +146,7 @@ func BuildArchitecture() Architecture {
|
||||
{Name: "Domänen-Capability-Gates", Count: distinctDomainGates(), SourceFile: "pattern_domain_gates.go", Description: "dom_*-Tags, die domänenspezifische Muster auf ihre echte Maschine begrenzen (Leak-Schutz)."},
|
||||
{Name: "Kontaktmodus-Tiers", Count: len(contactModeTable), SourceFile: "risk_estimation.go", Description: "Verletzungsmechanismen mit W/P/S-Tiers (ESAW-verankert, GT-kalibriert)."},
|
||||
{Name: "Kontaktmodus-Evidenz", Count: len(contactModeEvidence), SourceFile: "risk_data_sources.go", Description: "Belegte öffentliche Statistik-Quoten (ESAW) als Zitat-/Audit-Schicht."},
|
||||
{Name: "OSHA-Mindestabstände", Count: len(GetOSHAMinimumDistances()), SourceFile: "minimum_distances.go", Description: "OSHA 29 CFR 1910 Sicherheitsabstände (Public Domain) + Maßnahmen-Verknüpfung; EU-Normen nur referenziert."},
|
||||
},
|
||||
DataSources: []ArchDataSource{
|
||||
{Name: "Eurostat ESAW (Kontaktmodus-Unfallstatistik)", License: "CC BY 4.0", Usage: "Anker für Wahrscheinlichkeits-Tiers (W) + zitierbare Quoten", Status: "verwendet"},
|
||||
|
||||
@@ -170,3 +170,96 @@ func GetOSHAMinimumDistances() []MinimumDistance {
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
// MinimumDistanceNote is the ready-to-print licensing posture for the
|
||||
// minimum-distance reference — shown by the API so an auditor sees WHY the
|
||||
// OSHA values may be reproduced while the EU norms are reference-only.
|
||||
const MinimumDistanceNote = "OSHA-Werte (29 CFR 1910) sind US-Public-Domain " +
|
||||
"(17 U.S.C. §105) und werden verbatim wiedergegeben; die mm-Umrechnung ist " +
|
||||
"mathematisch, die sicherheitsseitige Rundung ist BreakPilot-Empfehlung. " +
|
||||
"EU-Normen (EN ISO 13857/13854/13855, EN 349) werden nur per Kennung " +
|
||||
"referenziert — keine Werte reproduziert."
|
||||
|
||||
// GetMinimumDistanceByID returns the OSHA distance entry with the given ID.
|
||||
func GetMinimumDistanceByID(id string) (MinimumDistance, bool) {
|
||||
for _, md := range GetOSHAMinimumDistances() {
|
||||
if md.ID == id {
|
||||
return md, true
|
||||
}
|
||||
}
|
||||
return MinimumDistance{}, false
|
||||
}
|
||||
|
||||
// MeasureDistanceLink connects a protective measure to the OSHA distance
|
||||
// entries that anchor it. Relation makes the nature of the link explicit so
|
||||
// the join is honest rather than implying every measure's prose IS the OSHA
|
||||
// value:
|
||||
// - "value_source" — the OSHA value is the source the measure's own
|
||||
// mm figure is derived from (it appears in the measure prose).
|
||||
// - "public_domain_crossref" — the measure is dimensioned by an EU norm; the
|
||||
// OSHA entry is offered as the public-domain pendant for independent check.
|
||||
type MeasureDistanceLink struct {
|
||||
MeasureID string `json:"measure_id"`
|
||||
DistanceIDs []string `json:"distance_ids"`
|
||||
Relation string `json:"relation"`
|
||||
Note string `json:"note,omitempty"`
|
||||
}
|
||||
|
||||
const (
|
||||
LinkValueSource = "value_source"
|
||||
LinkCrossRef = "public_domain_crossref"
|
||||
)
|
||||
|
||||
// AllMeasureDistanceLinks returns the curated measure→OSHA-distance links.
|
||||
// Conservative on purpose: only measures whose CONTEXT genuinely matches an
|
||||
// OSHA entry are linked. Measures whose "OSHA" citation is loose or carries an
|
||||
// ISO value (e.g. M340 robot teach speed, M368 air-receiver wall) are NOT
|
||||
// linked — that would imply a public-domain anchor that does not exist.
|
||||
func AllMeasureDistanceLinks() []MeasureDistanceLink {
|
||||
return []MeasureDistanceLink{
|
||||
{
|
||||
MeasureID: "M600",
|
||||
DistanceIDs: []string{"MD_OSHA_217_PSDI"},
|
||||
Relation: LinkValueSource,
|
||||
Note: "Hand-Speed-Konstante 1.600 mm/s (63 in/s) ist die Obergrenze, aus der die Kriechgeschwindigkeit am Endanschlag abgeleitet ist.",
|
||||
},
|
||||
{
|
||||
MeasureID: "M254",
|
||||
DistanceIDs: []string{"MD_OSHA_O10_R1", "MD_OSHA_O10_R4"},
|
||||
Relation: LinkCrossRef,
|
||||
Note: "OSHA Table O-10 (Point-of-Operation an mechanischen Pressen) als Public-Domain-Pendant zur ISO-13855-Methode — Werte eigenstaendig pruefen.",
|
||||
},
|
||||
{
|
||||
MeasureID: "M065",
|
||||
DistanceIDs: []string{"MD_OSHA_212_FAN"},
|
||||
Relation: LinkCrossRef,
|
||||
Note: "OSHA §1910.212(a)(5) Luefterschutz (max. 12 mm Spaltoeffnung) als Public-Domain-Pendant zu ISO 13857.",
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
// LinksForMeasure returns the distance links declared for one measure.
|
||||
func LinksForMeasure(measureID string) []MeasureDistanceLink {
|
||||
var out []MeasureDistanceLink
|
||||
for _, l := range AllMeasureDistanceLinks() {
|
||||
if l.MeasureID == measureID {
|
||||
out = append(out, l)
|
||||
}
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
// MinimumDistancesForMeasure resolves the OSHA distance entries linked to a
|
||||
// protective measure. This is the join that finally lets the OSHA mm values
|
||||
// "flow into" the measures (read-side), without mutating the measure object.
|
||||
func MinimumDistancesForMeasure(measureID string) []MinimumDistance {
|
||||
var out []MinimumDistance
|
||||
for _, l := range LinksForMeasure(measureID) {
|
||||
for _, id := range l.DistanceIDs {
|
||||
if md, ok := GetMinimumDistanceByID(id); ok {
|
||||
out = append(out, md)
|
||||
}
|
||||
}
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
@@ -0,0 +1,135 @@
|
||||
package iace
|
||||
|
||||
import (
|
||||
"math"
|
||||
"strconv"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// These tests codify the May-built-but-never-verified OSHA minimum-distance
|
||||
// library: that its public-domain values convert correctly, that the
|
||||
// measure→distance links point at real measures and real distances, and that
|
||||
// a "value_source" link's OSHA figure actually appears in the measure prose
|
||||
// (the consistency the audit asked for).
|
||||
|
||||
const inchToMM = 25.4
|
||||
|
||||
func TestOSHAMinimumDistances_ConversionAndLicense(t *testing.T) {
|
||||
dists := GetOSHAMinimumDistances()
|
||||
if len(dists) == 0 {
|
||||
t.Fatal("OSHA minimum-distance library is empty")
|
||||
}
|
||||
seen := map[string]bool{}
|
||||
for _, d := range dists {
|
||||
if seen[d.ID] {
|
||||
t.Errorf("duplicate distance ID %q", d.ID)
|
||||
}
|
||||
seen[d.ID] = true
|
||||
|
||||
if d.License == "" || d.SourceCFR == "" || d.Context == "" {
|
||||
t.Errorf("%s: missing license/source/context: %+v", d.ID, d)
|
||||
}
|
||||
|
||||
// Inch → mm conversions must be mathematically exact (within rounding).
|
||||
if d.OriginalUnit == UnitInch {
|
||||
checkConv := func(label string, orig, exact float64) {
|
||||
if orig == 0 && exact == 0 {
|
||||
return
|
||||
}
|
||||
if math.Abs(orig*inchToMM-exact) > 0.05 {
|
||||
t.Errorf("%s: %s conversion off: %.3f in → %.3f mm (expected %.3f)",
|
||||
d.ID, label, orig, exact, orig*inchToMM)
|
||||
}
|
||||
}
|
||||
checkConv("value", d.OriginalValue, d.ExactMM)
|
||||
checkConv("min", d.OriginalMin, d.ExactMinMM)
|
||||
checkConv("max", d.OriginalMax, d.ExactMaxMM)
|
||||
}
|
||||
|
||||
// Safe-side rounding must stay near the exact value (≤5 mm grid).
|
||||
if d.ExactMM > 0 && d.RecommendedMM > 0 {
|
||||
if math.Abs(float64(d.RecommendedMM)-d.ExactMM) > 5 {
|
||||
t.Errorf("%s: recommended %d mm too far from exact %.2f mm",
|
||||
d.ID, d.RecommendedMM, d.ExactMM)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestMeasureDistanceLinks_Integrity(t *testing.T) {
|
||||
measures := map[string]ProtectiveMeasureEntry{}
|
||||
for _, m := range GetProtectiveMeasureLibrary() {
|
||||
measures[m.ID] = m
|
||||
}
|
||||
|
||||
links := AllMeasureDistanceLinks()
|
||||
if len(links) == 0 {
|
||||
t.Fatal("no measure→distance links declared")
|
||||
}
|
||||
for _, l := range links {
|
||||
if _, ok := measures[l.MeasureID]; !ok {
|
||||
t.Errorf("link references unknown measure %q", l.MeasureID)
|
||||
}
|
||||
if l.Relation != LinkValueSource && l.Relation != LinkCrossRef {
|
||||
t.Errorf("link %q has invalid relation %q", l.MeasureID, l.Relation)
|
||||
}
|
||||
if len(l.DistanceIDs) == 0 {
|
||||
t.Errorf("link %q has no distance IDs", l.MeasureID)
|
||||
}
|
||||
for _, id := range l.DistanceIDs {
|
||||
if _, ok := GetMinimumDistanceByID(id); !ok {
|
||||
t.Errorf("link %q references unknown distance %q", l.MeasureID, id)
|
||||
}
|
||||
}
|
||||
// The resolver must return exactly the linked distances.
|
||||
if got := len(MinimumDistancesForMeasure(l.MeasureID)); got != len(l.DistanceIDs) {
|
||||
t.Errorf("resolver for %q returned %d, expected %d", l.MeasureID, got, len(l.DistanceIDs))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestMeasureDistanceLinks_ValueSourceProseConsistency(t *testing.T) {
|
||||
measures := map[string]ProtectiveMeasureEntry{}
|
||||
for _, m := range GetProtectiveMeasureLibrary() {
|
||||
measures[m.ID] = m
|
||||
}
|
||||
|
||||
for _, l := range AllMeasureDistanceLinks() {
|
||||
if l.Relation != LinkValueSource {
|
||||
continue // cross-refs legitimately use an EU value in prose
|
||||
}
|
||||
m := measures[l.MeasureID]
|
||||
text := strings.ToLower(m.Name + " " + m.Description + " " + strings.Join(m.Examples, " "))
|
||||
text = strings.ReplaceAll(text, ".", "") // "1.600" → "1600"
|
||||
|
||||
for _, id := range l.DistanceIDs {
|
||||
md, _ := GetMinimumDistanceByID(id)
|
||||
if !proseMentionsDistance(text, md) {
|
||||
t.Errorf("value_source measure %q does not mention any value of linked distance %q "+
|
||||
"— prose has drifted from the OSHA source", l.MeasureID, id)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// proseMentionsDistance reports whether the (dot-stripped, lowercased) measure
|
||||
// text contains a numeric form of the distance's value, formula or recommended mm.
|
||||
func proseMentionsDistance(text string, md MinimumDistance) bool {
|
||||
candidates := []int{}
|
||||
if md.FormulaMMPerSecond > 0 {
|
||||
candidates = append(candidates, int(math.Round(md.FormulaMMPerSecond)))
|
||||
}
|
||||
if md.RecommendedMM > 0 {
|
||||
candidates = append(candidates, md.RecommendedMM)
|
||||
}
|
||||
if md.RecommendedMinMM > 0 {
|
||||
candidates = append(candidates, md.RecommendedMinMM)
|
||||
}
|
||||
for _, n := range candidates {
|
||||
if strings.Contains(text, strconv.Itoa(n)) {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
Reference in New Issue
Block a user