feat(product-scope): gate Navigator facts, then reuse discover_scope (step 3)
Connects the Navigator's fact-gate to the existing reasoning discover_scope — the Scope Engine decides only once the minimum (P0) facts are released. - resolve_product_scope(canonical): if not ready_for_scope -> NEEDS_FACTS (missing_facts + suggested_questions, discover_scope NOT run); else project canonical->reasoning profile and run the EXISTING discover_scope exactly once -> RESOLVED with applicable/excluded/uncertain regulations. - Environmental triggers surface ONLY as unsupported_domains (future_corpus_needed), never as a legal evaluation — transparency, no false completeness. - POST /reasoning/product-scope (thin handler) returns case NEEDS_FACTS or RESOLVED. - No new scope rules, no new regulations, no environmental-law evaluation, no UI, no Go, no RAG, no percent-compliance. Response types are application-level, not meta-model classes (freeze v1.0 untouched). - 6 tests incl. discover_scope spy (0 calls when gated, exactly 1 when ready), category separation, environmental-as-unsupported-only. 47 tests green (existing reasoning MVP tests stay green), mypy clean, LOC ok. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -7,12 +7,18 @@ pure deterministic rule evaluation.
|
||||
POST /reasoning/obligations -> obligations, overlaps, multi-evidence
|
||||
POST /reasoning/implementation-reasoning -> claim->obligation mapping (Welt 1, no verdict)
|
||||
POST /reasoning/interpretation-assessment -> verdict on a customer interpretation
|
||||
POST /reasoning/product-scope -> gate on facts, else run discover_scope once
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from fastapi import APIRouter
|
||||
|
||||
from compliance.product_scope import (
|
||||
ProductScopeRequest,
|
||||
ProductScopeResponse,
|
||||
resolve_product_scope,
|
||||
)
|
||||
from compliance.reasoning import (
|
||||
assess_interpretation,
|
||||
derive_obligations,
|
||||
@@ -53,6 +59,11 @@ def implementation_reasoning(req: ImplementationReasoningRequest) -> Implementat
|
||||
return reason_implementation_claim(req.product_profile, req.customer_claim)
|
||||
|
||||
|
||||
@router.post("/product-scope", response_model=ProductScopeResponse)
|
||||
def product_scope(req: ProductScopeRequest) -> ProductScopeResponse:
|
||||
return resolve_product_scope(req.product_profile)
|
||||
|
||||
|
||||
@router.post("/interpretation-assessment", response_model=InterpretationResponse)
|
||||
def interpretation_assessment(req: InterpretationRequest) -> InterpretationResponse:
|
||||
result = assess_interpretation(req.customer_interpretation, req.product_profile)
|
||||
|
||||
@@ -0,0 +1,26 @@
|
||||
"""Product-scope orchestration (step 3).
|
||||
|
||||
Connects the Navigator's fact-gate to the existing reasoning `discover_scope`:
|
||||
decide regulatory scope only once the minimum (P0) facts are present, otherwise
|
||||
return the missing facts. Reuses discover_scope unchanged — no new scope logic.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from .orchestrator import resolve_product_scope
|
||||
from .schemas import (
|
||||
ProductScopeRequest,
|
||||
ProductScopeResponse,
|
||||
RegulatoryScopeResult,
|
||||
ScopeStatus,
|
||||
UnsupportedDomain,
|
||||
)
|
||||
|
||||
__all__ = [
|
||||
"resolve_product_scope",
|
||||
"ProductScopeRequest",
|
||||
"ProductScopeResponse",
|
||||
"RegulatoryScopeResult",
|
||||
"UnsupportedDomain",
|
||||
"ScopeStatus",
|
||||
]
|
||||
@@ -0,0 +1,77 @@
|
||||
"""Product-scope orchestrator (step 3) — gate, then reuse discover_scope.
|
||||
|
||||
THE rule: the Scope Engine decides only once the Navigator has released the
|
||||
minimum facts. If P0 facts are missing, return the missing facts/questions and do
|
||||
NOT run discover_scope. Otherwise project the canonical into the reasoning profile
|
||||
and run the EXISTING `discover_scope` exactly once.
|
||||
|
||||
No new scope rules, no new regulations, no environmental-law evaluation (those
|
||||
domains are surfaced only as unsupported_domains / future_corpus_needed).
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from typing import List, Tuple
|
||||
|
||||
from compliance.navigator.engine import navigate
|
||||
from compliance.profile.canonical import CanonicalProductRegulatoryProfile
|
||||
from compliance.profile.to_reasoning import to_reasoning_profile
|
||||
from compliance.reasoning.scope_engine import discover_scope
|
||||
|
||||
from .schemas import (
|
||||
ProductScopeResponse,
|
||||
RegulatoryScopeResult,
|
||||
ScopeStatus,
|
||||
UnsupportedDomain,
|
||||
)
|
||||
|
||||
# environmental trigger field -> (domain, note). Transparency only — not a verdict.
|
||||
_ENV_DOMAINS: List[Tuple[str, str, str]] = [
|
||||
("discharges_to_wastewater", "environment_water", "Abwasser-/Gewässerrecht (z. B. AbwV, WRRL) — noch nicht im Korpus."),
|
||||
("has_cooling_or_spraying_water", "environment_water", "Wasserbezogene Anforderungen — noch nicht im Korpus."),
|
||||
("emits_to_air", "environment_air", "Immissionsschutz-/Luftreinhalterecht (z. B. BImSchG, IED) — noch nicht im Korpus."),
|
||||
("uses_solvents", "environment_air", "Lösemittel-/VOC-Recht (z. B. 31. BImSchV) — noch nicht im Korpus."),
|
||||
("uses_cleaning_chemicals", "chemicals", "Chemikalienrecht (REACH/CLP/Detergenzien/Biozide) — noch nicht im Korpus."),
|
||||
("supplies_chemicals", "chemicals", "Chemikalienrecht (REACH/CLP) — noch nicht im Korpus."),
|
||||
("contains_restricted_substances", "chemicals", "Stoffbeschränkungen (REACH/RoHS) — noch nicht im Korpus."),
|
||||
("creates_waste", "waste", "Abfall-/Entsorgungsrecht (u. a. WEEE) — noch nicht im Korpus."),
|
||||
("consumes_energy_or_water", "energy_resources", "Energie-/Ökodesign-Recht — noch nicht im Korpus."),
|
||||
]
|
||||
|
||||
|
||||
def _unsupported_domains(profile: CanonicalProductRegulatoryProfile) -> List[UnsupportedDomain]:
|
||||
env = profile.environmental
|
||||
seen = set()
|
||||
out: List[UnsupportedDomain] = []
|
||||
for field, domain, note in _ENV_DOMAINS:
|
||||
if getattr(env, field) is True and domain not in seen:
|
||||
seen.add(domain)
|
||||
out.append(UnsupportedDomain(domain=domain, trigger=field, note=note))
|
||||
return out
|
||||
|
||||
|
||||
def resolve_product_scope(profile: CanonicalProductRegulatoryProfile) -> ProductScopeResponse:
|
||||
nav = navigate(profile)
|
||||
|
||||
if not nav.completeness_summary.ready_for_scope:
|
||||
return ProductScopeResponse(
|
||||
status=ScopeStatus.NEEDS_FACTS,
|
||||
completeness_summary=nav.completeness_summary,
|
||||
missing_facts=nav.missing_facts,
|
||||
suggested_questions=nav.suggested_questions,
|
||||
)
|
||||
|
||||
scope = discover_scope(to_reasoning_profile(profile)) # exactly once
|
||||
result = RegulatoryScopeResult(
|
||||
applicable_regulations=scope.applicable_regulations,
|
||||
excluded_regulations=scope.excluded_regulations,
|
||||
uncertain_regulations=scope.uncertain_regulations,
|
||||
unsupported_domains=_unsupported_domains(profile),
|
||||
reasoning_summary=scope.reasoning_summary,
|
||||
confidence=scope.confidence,
|
||||
)
|
||||
return ProductScopeResponse(
|
||||
status=ScopeStatus.RESOLVED,
|
||||
completeness_summary=nav.completeness_summary,
|
||||
regulatory_scope=result,
|
||||
)
|
||||
@@ -0,0 +1,63 @@
|
||||
"""Response schemas for the product-scope orchestrator (step 3).
|
||||
|
||||
These are application/API types — NOT compliance-meta-model classes (architecture
|
||||
freeze v1.0 untouched). The scope verdict itself is produced by the existing
|
||||
`discover_scope`; nothing here adds scope rules.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from enum import Enum
|
||||
from typing import List, Optional
|
||||
|
||||
from pydantic import BaseModel, Field
|
||||
|
||||
from compliance.navigator.engine import CompletenessSummary
|
||||
from compliance.navigator.questions import NavigatorQuestion
|
||||
from compliance.profile.canonical import CanonicalProductRegulatoryProfile
|
||||
from compliance.reasoning.enums import Confidence
|
||||
from compliance.reasoning.schemas import (
|
||||
ApplicableRegulation,
|
||||
ExcludedRegulation,
|
||||
UncertainRegulation,
|
||||
)
|
||||
|
||||
|
||||
class ScopeStatus(str, Enum):
|
||||
NEEDS_FACTS = "needs_facts" # P0 facts missing -> ask, do not decide
|
||||
RESOLVED = "resolved" # minimum facts present -> scope decided
|
||||
|
||||
|
||||
class UnsupportedDomain(BaseModel):
|
||||
"""A domain the product triggers but the corpus does not yet cover.
|
||||
|
||||
Surfaced for transparency (no false completeness) — NEVER a legal evaluation.
|
||||
"""
|
||||
|
||||
domain: str
|
||||
trigger: str
|
||||
status: str = "future_corpus_needed"
|
||||
note: str = ""
|
||||
|
||||
|
||||
class RegulatoryScopeResult(BaseModel):
|
||||
applicable_regulations: List[ApplicableRegulation] = Field(default_factory=list)
|
||||
excluded_regulations: List[ExcludedRegulation] = Field(default_factory=list)
|
||||
uncertain_regulations: List[UncertainRegulation] = Field(default_factory=list)
|
||||
unsupported_domains: List[UnsupportedDomain] = Field(default_factory=list)
|
||||
reasoning_summary: str = ""
|
||||
confidence: Confidence = Confidence.MEDIUM
|
||||
|
||||
|
||||
class ProductScopeRequest(BaseModel):
|
||||
product_profile: CanonicalProductRegulatoryProfile
|
||||
|
||||
|
||||
class ProductScopeResponse(BaseModel):
|
||||
status: ScopeStatus
|
||||
completeness_summary: CompletenessSummary
|
||||
# case NEEDS_FACTS
|
||||
missing_facts: List[str] = Field(default_factory=list)
|
||||
suggested_questions: List[NavigatorQuestion] = Field(default_factory=list)
|
||||
# case RESOLVED
|
||||
regulatory_scope: Optional[RegulatoryScopeResult] = None
|
||||
Reference in New Issue
Block a user