Benjamin_Boenisch/breakpilot-compliance
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(backend/api): extract Email Template services (Step 4 — file 10 of 18)

Browse Source 
compliance/api/email_template_routes.py (823 LOC) -> 295 LOC thin routes
+ 402-line EmailTemplateService + 241-line EmailTemplateVersionService +
61-line schemas file.

Two-service split along natural responsibility seam:

  email_template_service.py (402 LOC):
    - Template type catalog (TEMPLATE_TYPES constant)
    - Template CRUD (list, create, get)
    - Stats, settings, send logs, initialization, default content
    - Shared _template_to_dict / _version_to_dict / _render_template helpers

  email_template_version_service.py (241 LOC):
    - Version CRUD (create, list, get, update)
    - Workflow transitions (submit, approve, reject, publish)
    - Preview and test-send

TEMPLATE_TYPES, VALID_CATEGORIES, VALID_STATUSES re-exported from the
route module for any legacy consumers.

State-transition errors use ValidationError (-> HTTPException 400) to
preserve the original handler's 400 status for "Only draft/review
versions can be ..." checks, since the existing TestClient integration
tests (47 tests) assert status_code == 400.

Verified:
  - 47/47 tests/test_email_template_routes.py pass
  - OpenAPI 360/484 unchanged
  - mypy compliance/ -> Success on 138 source files
  - email_template_routes.py 823 -> 295 LOC
  - Hard-cap violations: 9 -> 8

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Sharang Parnerkar
2026-04-08 22:39:19 +02:00
parent a638d0e527
commit 0c2e03f294
6 changed files with 1087 additions and 794 deletions
Download Patch File Download Diff File Expand all files Collapse all files

401
backend-compliance/tests/contracts/openapi.baseline.json
View File

@@ -19563,135 +19563,6 @@
"title": "ConsentCreate",
"type": "object"
},
"compliance__api__email_template_routes__TemplateCreate": {
"properties": {
"category": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Category"
},
"description": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Description"
},
"is_active": {
"default": true,
"title": "Is Active",
"type": "boolean"
},
"name": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Name"
},
"template_type": {
"title": "Template Type",
"type": "string"
}
},
"required": [
"template_type"
],
"title": "TemplateCreate",
"type": "object"
},
"compliance__api__email_template_routes__VersionCreate": {
"properties": {
"body_html": {
"title": "Body Html",
"type": "string"
},
"body_text": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Body Text"
},
"language": {
"default": "de",
"title": "Language",
"type": "string"
},
"subject": {
"title": "Subject",
"type": "string"
},
"version": {
"default": "1.0",
"title": "Version",
"type": "string"
}
},
"required": [
"subject",
"body_html"
],
"title": "VersionCreate",
"type": "object"
},
"compliance__api__email_template_routes__VersionUpdate": {
"properties": {
"body_html": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Body Html"
},
"body_text": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Body Text"
},
"subject": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Subject"
}
},
"title": "VersionUpdate",
"type": "object"
},
"compliance__api__incident_routes__IncidentCreate": {
"properties": {
"affected_data_categories": {
@@ -20361,6 +20232,135 @@
],
"title": "ConsentCreate",
"type": "object"
},
"compliance__schemas__email_template__TemplateCreate": {
"properties": {
"category": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Category"
},
"description": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Description"
},
"is_active": {
"default": true,
"title": "Is Active",
"type": "boolean"
},
"name": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Name"
},
"template_type": {
"title": "Template Type",
"type": "string"
}
},
"required": [
"template_type"
],
"title": "TemplateCreate",
"type": "object"
},
"compliance__schemas__email_template__VersionCreate": {
"properties": {
"body_html": {
"title": "Body Html",
"type": "string"
},
"body_text": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Body Text"
},
"language": {
"default": "de",
"title": "Language",
"type": "string"
},
"subject": {
"title": "Subject",
"type": "string"
},
"version": {
"default": "1.0",
"title": "Version",
"type": "string"
}
},
"required": [
"subject",
"body_html"
],
"title": "VersionCreate",
"type": "object"
},
"compliance__schemas__email_template__VersionUpdate": {
"properties": {
"body_html": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Body Html"
},
"body_text": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Body Text"
},
"subject": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"title": "Subject"
}
},
"title": "VersionUpdate",
"type": "object"
}
}
},
@@ -27260,7 +27260,14 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"items": {
"additionalProperties": true,
"type": "object"
},
"title": "Response List Templates Api Compliance Email Templates Get",
"type": "array"
}
}
},
"description": "Successful Response"
@@ -27307,7 +27314,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/compliance__api__email_template_routes__TemplateCreate"
"$ref": "#/components/schemas/compliance__schemas__email_template__TemplateCreate"
}
}
},
@@ -27317,7 +27324,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Create Template Api Compliance Email Templates Post",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27359,7 +27370,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Get Default Content Api Compliance Email Templates Default Template Type Get",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27408,7 +27423,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Initialize Defaults Api Compliance Email Templates Initialize Post",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27496,7 +27515,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Get Send Logs Api Compliance Email Templates Logs Get",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27545,7 +27568,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Get Settings Api Compliance Email Templates Settings Get",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27602,7 +27629,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Update Settings Api Compliance Email Templates Settings Put",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27651,7 +27682,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Get Stats Api Compliance Email Templates Stats Get",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27682,7 +27717,14 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"items": {
"additionalProperties": true,
"type": "object"
},
"title": "Response Get Template Types Api Compliance Email Templates Types Get",
"type": "array"
}
}
},
"description": "Successful Response"
@@ -27730,7 +27772,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/compliance__api__email_template_routes__VersionCreate"
"$ref": "#/components/schemas/compliance__schemas__email_template__VersionCreate"
}
}
},
@@ -27740,7 +27782,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Create Version Api Compliance Email Templates Versions Post",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27782,7 +27828,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Get Version Api Compliance Email Templates Versions Version Id Get",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27822,7 +27872,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/compliance__api__email_template_routes__VersionUpdate"
"$ref": "#/components/schemas/compliance__schemas__email_template__VersionUpdate"
}
}
},
@@ -27832,7 +27882,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Update Version Api Compliance Email Templates Versions Version Id Put",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27890,7 +27944,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Approve Version Api Compliance Email Templates Versions Version Id Approve Post",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27942,7 +28000,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Preview Version Api Compliance Email Templates Versions Version Id Preview Post",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -27984,7 +28046,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Publish Version Api Compliance Email Templates Versions Version Id Publish Post",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -28042,7 +28108,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Reject Version Api Compliance Email Templates Versions Version Id Reject Post",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -28110,7 +28180,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Send Test Email Api Compliance Email Templates Versions Version Id Send Test Post",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -28152,7 +28226,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Submit Version Api Compliance Email Templates Versions Version Id Submit Post",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -28210,7 +28288,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Get Template Api Compliance Email Templates Template Id Get",
"type": "object"
}
}
},
"description": "Successful Response"
@@ -28268,7 +28350,14 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"items": {
"additionalProperties": true,
"type": "object"
},
"title": "Response Get Versions Api Compliance Email Templates Template Id Versions Get",
"type": "array"
}
}
},
"description": "Successful Response"
@@ -28324,7 +28413,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/compliance__api__email_template_routes__VersionCreate"
"$ref": "#/components/schemas/compliance__schemas__email_template__VersionCreate"
}
}
},
@@ -28334,7 +28423,11 @@
"200": {
"content": {
"application/json": {
"schema": {}
"schema": {
"additionalProperties": true,
"title": "Response Create Version For Template Api Compliance Email Templates Template Id Versions Post",
"type": "object"
}
}
},
"description": "Successful Response"