refactor: split cookie_screenshot_ocr.py (642 → 290 + 353 LOC)
CI / detect-changes (push) Successful in 7s
CI / branch-name (push) Has been skipped
CI / guardrail-integrity (push) Has been skipped
CI / secret-scan (push) Has been skipped
CI / dep-audit (push) Has been skipped
CI / sbom-scan (push) Has been skipped
CI / build-sha-integrity (push) Failing after 4s
CI / validate-canonical-controls (push) Successful in 11s
CI / loc-budget (push) Failing after 14s
CI / go-lint (push) Has been skipped
CI / python-lint (push) Has been skipped
CI / nodejs-lint (push) Has been skipped
CI / nodejs-build (push) Successful in 2m19s
CI / test-go (push) Has been skipped
CI / iace-gt-coverage (push) Has been skipped
CI / test-python-backend (push) Successful in 29s
CI / test-python-document-crawler (push) Has been skipped
CI / test-python-dsms-gateway (push) Has been skipped
CI / detect-changes (push) Successful in 7s
CI / branch-name (push) Has been skipped
CI / guardrail-integrity (push) Has been skipped
CI / secret-scan (push) Has been skipped
CI / dep-audit (push) Has been skipped
CI / sbom-scan (push) Has been skipped
CI / build-sha-integrity (push) Failing after 4s
CI / validate-canonical-controls (push) Successful in 11s
CI / loc-budget (push) Failing after 14s
CI / go-lint (push) Has been skipped
CI / python-lint (push) Has been skipped
CI / nodejs-lint (push) Has been skipped
CI / nodejs-build (push) Successful in 2m19s
CI / test-go (push) Has been skipped
CI / iace-gt-coverage (push) Has been skipped
CI / test-python-backend (push) Successful in 29s
CI / test-python-document-crawler (push) Has been skipped
CI / test-python-dsms-gateway (push) Has been skipped
CI hard-cap 500 LOC. cookie_screenshot_ocr.py war auf 642 gewachsen,
also gesplittet:
- cookie_screenshot_ocr_engines.py (353 LOC, NEU)
OCR-Engine-Funktionen: _slice_screenshot, Vision-LLM (qwen2.5vl),
PaddleOCR, Tesseract, parse_ocr_cookie_table, parse_vision_response,
Konstanten VISION_MODEL/OLLAMA_URL/VISION_PROMPT.
- cookie_screenshot_ocr.py (290 LOC, REWRITE)
Orchestration: capture_cookie_evidence_slices, _ocr_one_slice,
ocr_slices_extract_cookies, capture_cookie_screenshot,
extract_cookies_via_vision, cookies_to_vendor_records.
Re-Exports der Engine-Funktionen für Backward-Kompat.
Einziger externer Importer (_phase_d1_vendors_raw.py) braucht keinen
Code-Change — Public-API stabil.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,205 @@
|
||||
'use client'
|
||||
|
||||
/**
|
||||
* Template Rule Editor — Editorial-UI fuer Anwaelte/DSBs.
|
||||
*
|
||||
* Architektur:
|
||||
* - Links: RuleList mit Filter
|
||||
* - Rechts: RuleEditor mit Klassifikation, Condition-Builder, Source-Citation,
|
||||
* Approval-Workflow (draft → review → approved → published)
|
||||
*
|
||||
* Backend: /api/sdk/v1/compliance/template-rules + /template-rule-versions/*
|
||||
*/
|
||||
|
||||
import { useEffect, useState, useCallback } from 'react'
|
||||
import { useSDK } from '@/lib/sdk'
|
||||
import StepHeader from '@/components/sdk/StepHeader/StepHeader'
|
||||
import { useRuleEditorActions } from './_hooks/useRuleEditorActions'
|
||||
import type {
|
||||
ApprovalHistoryEntry, Classification, Rule, RuleCondition, RuleVersion,
|
||||
} from './_types'
|
||||
import RuleList from './_components/RuleList'
|
||||
import RuleEditor from './_components/RuleEditor'
|
||||
|
||||
export default function TemplateRuleEditorPage() {
|
||||
useSDK()
|
||||
|
||||
const actions = useRuleEditorActions()
|
||||
|
||||
const [rules, setRules] = useState<Rule[]>([])
|
||||
const [liveVersionsByRule, setLiveVersionsByRule] = useState<Record<string, RuleVersion | undefined>>({})
|
||||
const [selectedRuleId, setSelectedRuleId] = useState<string | null>(null)
|
||||
const [selectedVersions, setSelectedVersions] = useState<RuleVersion[]>([])
|
||||
const [selectedHistory, setSelectedHistory] = useState<ApprovalHistoryEntry[]>([])
|
||||
const [loading, setLoading] = useState(true)
|
||||
const [error, setError] = useState<string | null>(null)
|
||||
|
||||
// Initial: Regeln laden + Live-Versions
|
||||
const loadRules = useCallback(async () => {
|
||||
setLoading(true)
|
||||
setError(null)
|
||||
try {
|
||||
const list = await actions.listRules()
|
||||
setRules(list)
|
||||
const byRule: Record<string, RuleVersion | undefined> = {}
|
||||
// Live-Versionen parallel
|
||||
await Promise.all(
|
||||
list.map(async (r) => {
|
||||
try {
|
||||
const versions = await actions.listVersions(r.id)
|
||||
const live = versions.find((v) => v.is_live)
|
||||
byRule[r.id] = live
|
||||
} catch {
|
||||
byRule[r.id] = undefined
|
||||
}
|
||||
}),
|
||||
)
|
||||
setLiveVersionsByRule(byRule)
|
||||
if (list.length > 0 && !selectedRuleId) {
|
||||
setSelectedRuleId(list[0].id)
|
||||
}
|
||||
} catch (e) {
|
||||
setError((e as Error).message)
|
||||
} finally {
|
||||
setLoading(false)
|
||||
}
|
||||
}, [actions, selectedRuleId])
|
||||
|
||||
// Bei Selektions-Wechsel: Versions + History laden
|
||||
const loadSelected = useCallback(async () => {
|
||||
if (!selectedRuleId) {
|
||||
setSelectedVersions([])
|
||||
setSelectedHistory([])
|
||||
return
|
||||
}
|
||||
try {
|
||||
const versions = await actions.listVersions(selectedRuleId)
|
||||
setSelectedVersions(versions)
|
||||
const live = versions.find((v) => v.is_live)
|
||||
if (live) {
|
||||
const history = await actions.getApprovalHistory(live.id)
|
||||
setSelectedHistory(history)
|
||||
} else {
|
||||
setSelectedHistory([])
|
||||
}
|
||||
} catch (e) {
|
||||
setError((e as Error).message)
|
||||
}
|
||||
}, [actions, selectedRuleId])
|
||||
|
||||
useEffect(() => { loadRules() }, [])
|
||||
useEffect(() => { loadSelected() }, [selectedRuleId])
|
||||
|
||||
const handleCreateDraft = async (payload: {
|
||||
classification: Classification
|
||||
conditions: RuleCondition
|
||||
source_citation: string
|
||||
rationale?: string | null
|
||||
}) => {
|
||||
if (!selectedRuleId) return
|
||||
try {
|
||||
await actions.createDraftVersion(selectedRuleId, payload)
|
||||
await loadSelected()
|
||||
} catch (e) {
|
||||
setError((e as Error).message)
|
||||
}
|
||||
}
|
||||
|
||||
const handleUpdateDraft = async (versionId: string, patch: {
|
||||
classification?: Classification
|
||||
conditions?: RuleCondition
|
||||
source_citation?: string
|
||||
rationale?: string | null
|
||||
}) => {
|
||||
try {
|
||||
await actions.updateDraftVersion(versionId, patch)
|
||||
await loadSelected()
|
||||
} catch (e) {
|
||||
setError((e as Error).message)
|
||||
}
|
||||
}
|
||||
|
||||
const handleSubmitForReview = async (versionId: string, changeSummary: string) => {
|
||||
try {
|
||||
await actions.submitForReview(versionId, { change_summary: changeSummary })
|
||||
await loadSelected()
|
||||
} catch (e) {
|
||||
setError((e as Error).message)
|
||||
}
|
||||
}
|
||||
|
||||
const handleApprove = async (versionId: string) => {
|
||||
try {
|
||||
await actions.approveVersion(versionId)
|
||||
await loadSelected()
|
||||
} catch (e) {
|
||||
setError((e as Error).message)
|
||||
}
|
||||
}
|
||||
|
||||
const handlePublish = async (versionId: string) => {
|
||||
try {
|
||||
await actions.publishVersion(versionId)
|
||||
await loadRules()
|
||||
await loadSelected()
|
||||
} catch (e) {
|
||||
setError((e as Error).message)
|
||||
}
|
||||
}
|
||||
|
||||
const handleReject = async (versionId: string, reason: string) => {
|
||||
try {
|
||||
await actions.rejectVersion(versionId, { rejection_reason: reason })
|
||||
await loadSelected()
|
||||
} catch (e) {
|
||||
setError((e as Error).message)
|
||||
}
|
||||
}
|
||||
|
||||
const selectedRule = rules.find((r) => r.id === selectedRuleId)
|
||||
|
||||
return (
|
||||
<div className="h-full flex flex-col bg-white">
|
||||
<StepHeader
|
||||
stepId="template-rule-editor"
|
||||
title="Empfehlungs-Regeln"
|
||||
description="Editorial-UI für profilbasierte Dokument-Empfehlungen. Anwälte/DSBs editieren globale Regeln mit Approval-Workflow + Quellen-Attribution."
|
||||
/>
|
||||
{error && (
|
||||
<div className="px-5 py-2 bg-rose-50 border-b border-rose-200 text-sm text-rose-800">
|
||||
{error}
|
||||
</div>
|
||||
)}
|
||||
{loading && (
|
||||
<div className="p-5 text-sm text-gray-500">Lade Regeln…</div>
|
||||
)}
|
||||
{!loading && (
|
||||
<div className="flex-1 grid grid-cols-[320px_1fr] overflow-hidden">
|
||||
<RuleList
|
||||
rules={rules}
|
||||
versionsByRule={liveVersionsByRule}
|
||||
selectedRuleId={selectedRuleId}
|
||||
onSelectRule={setSelectedRuleId}
|
||||
/>
|
||||
{selectedRule ? (
|
||||
<RuleEditor
|
||||
rule={selectedRule}
|
||||
versions={selectedVersions}
|
||||
history={selectedHistory}
|
||||
onCreateDraft={handleCreateDraft}
|
||||
onUpdateDraft={handleUpdateDraft}
|
||||
onSubmitForReview={handleSubmitForReview}
|
||||
onApprove={handleApprove}
|
||||
onPublish={handlePublish}
|
||||
onReject={handleReject}
|
||||
/>
|
||||
) : (
|
||||
<div className="h-full grid place-items-center text-sm text-gray-500">
|
||||
Wähle links eine Regel zum Bearbeiten.
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
)
|
||||
}
|
||||
Reference in New Issue
Block a user